[ https://issues.jboss.org/browse/JBIDE-20026?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-20026 at 6/2/16 4:17 PM: ------------------------------------------------------------------ [~scabanovich] thanks for the PR, but as discussed with [~fbricon] we could select the connection type of the connection that was last used. The last used connection is available from ConnectionsRegistry#getRecentConnection. To set it's type to the connection type in the connection wizard you can get the matching IConnectionFactory from ConnectionsFactory#getByConnection. The persistence is not implemented and handling of the most recently used connection is incorrect, it will store the most recently created connection (not the most recently used one). {quote} (10:09:01 PM) adietisheim: slava_: i see the wizard calling the model in ConnectionWizardPage#onPageDeactivated (10:09:22 PM) adietisheim: slava_: but the code in the model to save it via ConnectionsRegistry#setRecent is commented (10:10:10 PM) adietisheim: ConnectionsWizardPageModel#saveRecentConnection is commented (10:11:57 PM) adietisheim: ah, persistence isnt impl'd at all, code is only holding it for the session. (10:12:35 PM) adietisheim: slava_: ConnectionsRegistry#setRecent is not persisting it, it is only holding it for the current Eclipse session (10:12:56 PM) adietisheim: but recentConnection is set when a new conn is created (10:13:06 PM) adietisheim: so the logic is bullock at best (10:13:24 PM) adietisheim: it's not the most recently used, but the most recently created connection (10:13:42 PM) adietisheim: and then only for the current Eclipse session {quote} was (Author: adietish): [~scabanovich] thanks for the PR, but as discussed with [~fbricon] we could select the connection type of the connection that was last used. The last used connection is available from ConnectionsRegistry#getRecentConnection. To set it's type to the connection type in the connection wizard you can get the matching IConnectionFactory from ConnectionsFactory#getByConnection. The persistence is not implemented and handling of the most recently used connection is incorrect, it will store the most recently created connection (not the most recently used one). {quote} (10:09:01 PM) adietisheim: slava_: i see the wizard calling the model in ConnectionWizardPage#onPageDeactivated (10:09:22 PM) adietisheim: slava_: but the code in the model to persist it via ConnectionsRegistry (that has the impl) is commented (10:09:35 PM) adietisheim: slava_: so I'd think that it's not being persisted, no (10:10:10 PM) adietisheim: ConnectionsWizardPageModel#saveRecentConnection is commented (10:11:57 PM) adietisheim: ah, persistence isnt impl'd at all, code is only holding it for the session. But the conn page isnt even calling it (10:12:56 PM) adietisheim: but recentConnection is set when a new conn is created (10:13:06 PM) adietisheim: so the logic is bullock at best (10:13:24 PM) adietisheim: it's not the most recently used, but the most recently created connection (10:13:42 PM) adietisheim: and then only for the current Eclipse session {quote} -- This message was sent by Atlassian JIRA (v6.4.11#64026)