[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=all ] Max Andersen updated JBIDE-1367: -------------------------------- Description: ds.xml ends up in both resources/ds.xml and in src/model/web-inf/ds.xml only one of them should be enough. was: ds.xml ends up in both resources/ds.xml and in src/model/web-inf/ds.xml only the one in resources should be deployed. Assignee: Denis Golovin looking in the code there seem to be a "to fix seam2 tests for war deployment" that makes the ds.xml copy twice. Why isn't there just *one* copy ? And if it was needed for test why not have it in the test project ?! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=comments#action_12389047 ] Denis Golovin commented on JBIDE-1367: -------------------------------------- As I remember there is a problem with JBoss MC that was fixed by creating one more copy for ds.file. I need to look at our chat to remember why it was done that way. But it looks like one is used for during the test of WAR configuration another one for ear. There are two persistence xml because seam-gen project do it this way. One persistence.xml for runtime that is copy of seam-gen/resources/META-INF/persistence-dev-war.xml and another one is copy of persistence-test.xml. ant scripts for WAR configuration: - <target name="jar" depends="compile,copyclasses" description="Build the distribution .jar file"> - <copy todir="${jar.dir}"> - <fileset dir="${basedir}/resources"> <include name="seam.properties" /> </fileset> </copy> - <copy todir="${jar.dir}/META-INF"> - <fileset dir="${basedir}/resources/META-INF"> <include name="ejb-jar.xml" /> </fileset> </copy> <copy tofile="${jar.dir}/META-INF/persistence.xml" file="${basedir}/resources/META-INF/persistence-${profile}.xml" overwrite="true" /> <copy tofile="${jar.dir}/import.sql" file="${basedir}/resources/import-${profile}.sql" overwrite="true" /> </target> - <target name="buildtest" depends="compiletest,copytestclasses" description="Build the tests"> - <copy todir="${test.dir}"> - <fileset dir="${basedir}/resources"> <exclude name="META-INF/persistence*.xml" /> <exclude name="import*.sql" /> <exclude name="${project.name}-*-ds.xml" /> </fileset> </copy> <copy tofile="${test.dir}/META-INF/persistence.xml" file="${basedir}/resources/META-INF/persistence-test-war .xml" overwrite="true" /> <copy tofile="${test.dir}/import.sql" file="${basedir}/resources/import-test.sql" overwrite="true" /> - <copy todir="${test.dir}" flatten="true"> - <fileset dir="${src.test.dir}"> <include name="**/*Test.xml" /> </fileset> </copy> </target> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=comments#action_12389051 ] Max Andersen commented on JBIDE-1367: ------------------------------------- yes - I did not change these things for Seam2 (since I wasn't aware of persistence.xml not actually being used) I just tested with seam2 yesterday and I could not see that it used persistence.xml in test during testing - it always took the one from the model; and I find it hard to belive that the persistence.xml in seam1 tests would be picked up since the location of persistence.xml decides which entities that will be picked up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=comments#action_12389175 ] Max Andersen commented on JBIDE-1367: ------------------------------------- Better test (will actually check if you can persist/load the specific entity: @Test public void testPersistenceWorking() throws Exception { new FacesRequest() { @Override protected void invokeApplication() throws Exception { EntityManagerFactory pc = (EntityManagerFactory) getValue("#{s2EntityManagerFactory}"); assert pc!=null; EntityManager em = pc.createEntityManager(); Session s = (Session) em.getDelegate(); System.out.println(s.getSessionFactory()); Customer c = new Customer(); s.persist(c); Assert.assertEquals(s.createQuery("from java.lang.Object").list().size(),1); s.delete(c); } }.run(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=comments#action_12389214 ] Max Andersen commented on JBIDE-1367: ------------------------------------- for Seam1 you have to add this method to the test too: @Override protected SeamPhaseListener createPhaseListener() { return new TransactionalSeamPhaseListener(); } otherwise the persist won't happen. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=comments#action_12389220 ] Max Andersen commented on JBIDE-1367: ------------------------------------- in seam1 then lower part of jboss-beans.xml in case of EAR need to have matching bean names.. <bean name="s1TestDatasource" class="java.lang.Object"> <constructor factoryMethod="getDatasource"> <factory bean="s1TestDatasourceBootstrap"/> </constructor> </bean> doesn't work, but <bean name="s1eDatasource" class="java.lang.Object"> <constructor factoryMethod="getDatasource"> <factory bean="s1eDatasourceBootstrap"/> </constructor> does -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1367?page=all ] Max Andersen resolved JBIDE-1367. --------------------------------- Resolution: Done I fixed the persistence.xml issue in seamgen for Seam 1.2.1.AP -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira