[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Maxim Areshkau updated JBIDE-9827: ---------------------------------- Attachment: npe.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Maxim Areshkau updated JBIDE-9827: ---------------------------------- Attachment: JBIDE-9827.diff patch which fix the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-9827: ------------------------------------------ Check for null has been added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9827: ------------------------------------- Steps to Reproduce: 1. Open the huge file. 2. Select the container which contains a plenty of childred (i.e. div, h:form, etc.) 3. Start to change its tag name to smt like h:formabcdefhigklmnopq1234567rst... 4. With every new letter refresh/update will be performed. 5. Very soon you'll get this NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Maxim Areshkau commented on JBIDE-9827: --------------------------------------- I have wrote junit test for it some time ago. So You can investigate is test running and why it doesn't catch this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-9827: ------------------------------------------ 1) For instance, you are changing a tag name from "h:form" to "h:form1". It causes "h:form" source node to be deleted from the source DOM tree. Then "h:form1" source node with all its children will be created in the source DOM model. 2) Then you change "h:form1" to "h:form12" -- the same steps from point 1) will be performed once again. And in the same way for every new text change in the tag's name. 3) After the source has been changed -- visual part has to be updated. For that reason there is notifyChanged(..) method in VpeController which runs "VPE_UPDATE_JOB_TITLE" UIJob. For every text change new Job will be created. 4) All these jobs are put into a queue. 5) After a number of queued jobs there is a situation when current job creates "h:form1" node but it has been already removed by "h:form12" change. Thus "h:form1" is no longer presents in the dom (in our case null is passed when children of "h:form1" supposed to be created). 6) If you continue text changes by typing "h:form12abc" -- several nulls will appear. I hope I wrote not too complex. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9827: ------------------------------------- Steps to Reproduce: 1. Open the huge file with a lot of tags and nested children. 2. Select the container which contains a plenty of childred (i.e. div, h:form, etc.) 3. Start to change its tag name by quick typing to smt like h:formabcdefhigklmnopq1234567rst... 4. With every new letter refresh/update will be performed. 5. Very soon you'll get this NPE. was: 1. Open the huge file. 2. Select the container which contains a plenty of childred (i.e. div, h:form, etc.) 3. Start to change its tag name to smt like h:formabcdefhigklmnopq1234567rst... 4. With every new letter refresh/update will be performed. 5. Very soon you'll get this NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-9827 at 10/7/11 9:50 AM: ------------------------------------------------------------------- Maxim probably was talking about JBIDE-675 junit. But it is passing. So I'll write SWTBot test. was (Author: dmaliarevich): Maxim probably was talking about JBIDE-675 junit. But it is passing. So I'll wrote SWTBot test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Golovin commented on JBIDE-9827: -------------------------------------- There is a simple way to explain that null pointer exception and key line that is the reason for that is [line 334 in VpeVisualDomBuilder|https://source.jboss.org/browse/JBossTools/trunk/vpe/...]. This line drives UI events processing form UI thread and that triggers processing for source nodes which is not supposed to happen until control get out of VpeVisualBuilder. If line 334 is commented out null check is not required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Yahor Radtsevich updated JBIDE-9827: ------------------------------------ Fix Version/s: 3.3.0.Beta1 (was: 3.3.0.M4) Bulk moved to 3.3.0.Beta1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-9827 at 11/15/11 6:46 AM: -------------------------------------------------------------------- Wrong linking. was (Author: dmaliarevich): Linking to JBIDE-10016 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9827?page=com.atlassian.jira.plugin... ] Vlado Pakan closed JBIDE-9827. ------------------------------ Verified on jbdevstudio 5.0.0.v201112130019M-H58-M5. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira