[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11299: ------------------------------- Attachment: eclipse372platform+JBTAbridged=ProjectExamplesFound.png IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11299: ------------------------------- Description: Steps to repro: 1. unpack eclipse-platform-3.7.2-linux-gtk-x86_64.tar.gz 2. install JBoss Tools 3.3.0.Beta1 (whole Abridged category) from http://download.jboss.org/jbosstools/updates/development/indigo/ 3. restart when prompted, and look at Central: !eclipse372platform+JBTAbridged=ProjectExamplesFound.png! Now, try again but only install Central (to save time, use JEE bundle): 1. unpack eclipse-jee-indigo-SR1-linux-gtk-x86_64.tar.gz 2. install JBoss Central 3.3.0.Beta1 (whole Abridged category) from http://download.jboss.org/jbosstools/updates/development/indigo/ 3. restart when prompted, and look at Central: !IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png! ---- When installing org.jboss.tools.central.feature_1.0.0.v20120307-1926-H67-Beta1, the following features should also be included: org.jboss.tools.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 org.jboss.tools.community.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 org.jboss.tools.maven.project.examples.feature_1.3.0.v20120307-0425-H80-Beta1 was: Steps to repro: 1. unpack eclipse-platform-3.7.2-linux-gtk-x86_64.tar.gz 2. install JBoss Tools 3.3.0.Beta1 (whole Abridged category) from http://download.jboss.org/jbosstools/updates/development/indigo/ 3. restart when prompted, and look at Central: !eclipse372platform+JBTAbridged=ProjectExamplesFound.png! Now, try again but only install Central (to save time, use JEE bundle): 1. unpack eclipse-jee-indigo-SR1-linux-gtk-x86_64.tar.gz 2. install JBoss Central 3.3.0.Beta1 (whole Abridged category) from http://download.jboss.org/jbosstools/updates/development/indigo/ 3. restart when prompted, and look at Central: !IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png! ---- When installing org.jboss.tools.central.feature_1.0.0.v20120307-1926-H67-Beta1, the following features should also be included: org.jboss.tools.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 org.jboss.tools.community.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 ...? What feature provides the quickstarts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11299: --------------------------------------- We can't add the org.jboss.tools.community.project.examples.feature to the JBoss Central feature because it mustn't be included in JBDS. JBDS requires the com.jboss.jbds.project.examples plugin. > Central should install Project Examples otherwise the Project Examples area on Getting Started tab says "No Entries Found" instead of showing JBoss Quickstarts > --------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: JBIDE-11299 > URL: https://issues.jboss.org/browse/JBIDE-11299 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: central > Affects Versions: 3.3.0.Beta1 > Reporter: Nick Boldt > Assignee: Nick Boldt > Fix For: 3.3.0.Beta2 > > Attachments: eclipse372platform+JBTAbridged=ProjectExamplesFound.png, IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png > > > Steps to repro: > 1. unpack eclipse-platform-3.7.2-linux-gtk-x86_64.tar.gz > 2. install JBoss Tools 3.3.0.Beta1 (whole Abridged category) from http://download.jboss.org/jbosstools/updates/development/indigo/ > 3. restart when prompted, and look at Central: > !eclipse372platform+JBTAbridged=ProjectExamplesFound.png! > Now, try again but only install Central feature (to save time, use JEE bundle): > 1. unpack eclipse-jee-indigo-SR1-linux-gtk-x86_64.tar.gz > 2. install ONLY JBoss Central 3.3.0.Beta1 from http://download.jboss.org/jbosstools/updates/development/indigo/ > 3. restart when prompted, and look at Central: > !IndigoSR1-JEE+Central+all-of-central=noProjectExamplesFound.png! > 4. If I then install these three features, the Quickstarts appear: > {code} > org.jboss.tools.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 > org.jboss.tools.community.project.examples.feature_1.2.1.v20120305-1726-H75-Beta1 > org.jboss.tools.maven.project.examples.feature_1.3.0.v20120307-0425-H80-Beta1 > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11299 at 3/14/12 12:22 PM: -------------------------------------------------------------- OK, so how about this: {code} org.jboss.tools.central.feature ------------------------------- includes: P org.jboss.tools.central P org.jboss.tools.project.examples.feature *NEW* P org.jboss.tools.community.project.examples.feature *NEW* P org.jboss.tools.maven.project.examples.feature *NEW* com.jboss.jbds.product.feature ------------------------------- includes: P com.jboss.jbds.central P com.jboss.jbds.project.examples P org.jboss.tools.central (NOT the feature!) *NEW* {code} was (Author: nickboldt): OK, so how about this: org.jboss.tools.central.feature ------------------------------- includes: P org.jboss.tools.central P org.jboss.tools.project.examples.feature *NEW* P org.jboss.tools.community.project.examples.feature *NEW* P org.jboss.tools.maven.project.examples.feature *NEW* com.jboss.jbds.product.feature ------------------------------- includes: P com.jboss.jbds.central P com.jboss.jbds.project.examples P org.jboss.tools.central (NOT the feature!) *NEW* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ Yes. Exclude the feature but include the plugin. Do you see a problem w/ that? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11299: --------------------------------------- That would work, but the JBoss Central feature wouldn't be shown in the About dialog of JBDS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11299 at 3/15/12 12:03 PM: -------------------------------------------------------------- Committed in trunk. Awaiting respins: https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--ce... >=433 https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.aggregate/ >=4280 https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.updatesite/ >=1760 was (Author: nickboldt): Committed in trunk. Builds fine in ~/jbt/central, but having problems building ~/jbds/product/ :( -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ Verified working using eclipse-jee-indigo-SR2-linux-gtk-x86_64.tar.gz and nightly core trunk site. Cannot yet verify changes in JBDS because installer build is blocked by JBIDE-11047. :( -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ I don't see the problem. In JBT, we include the required Community Examples stuff in the Central feature. In JBDS, the product includes only the Central plugin, as well as all the com.jboss.jbds stuff (eg., the JBDS Examples). We do have org.jboss.tools.community.central.feature and org.jboss.tools.community.central, which I suppose could be made to wrap the Examples stuff that JBT Central needs, but then you're still depending on users installing more than one feature. The goal of my fix was to make all the parts of JBT Central work OOTB after installing a SINGLE feature. (This usecase doesn't apply to Eclipse Marketplace installs or JBDS because we control what gets included.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11299: --------------------------------------------- Yes, so why is the *single feature* not solved by creating a feature that includes the shared central feature + community ? so we get uniformity of structure instead of a mix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11299: ------------------------------- Attachment: JBIDE11299.after.patch.png Added bonus is that NOW the Central site does not include the upstream plugins/features from Examples and Maven components so we don't risk problems with downstream aggregation. !JBIDE11299.after.patch.png! Requires is better than Includes, in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11299 at 4/3/12 4:07 PM: ------------------------------------------------------------ Resolving pending further complaints, suggestions, or verification problems. Also switched the com.jboss.jbds.product.feature back to include the JBT Central feature instead of just the plugin. Respins here: https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--ce... >=447 http://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.aggregate/ >=4471 http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.product/ >=1106 was (Author: nickboldt): Resolving pending further complaints, suggestions, or verification problems. Respin here: https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--ce... >=447 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ https://svn.jboss.org/repos/jbosstools/trunk/central/features/org.jboss.t... -- now only includes one plugin, because you disagreed w/ my previous implementation so I reverted to the previous solution (and wanted this feature to be available in JBT and JBDS) https://svn.jboss.org/repos/jbosstools/trunk/central/features/org.jboss.t... -- now includes these as dependencies when installing: <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> Meanwhile, JBDS includes this feature: https://svn.jboss.org/repos/devstudio/trunk/product/features/com.jboss.jb... which in turn includes <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> and <includes id="org.jboss.tools.central.feature" version="0.0.0" /> and requires <import feature="org.jboss.tools.project.examples.feature" /> Does that make sense? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11299: --------------------------------------- JBoss Central requires the project examples. org.jboss.tools.project.examples.feature, org.jboss.tools.maven.project.examples.feature and the org.jboss.tools.central plugin have to be included in both, JBT and JBDS. The com.jboss.jbds.project.examples plugin has to be included in JBDS. The org.jboss.tools.community.project.examples plugin has to be included in JBT. If a user installs the org.jboss.tools.central feature only, he won't have required project examples plugins and quickstarts/wizards won't work correctly. Currently, these features are defined in the following way: com.jboss.jbds.product.feature {code} <includes id="org.eclipse.platform" version="0.0.0" /> <includes id="com.jboss.jbds.m2e.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.product" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.usage.branding" download-size="0" install-size="0" version="0.0.0" unpack="false" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> <!-- JBIDE-11299 - include JBT Central feature (and contained plugin) in JBDS Central --> <!-- <plugin id="org.jboss.tools.central" download-size="0" install-size="0" version="0.0.0" unpack="false"/> --> <includes id="org.jboss.tools.central.feature" version="0.0.0" /> {code} org.jboss.tools.central.feature {code} <plugin id="org.jboss.tools.central" download-size="0" install-size="0" version="0.0.0" unpack="false"/> {code} org.jboss.tools.community.central.feature {code} <!-- JBIDE-11299 - include Examples features when installing Central --> <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} These definitions contain the following issues: - the org.jboss.tools.community.central plugin isn't necessary anymore and needs to be removed. - the com.jboss.jbds.product.feature feature has to include/require the org.jboss.tools.maven.project.examples plugin/feature. - the com.jboss.jbds.product.feature feature includes the org.jboss.tools.central plugin and doesn't have to include the org.jboss.tools.central.feature After fixing these issues, the org.jboss.central.feature feature would have to be removed from the update site. The user would have to install the org.jboss.tools.community.central.feature feature that includes all required plugins. {quote} Yes, and what I don't grok is why we don't have a com.jboss.jbds.central which does this: <imports id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> {quote} The com.jboss.jbds.central.feature isn't necessary. All the required plugins in JBDS can be added to the com.jboss.jbds.product.feature feature. {quote} Actually to be symmetric there should be features for those plugins but not sure why we have that in community too. {quote} The org.jboss.tools.community.central.feature would be a new feature that includes JBoss Central and all its required plugins/features in JBT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11299: --------------------------------------- We can add the c.j.jbds.central.feature if you want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Snjezana Peco commented on JBIDE-11299: --------------------------------------- We have to add the project examples feature as a dependency to jboss central. Since the project examples feature is different for JBT and JBDS, we have to set JBoss Central differently. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ Guys, this is solved. === JBoss Tools === Here's what's in the JBT Central Community Feature: {code:title=org.jboss.tools.community.central.feature/feature.xml} <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-11299 - include Examples features when installing Central --> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-10803 - include AS, Seam, Runtime features when installing Central --> <import feature="org.jboss.ide.eclipse.as.feature" version="2.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.seam.feature" version="3.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.core.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.as.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.seam.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} And since we only expose the JBT Central Community feature on the JBT Aggregate Site, there's a single feature to install which brings in Central and its deps: {code:title=build/aggregate/site/site.xml} <feature url="features/org.jboss.tools.community.central.feature_0.0.0.jar" id="org.jboss.tools.community.central.feature" version="0.0.0"> <category name="AbridgedTools" /> <category name="GeneralTools" /> </feature> <feature url="features/org.jboss.tools.central.feature_0.0.0.jar" id="org.jboss.tools.central.feature" version="0.0.0"> </feature> <feature url="features/org.jboss.tools.central.discovery.feature_0.0.0.jar" id="org.jboss.tools.central.discovery.feature" version="0.0.0"> </feature> {code} === JBDS === In JBDS, Central is pre-installed. So, no need to pick a feature or worry about hiding features on the update site. Here's the hierarchy in JBDS - main product feature includes the JBT Central feature (not the Community one) and the JBDS Central feature: {code:label=product/features/com.jboss.jbds.product.feature/feature.xml} <includes id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11299 at 5/2/12 1:34 PM: ------------------------------------------------------------ Guys, this is solved. === JBoss Tools === Here's what's in the JBT Central Community Feature: {code:title=central/features/org.jboss.tools.community.central.feature/feature.xml} <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-11299 - include Examples features when installing Central --> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-10803 - include AS, Seam, Runtime features when installing Central --> <import feature="org.jboss.ide.eclipse.as.feature" version="2.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.seam.feature" version="3.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.core.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.as.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.seam.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} And since we only expose the JBT Central Community feature on the JBT Aggregate Site, there's a single feature to install which brings in Central and its deps: {code:title=build/aggregate/site/site.xml} <!-- categorized feature --> <feature url="features/org.jboss.tools.community.central.feature_0.0.0.jar" id="org.jboss.tools.community.central.feature" version="0.0.0"> <category name="AbridgedTools" /> <category name="GeneralTools" /> </feature> <!-- hidden features --> <feature url="features/org.jboss.tools.central.feature_0.0.0.jar" id="org.jboss.tools.central.feature" version="0.0.0"></feature> <feature url="features/org.jboss.tools.central.discovery.feature_0.0.0.jar" id="org.jboss.tools.central.discovery.feature" version="0.0.0"></feature> {code} === JBDS === In JBDS, Central is pre-installed. So, no need to pick a feature or worry about hiding features on the update site. Here's the hierarchy in JBDS - main product feature includes the JBT Central feature (not the Community one) and the JBDS Central feature: {code:label=product/features/com.jboss.jbds.product.feature/feature.xml} <includes id="org.jboss.tools.project.examples.feature" version="0.0.0" /> <includes id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> {code} was (Author: nickboldt): Guys, this is solved. === JBoss Tools === Here's what's in the JBT Central Community Feature: {code:title=central/features/org.jboss.tools.community.central.feature/feature.xml} <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-11299 - include Examples features when installing Central --> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-10803 - include AS, Seam, Runtime features when installing Central --> <import feature="org.jboss.ide.eclipse.as.feature" version="2.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.seam.feature" version="3.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.core.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.as.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.seam.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} And since we only expose the JBT Central Community feature on the JBT Aggregate Site, there's a single feature to install which brings in Central and its deps: {code:title=build/aggregate/site/site.xml} <feature url="features/org.jboss.tools.community.central.feature_0.0.0.jar" id="org.jboss.tools.community.central.feature" version="0.0.0"> <category name="AbridgedTools" /> <category name="GeneralTools" /> </feature> <feature url="features/org.jboss.tools.central.feature_0.0.0.jar" id="org.jboss.tools.central.feature" version="0.0.0"> </feature> <feature url="features/org.jboss.tools.central.discovery.feature_0.0.0.jar" id="org.jboss.tools.central.discovery.feature" version="0.0.0"> </feature> {code} === JBDS === In JBDS, Central is pre-installed. So, no need to pick a feature or worry about hiding features on the update site. Here's the hierarchy in JBDS - main product feature includes the JBT Central feature (not the Community one) and the JBDS Central feature: {code:label=product/features/com.jboss.jbds.product.feature/feature.xml} <includes id="org.jboss.tools.project.examples.feature" version="0.0.0" /> <includes id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11299 at 5/2/12 1:39 PM: ------------------------------------------------------------ Guys, this is solved. === JBoss Tools === Here's what's in the JBT Central Community Feature: {code:title=central/features/org.jboss.tools.community.central.feature/feature.xml} <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-11299 - include Examples features when installing Central --> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-10803 - include AS, Seam, Runtime features when installing Central --> <import feature="org.jboss.ide.eclipse.as.feature" version="2.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.seam.feature" version="3.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.core.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.as.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.seam.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} And since we only expose the JBT Central Community feature on the JBT Aggregate Site, there's a single feature to install which brings in Central and its deps: {code:title=build/aggregate/site/site.xml} <!-- categorized feature --> <feature url="features/org.jboss.tools.community.central.feature_0.0.0.jar" id="org.jboss.tools.community.central.feature" version="0.0.0"> <category name="AbridgedTools" /> <category name="GeneralTools" /> </feature> <!-- hidden features --> <feature url="features/org.jboss.tools.central.feature_0.0.0.jar" id="org.jboss.tools.central.feature" version="0.0.0"></feature> <feature url="features/org.jboss.tools.central.discovery.feature_0.0.0.jar" id="org.jboss.tools.central.discovery.feature" version="0.0.0"></feature> {code} === JBDS === In JBDS, Central is pre-installed. So, no need to pick a feature or worry about hiding features on the update site. Here's the hierarchy in JBDS - main product feature includes the JBT Central feature (not the Community one) and the JBDS Central feature: {code:title=product/features/com.jboss.jbds.product.feature/feature.xml} <includes id="org.jboss.tools.project.examples.feature" version="0.0.0" /> <includes id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> {code} --- Max, the only outstanding question I see here is yours re: having a matching com.jboss.jbds.central feature (parallel to org.jboss.tools.community.central.feature) but that would only be useful if we planned to support installation of JBDS Central w/o also installing all of JBDS. Since JBDS *includes* all of Central's deps, I see no need to create yet another container-feature simply to declare installation dependencies. was (Author: nickboldt): Guys, this is solved. === JBoss Tools === Here's what's in the JBT Central Community Feature: {code:title=central/features/org.jboss.tools.community.central.feature/feature.xml} <requires> <import feature="org.jboss.tools.central.feature" version="1.0.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-11299 - include Examples features when installing Central --> <import feature="org.jboss.tools.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.community.project.examples.feature" version="1.2.1.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.maven.project.examples.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <!-- JBIDE-10803 - include AS, Seam, Runtime features when installing Central --> <import feature="org.jboss.ide.eclipse.as.feature" version="2.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.seam.feature" version="3.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.core.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.as.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> <import feature="org.jboss.tools.runtime.seam.detector.feature" version="1.3.0.qualifier" match="greaterOrEqual"/> </requires> <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0"/> {code} And since we only expose the JBT Central Community feature on the JBT Aggregate Site, there's a single feature to install which brings in Central and its deps: {code:title=build/aggregate/site/site.xml} <!-- categorized feature --> <feature url="features/org.jboss.tools.community.central.feature_0.0.0.jar" id="org.jboss.tools.community.central.feature" version="0.0.0"> <category name="AbridgedTools" /> <category name="GeneralTools" /> </feature> <!-- hidden features --> <feature url="features/org.jboss.tools.central.feature_0.0.0.jar" id="org.jboss.tools.central.feature" version="0.0.0"></feature> <feature url="features/org.jboss.tools.central.discovery.feature_0.0.0.jar" id="org.jboss.tools.central.discovery.feature" version="0.0.0"></feature> {code} === JBDS === In JBDS, Central is pre-installed. So, no need to pick a feature or worry about hiding features on the update site. Here's the hierarchy in JBDS - main product feature includes the JBT Central feature (not the Community one) and the JBDS Central feature: {code:title=product/features/com.jboss.jbds.product.feature/feature.xml} <includes id="org.jboss.tools.project.examples.feature" version="0.0.0" /> <includes id="org.jboss.tools.central.feature" version="0.0.0" /> <plugin id="com.jboss.jbds.project.examples" download-size="0" install-size="0" version="0.0.0" /> <plugin id="com.jboss.jbds.central" download-size="0" install-size="0" version="0.0.0" unpack="false" /> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ Ah, right. But I added it back because it provides a convenient single-feature way to install JBT Central and all its dependencies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ So you're saying we should keep the community.central feature, but remove the community.central feature? I'm good with that plan, if there's no reason to include the plugin. Please confirm and I can do this tomorrow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11299: ------------------------------- Attachment: JBIDE11299-remove-community-central-plugin-from-community-central-feature.patch.txt Patch to remove plugin applied in trunk and Beta3 branch: [^JBIDE11299-remove-community-central-plugin-from-community-central-feature.patch.txt] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Radim Hopp updated JBIDE-11299: ------------------------------- Attachment: CentralInstall.png As there is just "JBoss Central Community" to be selected in Available software in eclipse, can it be described better than just "JBoss Central Community"? Because the description of JBoss Central won't apper until next page of installation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11299: ------------------------------------ Set descriptions of features to be as follows. Committed to trunk and Beta3 branch: org.jboss.tools.central.feature/feature.properties description=JBoss Central provides a central hub for new and experienced users to get access to quickstarts, projects, documentation resources, news blogs and access to easy installation of recommended additonal plugins. Does not include upstream dependencies - see JBoss Central Community for a more complete installation. org.jboss.tools.community.central.feature/feature.properties description=JBoss Central provides a central hub for new and experienced users to get access to quickstarts, projects, documentation resources, news blogs and access to easy installation of recommended additonal plugins. Includes all dependencies to get started with JBoss Central. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11299?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11299: ------------------------------- Attachment: JBIDE11299installing-central.png JBIDE11299installed-central.png From: http://download.jboss.org/jbosstools/updates/JBossTools-3.3.0.Beta3b.core/ !JBIDE11299installing-central.png! !JBIDE11299installed-central.png! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira