[
https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-13671:
----------------------------------------
I'm investigating around the jgit provider and build timestamp plugin. I tried with
jbosstools-freemarker component, and I am sceptical about its practices. For the following
reason:
# It totally ignore local changes, so building a local, non-committed artifact result with
an artifact with the same timestamp as the last commit, which may already be published
somewhere. That means that there can be several same fully-qualified version whose content
differ. It's not at all OSGi-friendly.
# It deduces the timestamp from the *last commit that affected the module resources*
(incliding pom). So modules must really be "standalone" (ie not depend on other
resources that move indepndently of the module.
# If we change anything that does not affect the resources in a module (let's say we
change a groupId), the artifact will create a new version.
Although #2 and #3 should not happen in ideal case where modules are autonomous, they
could be annoying in the trickiest situation.
Item #1 is not acceptable in my opinion.
I don't think this git timestamp provider will make us produce less builds. We'd
better focus on not having to update components when it's not necessary (ie don't
re-build old stuff just because parent pom changed).
parent pom should use last-mod-timestamp from git for a
plugin/feature instead of current timestamp when building
-----------------------------------------------------------------------------------------------------------------
Key: JBIDE-13671
URL:
https://issues.jboss.org/browse/JBIDE-13671
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 4.1.0.Alpha1
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 4.1.0.Alpha2
Attachments: jbide13671-before-and-after.png
This needs to be added to master parent pom:
{code}
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-packaging-plugin</artifactId>
<version>${tycho.version}</version>
<dependencies>
<dependency>
<groupId>org.eclipse.tycho.extras</groupId>
<artifactId>tycho-buildtimestamp-jgit</artifactId>
<version>${tycho-extras.version}</version>
</dependency>
</dependencies>
<configuration>
<strictBinIncludes>false</strictBinIncludes>
<format>'v'yyyyMMdd-HHmm</format>
<timestampProvider>jgit</timestampProvider>
<jgit.ignore>
</jgit.ignore>
</configuration>
</plugin>
{code}
Ref:
http://pweclipse.blogspot.ch/2012_09_01_archive.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira