[
https://issues.jboss.org/browse/JBIDE-13599?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-13599:
---------------------------------------------
Wow - I did not realize you were using dmr code directly.
This explains why you rely on system properties since that is what dmr does - not what we
need.
I can also see that DMR would throw an exception if something wrong is resolved - is that
the behavior we need:
https://github.com/jbossas/jboss-dmr/blob/master/src/test/java/org/jboss/...
? (it might be but not seeing the code handling this.
DMR actually does seem to handle multiple values, i.e.
https://github.com/jbossas/jboss-dmr/blob/master/src/test/java/org/jboss/...
It's just a different syntax.
I can also see the default replacement seem to treat file seperators and path seperators
as a special case and return different results based on OS values - how does that
affect us ?
(
https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/...)
But why we want to add a direct dependency on this library for this simple functionality I
do not grok.
We should just copy the code and adjust it for what we need (looks like no changes needed
except a few for the above issues) - note, this is tough LGPL so need to adjust for that.
externalize Central site URL into a commandline property so that
testing or mirroring is easier
-----------------------------------------------------------------------------------------------
Key: JBIDE-13599
URL:
https://issues.jboss.org/browse/JBIDE-13599
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: central
Affects Versions: 4.1.0.Alpha1
Reporter: Nick Boldt
Assignee: Snjezana Peco
Fix For: 4.1.0.Alpha2
As discussed in
https://issues.jboss.org/browse/JBDS-2469?focusedCommentId=12755106&p...
testing Central is tricky if it's not properly bootstrapped, and bootstrapping is hard
when we're on an early Alpha and don't want bits to be public before they've
passed QE.
A better approach than having the update site URL used in Central's discovery
plugin.xml hardcoded into that file would be to have it read from a Preference in Eclipse
or JBDS. This would allow it to be overwritten/overridden should a user want to test
installation from a different URL than the default value.
This might even make it possible to have the same discovery plugin used for JBT and JBDS
(assuming the list of connectors were the same, and certification was to appear for both
instances) simply by having the preference changed to a different default URL when
installing JBT or JBDS BYOE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira