[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Stefan Bunciak updated JBIDE-10587: ----------------------------------- Attachment: image.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10587: ------------------------------------- Steps to Reproduce: # ASSERT: make sure you have a non-shared application (no cvs,svn,git,..) # EXEC: open OpenShift wizard,create app with the same name as the non-shared app, try to import it to workspace (do not use existing project") Result: The application is not imported (error dialog is shown !image.png|thumbnail! ), but the <home>/git/<app_name> dir was created and the git repo was cloned to that dir. was: #ASSERT: make sure you have a non-shared application (no cvs,svn,git,..) #EXEC: open OpenShift wizard,create app with the same name as the non-shared app, try to import it to workspace Result: The application is not imported (error dialog is shown !image.png|thumbnail! ), but the <home>/git/<app_name> dir was created and the git repo was cloned to that dir. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Stefan Bunciak commented on JBIDE-10587: ---------------------------------------- I know that Eclipse it self will not allow you to import duplicate named projects, of course, but I expect that no local git repo should be created, since no application was imported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Stefan Bunciak commented on JBIDE-10587: ---------------------------------------- I think the best solution is that before trying to clone git repo and import the application to workspace the wizard should check both conditions and try to clone git repo and import the application only if there is no <home>/git/<app_name> and no application in the workspace with the same name. This can prevent such code inconsistencies. But I don't know if this is possible... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Stefan Bunciak commented on JBIDE-10587: ---------------------------------------- In this situation I'm not sure how to handle this situation. As I see it there are 2 possible ways: 1) check the workspace whether it contains project/app with the same name before trying to clone the git repo 2) if 1. is not possible then delete the cloned git repo after import failure. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Stefan Bunciak commented on JBIDE-10587: ---------------------------------------- 1) ok 2) would be a good solution i think, it would depend on user whether to keep the files or delete them... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10587: ------------------------------------------ the new UI is validating this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-10587: ----------------------------------------- I thought from the previous comments between you and Stephan that the proposed solution is: Stefan: {quote} if 1. is not possible then delete the cloned git repo after import failure. {quote} Max: {quote} I agree but I would ask before deleting it. {quote} Stefan: {quote} would be a good solution i think, it would depend on user whether to keep the files or delete them... {quote} If you've decided to use another solution please comment and explain. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-10587: ----------------------------------------- I think it makes sense to keep it in this JIRA since the problem still persists just the steps to reproduce are slightly different: # Have an OpenShift application A with artifact name B in pom.xml (just on server, delete it from the workspace) # Create a local project B # Import application A from OpenShift RESULT: # An error occurs (because there already is a workspace project with name B) # The Git repository is created -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10587?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10587: ------------------------------------------ re-closing this issue and created a new bug for Beta1: JBIDE-11279. We cannot reproduce what we did for Beta1 otherwise. We agreed that the current warning is the best we can do for Beta1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira