[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Brian Fitzpatrick updated JBIDE-8490: ------------------------------------- Original Estimate: 0 minutes Remaining Estimate: 0 minutes Fix Version/s: 3.3.x -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Feng Qian commented on JBIDE-8490: ---------------------------------- For now, a impl class is created for every port type , not for every service. In the example.wsdl, every service has two ports, every port uses one port type. We prefer to use one port for every service. So we will have three choices for now: 1 keep the current solution, don't use a service that contains two ports in it. Only fix the 'wrong value' of service name issue. 2 make a big change, make sure we generate a impl for a service, not a porttype. It can fix this issue as a whole, but it is a complex feature. 3 add a choice box in ws dialog, let user to choose a service to generate. Then only generate these impls for the port types that are include by the service (the wtp cxf ws use it) I prefer to the third choice. Any comment? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Lukas Jungmann edited comment on JBIDE-8490 at 3/17/11 5:57 AM: ---------------------------------------------------------------- re opt 1 - seems to be the simplest solution re opt 2 - sounds too complicated to me re opt 3 - best option I think and something I'd like to suggest draft version of the UI for the jbossws panel in wtp's new top-down ws wizard I have in my head looks like: {noformat} +---------------------------------------------------------------+ | New Web Service | +---------------------------------------------------------------+ | JBoss Web Service Code Generation Configuration | | <space for info/error messages> | +---------------------------------------------------------------+ | | | WSDL Service: |______________________v_| | | | | Source folder: |________________________| [ Browse... ] | | Package: |________________________| [ Browse... ] | | Name: |________________________| | | | | Web Service name: |________________________| | | Web Service URL: |________________________| | | | | | | | | Artifacts package: |________________________| [ Browse... ] | | JAX-WS version: |______________________v_| | | Catalog file: |________________________| [ Add... ] | | Binding files: |________________________| [ Add... ] | | | | Additional options: |________________________| [ Help... ] | | | | | +---------------------------------------------------------------+ | [ < Back ] [ Next > ] [ Cancel ] [ Finish ] | +---------------------------------------------------------------+ {noformat} where: WSDL Service combobox - contains list of services/ports available in the wsdl ie in the form of "service#port" Source folder text field - contains project java source root (could be omitted now and added in the next iteration) Package and Name text fields - pkg/name of to be created web service implementation class Web Service name and URL text fields - values for mandatory entries in deployment descriptor (web.xml) Artifacts package text field - package for artifacts generated by wsconsume (-p option), if any JAX-WS version combo box - list of JAX-WS target version supported by particular JBossWS runtime Catalog and Binding files text fields - other options for wsconsume (binding files text field would contain list of files separated by space or ",") Additional options text field - for forward/backward compatibility, ie in JBossAS 6 there's new option "--additionalHeaders" which user/developer may want to set in some cases, this way we allow it for now and for other newly introduced options in the future without changing the UI Help button - runs "wsconsume.{sh|bat} -h" and shows filtered(?) output in some dialog so user can check what additional options he can pass to wsconsume opinions? was (Author: jlukas): re opt 1 - seems to be the simplest solution re opt 2 - sounds too complicated to me re opt 3 - best option I think and something I'd like to suggest draft version of the UI for the jbossws panel in wtp's new top-down ws wizard I have in my head looks like: +---------------------------------------------------------------+ | New Web Service | +---------------------------------------------------------------+ | JBoss Web Service Code Generation Configuration | | <space for info/error messages> | +---------------------------------------------------------------+ | | | WSDL Service: |______________________v_| | | | | Source folder: |________________________| [ Browse... ] | | Package: |________________________| [ Browse... ] | | Name: |________________________| | | | | Web Service name: |________________________| | | Web Service URL: |________________________| | | | | | | | | Artifacts package: |________________________| [ Browse... ] | | JAX-WS version: |______________________v_| | | Catalog file: |________________________| [ Add... ] | | Binding files: |________________________| [ Add... ] | | | | Additional options: |________________________| [ Help... ] | | | | | +---------------------------------------------------------------+ | [ < Back ] [ Next > ] [ Cancel ] [ Finish ] | +---------------------------------------------------------------+ where: WSDL Service combobox - contains list of services/ports available in the wsdl ie in the form of "service#port" Source folder text field - contains project java source root (could be omitted now and added in the next iteration) Package and Name text fields - pkg/name of to be created web service implementation class Web Service name and URL text fields - values for mandatory entries in deployment descriptor (web.xml) Artifacts package text field - package for artifacts generated by wsconsume (-p option), if any JAX-WS version combo box - list of JAX-WS target version supported by particular JBossWS runtime Catalog and Binding files text fields - other options for wsconsume (binding files text field would contain list of files separated by space or ",") Additional options text field - for forward/backward compatibility, ie in JBossAS 6 there's new option "--additionalHeaders" which user/developer may want to set in some cases, this way we allow it for now and for other newly introduced options in the future without changing the UI Help button - runs "wsconsume.{sh|bat} -h" and shows filtered(?) output in some dialog so user can check what additional options he can pass to wsconsume opinions? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Brian Fitzpatrick commented on JBIDE-8490: ------------------------------------------ @Grid, I'll have to look into this when I get back from EclipseCon next week. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Feng Qian commented on JBIDE-8490: ---------------------------------- O, if we want to make simple wizard to support top-down case, that means we need to support bottom-up in simple wizard too, right? if not, we use simple wizard for top-down, wtp framwork for bottom-up? users will be confused. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Feng Qian commented on JBIDE-8490: ---------------------------------- Lukas, Based on your draft, there are some problems: Name text fields: there are more than one implementation class because a wsdl service will have multi-ports, so the tools will generate multi porttype classes. I think we should remove the Name text, and generate implementation classes using the name: porttype class name + 'Impl' (cxf does it like this) Pakcage and Artifacts package: I think we should merge the two text into one(Package as now), then put generated Artifacts files into the Package, and put the implementation classes into the PackageName.impl. For example: org.eclipse.ws and or.eclipse.ws.impl Web Service name and URL text fields: as the upper said, we will generate multi implementation classes, so we will have multi web service name, so we can't make user input the multi web service name easily. I think we should remove these two text fields. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Feng Qian resolved JBIDE-8490. ------------------------------ Resolution: Done fixed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-8490?page=com.atlassian.jira.plugin... ] Jaroslav Jankovič closed JBIDE-8490. ------------------------------------ Verified with jbosstools-3.3_stable_branch.aggregate-Update-2012-05-27_14-14-33-H161. Closing this JIRA. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira