[JBoss JIRA] Created: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
5:49 a.m.
HQL/Criteria editor: when Save As is called no extension is attached automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: LATER
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12396374 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
User always can use CTRL+C, CTRL+V to paste query into his code.
I don't see the reason and way to help him to do this.
I think we need only provide default extension and call Save as instead of Save when file
hadn't been saved before.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: LATER
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12396415 ]
Max Andersen commented on JBIDE-1668:
-------------------------------------
When you use Ctrl+1 in source you can select to make the query that should be shown in HQL
or Criteria editor.
A query opened that way would make sense to allow "saving back to where it came
from" - just an idea.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: LATER
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12400444 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
Ok, I'll bind this on Ctrl+4 keys.
This will work for java and hbm.xml files.
Algorithm is the following:
1. User selects some text in editor1.
2. presses Ctrl+4, HQL with the text opens.
3. user modifies the text in HQL editor and presses Save
4. selected text in editor1 is replaced with query from HQL editor.
Max, what should we do if user changes text in editor1 before he press save in HQL editor
(and at the old offset other text situated - not selected before)?
possible solutions:
1. Replace text which is situated on the old place (the worst)
2. Replace selected(highlited) text (or paste it to the cursor position if selection is
empty)
3. Replace all old text entries with new entry into editor1 (We can ask user whether he
wants it).
I choose second solution.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: LATER
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:36 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12401138 ]
Max Andersen commented on JBIDE-1668:
-------------------------------------
Why Ctrl+4 and not Ctrl+1 as until now ?
I would say we would need to know more safely where the user is initially starting the
editor from....and if the selection has changed definitly ask the user if he really wants
this replaced if the selection changed.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: LATER
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12401724 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
I use Ctrl+4 because for java editor Ctrl+1 .. Ctrrl+3 is occupated. And it is rather
uncomfortable when there is 2 same key bindings.
But we can find other free key sequence: not Ctrl+number.
Now if user changes the selection in editor from wich he went to the HQL editor, he will
be asked wether he wants selection would be replaced by the new query.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=all ]
Dima Geraskov resolved JBIDE-1668.
----------------------------------
Fix Version/s: 2.1
(was: LATER)
Resolution: Done
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12401726 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
It is logical to create the same issue for Criteria editor. And bind the action for
example on Ctrl+5.
But if we can distinguish what editor should be opened by selected query it will be the
best solution.
In this way requisite editor will be opened base on the query.
Have we the distinguish mechanism?
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12401736 ]
Max Andersen commented on JBIDE-1668:
-------------------------------------
We already have "Send to HQL editor" and "Send to Criteria editor"
bound to Ctrl+1. Why change that ?
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 a.m.
New subject: [JBoss JIRA] Reopened: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=all ]
Max Andersen reopened JBIDE-1668:
---------------------------------
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12402726 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
Early I have realized my own key binding, but now I have found that we use Ctrl+1 via
extention point org.eclipse.jdt.ui.quickAssistProcessors in org.hibernate.eclipse.jdt.ui.
I changed the functional and I think now it works as you expected.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=all ]
Dima Geraskov resolved JBIDE-1668.
----------------------------------
Resolution: Done
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:49 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=comments#action_12403114 ]
Dima Geraskov commented on JBIDE-1668:
--------------------------------------
Improvements:
1) we need to ask the user if he wants the changes to go back into the file where it came
from ...right now it happens "behind his back"
2) we should at least show a dialog by default (which the user then can have an
"don't show this dialog" again option for)
3) the replacement failure dialog also need improvement. The user gets no info on what you
are referring to. "Document has changed, could not find string to replace"
...which document is that and what string is it ?
4) the query editor should somehow show in the ui that it is linked to an editor...and
when that editor is closed it should show it is no longer linked.
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:05 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-1668) HQL/Criteria editor: when Save As is called no extension is attached automatically
[ http://jira.jboss.com/jira/browse/JBIDE-1668?page=all ]
Max Andersen updated JBIDE-1668:
--------------------------------
Fix Version/s: 2.1.0.beta1
(was: 2.1)
batch update of issues with 2.1 fix instead of the correct 2.1.b1
HQL/Criteria editor: when Save As is called no extension is attached
automatically
----------------------------------------------------------------------------------
Key: JBIDE-1668
URL: http://jira.jboss.com/jira/browse/JBIDE-1668
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Dima Geraskov
Assigned To: Dima Geraskov
Priority: Minor
Fix For: 2.1.0.beta1
when Save As is called no extension (hql?) is attached automatically -> will be not
possible to easy reopen this file. Save doesn't work if "Save As" was not
called first.
from Max: "minor thing - but the best thing was that save as actually saved it back
to where the query came from (e.g. hbm.xml or java code)"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6572
days inactive
6651
days old
jbosstools-issues@lists.jboss.org
13 comments
2 participants
participants (2)
-
Dima Geraskov (JIRA) -
Max Andersen (JIRA)