]
Viacheslav Kabanovich updated JBIDE-22159:
------------------------------------------
Story Points: 1
Docker image is empty after selecting it from Image search wizard
-----------------------------------------------------------------
Key: JBIDE-22159
URL:
https://issues.jboss.org/browse/JBIDE-22159
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.3.1.CR1
Reporter: Fred Bricon
Assignee: Viacheslav Kabanovich
Fix For: 4.4.0.Alpha3
As discovered in
https://github.com/jbosstools/jbosstools-openshift/pull/1106#issuecomment...,
provided you have a docker and an OpenShift connection:
- In OpenShift Explorer, select the Deploy Image menu
- select the docker connection
- type a docker image name already pulled in the docker daemon
- delete it and click the search... button
- select the same docker image as previously typed
- once the search wizard closes, the docker Image name field is still empty.
See
http://screencast.com/t/iTJX7SjB
As per [~scabanovich]:
{quote}
it is possible that validator does not let empty string to model, so model remains with
valid previous value. Then, when you select that same value in the dialog, model is
notified, but it already has that value and it does not notify ui because it did not
change
{quote}
and his fix proposal:
{quote}
before calling setImageName(newValue) check if it has the same value, then call
setImageName(""); and only after this check and adjustment call
setImageName(newValue).
{quote}