]
Andre Dietisheim updated JBIDE-22426:
-------------------------------------
Labels: connection openshift_v3 (was: )
Connection: authorization strategy is always overwritten (in the
client) upon #isConnected
-------------------------------------------------------------------------------------------
Key: JBIDE-22426
URL:
https://issues.jboss.org/browse/JBIDE-22426
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.4.0.Alpha3
Reporter: Andre Dietisheim
Labels: connection, openshift_v3
Fix For: 4.4.0.Alpha3
The current implementation of Connection#isConnected() will always overwrite the
authorization strategy in the client that it is using. This seems wrong given that
#getResources, #createResource, #updateResource (and other methods) also set it but check
if it already exists beforehand. Making sure that they dont overwrite an existing
strategy.
{code:title=Connection#isConnected}
public boolean isConnected(IProgressMonitor monitor) {
client.setAuthorizationStrategy(getAuthorizationStrategy());
try {
{code}
{code:title=Connection#createResource}
public <T extends IResource> T createResource(T resource) {
try {
if(client.getAuthorizationStrategy() == null) {
client.setAuthorizationStrategy(getAuthorizationStrategy());
}
return client.create(resource);
{code}