[ https://issues.jboss.org/browse/JBIDE-19335?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-19335: --------------------------------------------- inconsistent property - all explained in the PR - but putting it here for ref in case you missed it: {quote} if it is going to be there then follow the naming pattern/conventions we have elsewhere. lowercase "scoped" by package/feature so that would be something like 'jbosstools.skip.browser.creation' even though I can see it seems in foundation there is already several variations; but lets not make it worse. and since it is a boolan it should not accept skipBrowserCreation=false {quote} mixed license text - you answered "Good catch" on the PR (see https://github.com/jbosstools/jbosstools-base/pull/419#discussion-diff-33...) so sounds like you agreed with me there - what changed ? no tests - this issue talks about a specific error situation, can that not be tested for ? many plugins now have swtbot tests for several years so can look for that. -- This message was sent by Atlassian JIRA (v6.3.15#6346)