[JBoss JIRA] Created: (JBIDE-9520) LocalJBossBehaviorDelegate#canChangeState should not swallow Exception
5:18 a.m.
LocalJBossBehaviorDelegate#canChangeState should not swallow Exception
----------------------------------------------------------------------
Key: JBIDE-9520
URL: https://issues.jboss.org/browse/JBIDE-9520
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Reporter: Andre Dietisheim
LocalJBossBehaviorDelegate#canChangeState swallows an Exception can would occur when
getting the jboss runtime for a given server:
{code}
public IStatus canChangeState(String launchMode) {
try {
if( getServer() != null
&& getServer().getRuntime() != null
&& RuntimeUtils.checkedGetJBossServerRuntime(getServer()).getVM() != null )
return Status.OK_STATUS;
} catch(Exception e) {
// ignore
}
return new Status(IStatus.ERROR, JBossServerCorePlugin.PLUGIN_ID,
MessageFormat.format(Messages.ServerHasNoRuntime, getServer().getName()));
}
{code}
RuntimeUtils#checkedGetJBossServerRuntime throws a CoreException if fetching failed. We
should not swallow this exception but return it instead of a general purpose error
status.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:20 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9520) LocalJBossBehaviorDelegate#canChangeState should not swallow Exception
[
https://issues.jboss.org/browse/JBIDE-9520?page=com.atlassian.jira.plugin...
]
Andre Dietisheim updated JBIDE-9520:
------------------------------------
Assignee: Andre Dietisheim
Fix Version/s: 3.3.0.M3
Affects Version/s: 3.3.0.M3
Component/s: JBossAS
LocalJBossBehaviorDelegate#canChangeState should not swallow
Exception
----------------------------------------------------------------------
Key: JBIDE-9520
URL: https://issues.jboss.org/browse/JBIDE-9520
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
LocalJBossBehaviorDelegate#canChangeState swallows an Exception can would occur when
getting the jboss runtime for a given server:
{code}
public IStatus canChangeState(String launchMode) {
try {
if( getServer() != null
&& getServer().getRuntime() != null
&& RuntimeUtils.checkedGetJBossServerRuntime(getServer()).getVM() != null )
return Status.OK_STATUS;
} catch(Exception e) {
// ignore
}
return new Status(IStatus.ERROR, JBossServerCorePlugin.PLUGIN_ID,
MessageFormat.format(Messages.ServerHasNoRuntime, getServer().getName()));
}
{code}
RuntimeUtils#checkedGetJBossServerRuntime throws a CoreException if fetching failed. We
should not swallow this exception but return it instead of a general purpose error status.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-9520) LocalJBossBehaviorDelegate#canChangeState should not swallow Exception
[
https://issues.jboss.org/browse/JBIDE-9520?page=com.atlassian.jira.plugin...
]
Andre Dietisheim resolved JBIDE-9520.
-------------------------------------
Resolution: Done
committed to TRUNK (M3)
LocalJBossBehaviorDelegate#canChangeState should not swallow
Exception
----------------------------------------------------------------------
Key: JBIDE-9520
URL: https://issues.jboss.org/browse/JBIDE-9520
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
LocalJBossBehaviorDelegate#canChangeState swallows an Exception can would occur when
getting the jboss runtime for a given server:
{code}
public IStatus canChangeState(String launchMode) {
try {
if( getServer() != null
&& getServer().getRuntime() != null
&& RuntimeUtils.checkedGetJBossServerRuntime(getServer()).getVM() != null )
return Status.OK_STATUS;
} catch(Exception e) {
// ignore
}
return new Status(IStatus.ERROR, JBossServerCorePlugin.PLUGIN_ID,
MessageFormat.format(Messages.ServerHasNoRuntime, getServer().getName()));
}
{code}
RuntimeUtils#checkedGetJBossServerRuntime throws a CoreException if fetching failed. We
should not swallow this exception but return it instead of a general purpose error status.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 a.m.
New subject: [JBoss JIRA] (JBIDE-9520) LocalJBossBehaviorDelegate#canChangeState should not swallow Exception
[
https://issues.jboss.org/browse/JBIDE-9520?page=com.atlassian.jira.plugin...
]
Martin Malina closed JBIDE-9520.
--------------------------------
LocalJBossBehaviorDelegate#canChangeState should not swallow
Exception
----------------------------------------------------------------------
Key: JBIDE-9520
URL: https://issues.jboss.org/browse/JBIDE-9520
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: JBossAS/Servers
Affects Versions: 3.3.0.M3
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.M3
LocalJBossBehaviorDelegate#canChangeState swallows an Exception can would occur when
getting the jboss runtime for a given server:
{code}
public IStatus canChangeState(String launchMode) {
try {
if( getServer() != null
&& getServer().getRuntime() != null
&& RuntimeUtils.checkedGetJBossServerRuntime(getServer()).getVM() != null )
return Status.OK_STATUS;
} catch(Exception e) {
// ignore
}
return new Status(IStatus.ERROR, JBossServerCorePlugin.PLUGIN_ID,
MessageFormat.format(Messages.ServerHasNoRuntime, getServer().getName()));
}
{code}
RuntimeUtils#checkedGetJBossServerRuntime throws a CoreException if fetching failed. We
should not swallow this exception but return it instead of a general purpose error status.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5114
days inactive
5352
days old
jbosstools-issues@lists.jboss.org
3 comments
2 participants
participants (2)
-
Andre Dietisheim (JIRA) -
Martin Malina (JIRA)