[
https://issues.jboss.org/browse/JBIDE-18752?page=com.atlassian.jira.plugi...
]
Carofe Carofe commented on JBIDE-18752:
---------------------------------------
At least the second STK is exactly what I have commented in the first place. The diff with
the fix is for this problem, which is *obvious* in the code that there is a bug.
The fix not only solve the problem but also gives you support for freemarker 2.4 and it is
the most efficient thing you can get: a state machine for pattern detection. I'm very
surprised that this simple fix, which is not a huge number of lines (therefore easy to
review and verify), is being discharged because of the 2.3 vs 2.4 thing.
Freemarker plugin does not work for square bracket (since JBT
4.2.0.Final)
--------------------------------------------------------------------------
Key: JBIDE-18752
URL:
https://issues.jboss.org/browse/JBIDE-18752
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: freemarker
Affects Versions: 4.2.0.Final
Reporter: Denis Golovin
Assignee: Max Rydahl Andersen
Fix For: 4.3.0.Beta1
From
https://github.com/jbosstools/jbosstools-freemarker/issues/26
{quote}
When using the plugin to edit freemarker files that use the square bracket syntax the
editor fails to highlight the syntax (this is happening in JBoss Tools 4.20 Final).
I think the file: src / org / jboss / ide / eclipse / freemarker / editor /
DocumentProvider.java
on line 70 is causing the syntax highlighting problem:
{code}if (ch != LexicalConstants.SQUARE_SYNTAX_MARKER.charAt(i)) {
return SyntaxMode.ANGLE;
}
SQUARE_SYNTAX_MARKER.charAt(i)
{code}
It should start in 0 and have a different index than i (the index of the file content) to
have a proper string matching. Also, SQUARE_SYNTAX_MARKER is [#ftl, not all files start
with a ftl tag, so I don't see the need for "ftl" at the end, so that's
why in the following example fix I put j < 2.
e.g.
{code}
int j =0;
for (; i < docLength && j < 2; i++) {
char ch = document.getChar(i);
if (ch != LexicalConstants.SQUARE_SYNTAX_MARKER.charAt(j)) {
return SyntaxMode.ANGLE;
}
j++;
}
{code}
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)