[
https://issues.jboss.org/browse/JBIDE-17919?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-17919 at 8/4/14 9:29 AM:
------------------------------------------------------------------
[~jcantrill] the basic design intended to always set the filename for the user, not
allowing a user to pick a name freely. This made the whole UI a lot easier in terms of
validation (and since we're in a hurry mostly...). The filename that is constructed
also should always use the type of the snapshot and some numerical snapshot if there's
already a file with the filepattern that we use:
*<application>-<snapshot-type><numerical suffix if required>.tar.gz
I did not reproduce the bug but as far as I understand the problem is solely in the
<snapshot-type> not being switched correctly in some situations?
To me our approach has some benefits compared to rhc. Blindly overwriting is never a good
option imho. I thus dont think that we should care about consistency with a inferior
approach?
was (Author: adietish):
[~jcantrill] the basic design intended to always set the filename for the user, not
allowing a user to pick a name freely. This made the whole UI a lot easier in terms of
validation (and since we're in a hurry mostly...). The filename that is constructed
also should always use the type of the snapshot and some numerical snapshot if there's
already a file with the filepattern that we use:
*<application>-<snapshot-type><numerical suffix if required>.tar.gz
I did not reproduce the bug but as far as I understand the problem is solely in the
<snapshot-type> not being switched correctly in some situations?
Snapshot wizard: snapshot file name is not refreshed upon changes
between full and deployment type
--------------------------------------------------------------------------------------------------
Key: JBIDE-17919
URL:
https://issues.jboss.org/browse/JBIDE-17919
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.2.0.Beta3
Reporter: Marián Labuda
Assignee: Jeff Cantrill
Labels: snapshot_wizard
Fix For: 4.2.0.CR1
When trying to create a new snapshot of FULL or DEPLOYMENT type after creating a snapshot
earlier, there is no change of file name for the snapshot. It's still the same file
name as it was for the snapshot created right before.
I think there was intention to let user overwrite previously created snapshot. But this
brings complications because of snapshot type. We should not override FULL snapshot with
DEPLOYMENT snapshot. I think also, that there should not be overriding at all, but it
should be distinguished as it is (after workaround) by number of snapshot.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)