[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Rob Stryker updated JBIDE-9953: ------------------------------- Attachment: JBIDE-9953.patch This is the patch, requesting permission from max -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Pavol Srna commented on JBIDE-9953: ----------------------------------- Reopening because the "Push dialog" is hidden behind the "Publish to Openshift Server" dialog. Rob, can you make the "Push" dialog to be modal? At the first moment I didn't noticed that there is some dialog behind the "Publish to Openshift Server" dialog and I thought that the process is stucked. So I think this can lead to bad user experience. WDYT? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Pavol Srna commented on JBIDE-9953: ----------------------------------- This is probably not blocking, because the workaround is easy. You can simply move the "Publishing to .. OpenShift Server..." dialog and select "yes" or "no" on the "Publish mytestapp?" dialog as shown on the attached screenshot. But my first experience was that I didn't know if the publish process is stucked or what's going on, because the "Publish mytestapp?" dialog was hidden behind the other dialog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Pavol Srna commented on JBIDE-9953: ----------------------------------- Steps to reproduce: 1) create new application using OpenShift, JBoss AS Cartridge 2) make some changes to index.html 3) click "Publish" on the server adapter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-9953: --------------------------------------- Assignee: Rob Stryker (was: Pavol Srna) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Len DiMaggio commented on JBIDE-9953: ------------------------------------- "On linux there is a simple workaround" Pavol - what is the workaround? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-9953: -------------------------------------- The issue happens the ExpressPublishMethod.requestApproval method. It calls MessageBox as follows: MessageBox messageBox = new MessageBox(new Shell(), SWT.ICON_QUESTION | SWT.YES | SWT.NO); which creates a dialog that is independent of the main Eclipse shell and can be hidden (depending on a OS). The solution is to use active shell that can be got in the following way: private static Shell getActiveShell() { Display display = Display.getDefault(); final Shell[] ret = new Shell[1]; display.syncExec(new Runnable() { public void run() { ret[0] = Display.getCurrent().getActiveShell(); } }); return ret[0]; } I recommend using the MessageDialog class (included in the patch) instead of the MessageBox class. I am using this technique in the project examples plugin and haven't had similar issues yet. Attached is a patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen commented on JBIDE-9953: -------------------------------------------- Thanks Snjezana! Patch looks on my quick look good. Rob can you test/apply/reject it ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Andre Dietisheim edited comment on JBIDE-9953 at 11/4/11 6:43 AM: ------------------------------------------------------------------ weird, I cannot reproduce it. I always get the push request confirmation dialog but not the progress dialog. My progress always sticks to the progress view (even when starting with a new runtime-workspace and even a fresh configuration-area). was (Author: adietish): weird, I cannot reproduce it either. I always get the push request confirmation dialog but not the progress dialog. My progress always sticks to the progress view (even when starting with a new runtime-workspace and even a fresh configuration-area). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Andre Dietisheim commented on JBIDE-9953: ----------------------------------------- I checked the preferences and I dont have the "Always run in background" checked. Even though I dont get the progress in its own dialog. weird. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Nick Boldt commented on JBIDE-9953: ----------------------------------- Please verify using latest M4b builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9953?page=com.atlassian.jira.plugin... ] Pavol Srna commented on JBIDE-9953: ----------------------------------- Verified on jbosstools-3.3_stable_branch.aggregate-Update-2011-11-04_12-20-02-H39. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira