[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent

Wednesday, 12 October 2016

    [
https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi...
] 

Dmitrii Bocharov commented on JBIDE-23182:
------------------------------------------

I don't think it's an Eclipse issue. It's more an intended behavior.
I reviewed the PR and tried to find if somebody had the same problems. I think [this
answer|http://stackoverflow.com/questions/8682978/how-to-make-a-propertys...]
is the most suitable for us:
{quote} ... But since PropertySheetPage is designed to change its input on global
selection change, then you have to find some custom way to notify/update your
handler.{quote}

So i agree with the last Slava's comment. _HandlerUtil.getCurrentSelection(event)_
takes the selection from the context. So if we sum up, we need to update EvaluationContext
in OpenShiftResourcePropertySection class for example like this:
{code:java}table.addSelectionChangedListener(new ISelectionChangedListener() {

			@Override
			public void selectionChanged(SelectionChangedEvent event) {
				IHandlerService service = (IHandlerService)
page.getSite().getService(IHandlerService.class);
				service.getCurrentState().addVariable(ISources.ACTIVE_CURRENT_SELECTION_NAME,
table.getSelection());

			}
		});{code}

But this made no sense, because in the example above i'm trying to update the global
evaluation context from getter. Nothing just happens. So the way to solve it is to define
a child evaluation context, which will be used then in Handlers too.
I think it's a much bigger refactoring, than the one that Slava made. I think we
should merge it.

However, i might have missed some possibilities and maybe someone has more experience with
updating the evaluation context. That is the thing that should be done for Properties view
similarly to what i offered above, because it's a "peculiar" view.

...
 NullPointerException in PodLogsHandler.handleEvent
 --------------------------------------------------

                 Key: JBIDE-23182
                 URL: https://issues.jboss.org/browse/JBIDE-23182
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: openshift
            Reporter: Automated Error Reporting Bot
              Labels: openshift_v3, pod_log_console
             Fix For: 4.4.2.AM2

 The following problem was reported via the automated error reporting:
 Message: Unhandled event loop exception
 {noformat}
 java.lang.NullPointerException: null
     at
org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
     at
org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
     at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
     at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
     at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
     at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
     at java.lang.reflect.Method.invoke(null:-1)
     at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
 {noformat}
 Bundles:
 | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
 | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
 | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
 Operating Systems:
 | Windows | 10.0.0 | 10.0.0 |
 The above information is a snapshot of the collected data. Visit [this
page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the
latest data.
 Thank you for your assistance.
  Your friendly error-reports-inbox. 

--
This message was sent by Atlassian JIRA
(v6.4.11#64026)

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006