[
https://issues.jboss.org/browse/JBIDE-8316?page=com.atlassian.jira.plugin...
]
Viacheslav Kabanovich commented on JBIDE-8316:
----------------------------------------------
It is interesting that our code that worked for more three years became erroneous due to
check added to org.eclipse.ui.part.EditorPart. Adding new page, we (by mistake) do it with
null editor input, but after that call setInput() with correct object. In previous Eclipse
versions it was not illegal to set null input, and now it results in
IllegalArgumentException. As a result, Tiles editor became absolutely disabled. Since the
fix is trivial, and since it is not good to have 3.2.0 without Tiles editor, I suggest
adding changes to 3.2.0.
Tiles Editor cannot be opened for newly created tiles file
----------------------------------------------------------
Key: JBIDE-8316
URL:
https://issues.jboss.org/browse/JBIDE-8316
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: struts/shale
Affects Versions: 3.2.0.CR1
Reporter: Denis Golovin
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.M1
Attachments: screenshot70.png
Tiles editor is opened by default after creating tiles file by New Tile wizard called
from context menu on Web Projects view. It looks like
!screenshot70.png!
Log contains exception
{noformat}java.lang.IllegalArgumentException:
at org.eclipse.core.runtime.Assert.isLegal(Assert.java:63)
at org.eclipse.core.runtime.Assert.isLegal(Assert.java:47)
at org.eclipse.ui.part.EditorPart.setInput(EditorPart.java:224)
at
org.jboss.tools.jst.web.tiles.ui.editor.TilesGuiEditor.setInput(TilesGuiEditor.java:40)
at
org.jboss.tools.common.model.ui.editor.DefaultEditorPart.init(DefaultEditorPart.java:89)
at
org.jboss.tools.common.editor.AbstractSectionEditor.init(AbstractSectionEditor.java:139)
at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:237)
at org.eclipse.ui.part.MultiPageEditorPart.addPage(MultiPageEditorPart.java:211)
at
org.jboss.tools.jst.web.tiles.ui.editor.TilesCompoundEditor.createGuiPage(TilesCompoundEditor.java:66)
at
org.jboss.tools.jst.web.tiles.ui.editor.TilesCompoundEditor.doCreatePages(TilesCompoundEditor.java:50)
at
org.jboss.tools.common.editor.ObjectMultiPageEditor.createPages(ObjectMultiPageEditor.java:239)
at
org.eclipse.ui.part.MultiPageEditorPart.createPartControl(MultiPageEditorPart.java:348)
at
org.jboss.tools.common.model.ui.editor.EditorPartWrapper.createPartControl(EditorPartWrapper.java:176)
at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:670)
at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:465)
at
org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595)
at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313)
at
org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
at
org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
at
org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
at
org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1254)
at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1207)
at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1606)
at org.eclipse.ui.internal.PartStack.add(PartStack.java:497)
at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103)
at org.eclipse.ui.internal.PartStack.add(PartStack.java:483)
at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112)
at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63)
at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:225)
at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:213)
at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:778)
at
org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:677)
at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:638)
at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2860)
at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2768)
at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2760)
at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2711)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2707)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2691)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2674)
at org.jboss.tools.common.editor.OpenEditorWizard.execute(OpenEditorWizard.java:97)
at
org.jboss.tools.common.model.handlers.OpenEditorHandler.executeHandler(OpenEditorHandler.java:31)
at
org.jboss.tools.common.meta.action.impl.XActionImpl.executeHandler(XActionImpl.java:65)
at
org.jboss.tools.common.model.ui.action.XModelObjectAction.actionPerformed(XModelObjectAction.java:96)
at
org.jboss.tools.common.model.ui.action.XModelObjectActionInvoker.execute(XModelObjectActionInvoker.java:36)
at org.jboss.tools.common.meta.action.XActionInvoker.invoke(XActionInvoker.java:53)
at org.jboss.tools.common.meta.action.XActionInvoker.invoke(XActionInvoker.java:40)
at
org.jboss.tools.common.model.ui.select.SelectObjectWizard.openEditor(SelectObjectWizard.java:139)
at
org.jboss.tools.common.model.ui.select.SelectObjectWizard.execute(SelectObjectWizard.java:47)
at
org.jboss.tools.common.model.util.FindObjectHelper.findModelObject(FindObjectHelper.java:40)
at
org.jboss.tools.common.model.files.handlers.CreateFileSupport$1.run(CreateFileSupport.java:241)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3515)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3164)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407){noformat}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira