[
https://jira.jboss.org/browse/JBIDE-7393?page=com.atlassian.jira.plugin.s...
]
Yahor Radtsevich edited comment on JBIDE-7393 at 10/26/10 12:46 PM:
--------------------------------------------------------------------
Regular expression language is a standard.
Regular expressions
are completely uncommon for Eclipse filters and they are not a standard here. Standard way
to filter entries like these is to use '?' and '*'. For examples see
Window->Preferences, Opened Editors Toolbar->Show List, Open Type, Open Resource,
Preferences->General->Keys, etc.
What if user wants to select all properties with values that include
the question mark?
IMO, this rare case cannot be a reason to force user to use this
nonstandard way of filtering and to type two symbols everywhere instead one ('.*'
instead of '*').
I may propose to implement '?' and '*' filtering by default and keep the
"Expression" checkbox but with a more clear name: "Regular
Expression".
was (Author: yradtsevich):
Regular expression language is a standard.
Regular expressions
are completely uncommon for Eclipse filters and they are not a standard here. Standard way
to filter entries like these is to use '?' and '*'. For examples see
Window->Preferences, Opened Editors Toolbar->Show List, Open Type, Open Resource,
Preferences->General->Keys, etc.
What if user wants to select all properties with values that include
the question mark?
IMO, this rare case cannot be a reason to force user to use this
nonstandard way of filtering and to type two symbols everywhere instead one ('.*'
instead of '*').
I may propose to use '?' and '*' filtering by default and keep the
"Expression" checkbox but with a more clear name: "Regular
Expression".
Properties Editor -> Filter -> tooo complex logik for me
--------------------------------------------------------
Key: JBIDE-7393
URL:
https://jira.jboss.org/browse/JBIDE-7393
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: core
Affects Versions: 3.2.0.Beta2
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Minor
I did not understand how this works, really. I do not so smart to print regular
expression to search some property.
I did not guess from the first look "Expression" means regular expression - I
search JIRA to find what it mean and how it should work...
I find JBIDE-4572, JBIDE-4576.
but really I do think what JBIDE-4576 is not about "real" regular expressions!
it is just about support "*" and "?" - a good example here is Ctrl-O
search in Java files.
the example how it works now - source file:
hibernate.connection.driver_class=org.hsqldb.jdbcDriver
hibernate.connection.password=
hibernate.connection.url=jdbc:hsqldb:hsql://localhost/
hibernate.connection.username=sa
hibernate.dialect=org.hibernate.dialect.HSQLDialect
hibernate.dialect222=org.hibernate.dialect.HSQLDialect222
"di*2" - find nothing...
so really my opinion - regular expressions here is options for genius...
just simple "*" and "?" support is necessary.
"Case sensitive" - this option look like excessive.. - I wrote my opinion in
JBIDE-4572 -
checkbox "Case sensitive" - is simple to understand - so it could be here.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira