[ https://issues.jboss.org/browse/JBIDE-10104?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-10104: ----------------------------------------------- Class CSSClassHyperlink invokes Arrays.binarySearch(String[] styleWords, String styleName, Comparator); to look for styleName among styleWords. Comments to 'binarySearch' method mention that array is supposed to be ordered with the same comparator. The fix is easy enough to be done for 3.3.0.Beta1. There is one more case, which requires to improve CSSClassHyperlink.COMPARE_CLASS_REGEX_PREFIX regular expression. EXECUTE: Create style {code} p[id="111"].style1 {background: blue; font-size: 30} {code} EXECUTE: Create html {code} <p id="111" class="style1">abc1</p> {code} ASSERT: Open-on opens the style p[id="111"].style1. And because this is context-dependent style, it should be implemented taking into account attribute values: EXECUTE: Create html {code} <p id="112" class="style1">abc1</p> {code} ASSERT: Open-on does not opens the style p[id="111"].style1. That last case should be considered as new feature request. Also, if there are several declarations {code} p .style1 {background: blue; font-size: 30} div .style1 {background: yellow; font-size: 30} {code} search should be implemented taking into account parents of node specifying class='style1'. Simple matching that we have will always open the first declaration which may be irrelevant. However, I would also separated that as a feature request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10104?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-10104: ----------------------------------------------- Victor, your patch is ok as a first approximation, please apply it. I will create new feature request for other cases, mentioned in my comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10104?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich resolved JBIDE-10104. ------------------------------------------- Assignee: Victor Rubezhny (was: Viacheslav Kabanovich) Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira