[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Snjezana Peco commented on JBDS-2048: ------------------------------------- The servers that the user adds when installing JBDS are automatically created. JBDS worked this way from the beginning. If you think we should change this behavior, please create a new jira. Fixed. Committed to the trunk. Attached is a patch. > Runtime detection: Location not added to the paths list > ------------------------------------------------------- > > Key: JBDS-2048 > URL: https://issues.jboss.org/browse/JBDS-2048 > Project: Developer Studio (JBoss Developer Studio) > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: runtime > Affects Versions: 5.0.0.Beta1 > Environment: Mac OS X 10.7 Lion latest > jbdevstudio-product-universal-5.0.0.v201203010100M-H88-Beta1.jar > Reporter: Martin Malina > Priority: Blocker > Fix For: 5.0.0.Beta1 > > Attachments: jbds-2048.patch > > > Runtime detection for locations added during installation doesn't work correctly. > Scenario: > 1. Run JBDS universal installer > 2. During installation add two runtime locations: One to be checked at every start, one not > 3. Start the newly installed JBDS with a new workspace -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Snjezana Peco reassigned JBDS-2048: ----------------------------------- Assignee: Max Rydahl Andersen Max, please review the patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Martin Malina commented on JBDS-2048: ------------------------------------- Yes, I believe that's how it worked in the past - the locations added during installation were searched for at first start of JBDS and the user was asked to install the found runtimes. So I believe FAIL1 should still be fixed. Max, what do you think? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Snjezana Peco commented on JBDS-2048: ------------------------------------- In my previous comment I have mentioned that FAIL1 isn't fixed and explained why I didn't fix it. Right. FAIL1 is related to the runtimes the user added when executed the JBDS installer. They are created automatically without showing the dialog. This dialog can be easily added. IMO, it is unnecessary because it is certain that the user wants to create runtimes that he added when installing JBDS. The fix for FAIL2 has been committed to the trunk only. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Snjezana Peco commented on JBDS-2048: ------------------------------------- Now JBDS automatically adds EAP if it is included in JBDS. JBDS will also try to find runtimes in the directories that the user added when installing JBDS. If JBDS finds a runtime in some of those directories, the standard Runtime Detection dialog will be shown. Committed to the trunk. Attached is a new patch (jbds-2048a.patch). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen commented on JBDS-2048: ------------------------------------------- I dont follow this patch. If the installer adds EAP specifically then that should not be added to the runtime path scanning. It should just be installed and nothing added to the runtime scanning. Whatever the installer adds to runtime paths should always be treated as any other runtime path search - but the patch seem to say "if the path added to runtime path == EAP install path then don't ask" ....which makes no sense to me because that "EAP install path" shouldn't be part of the install paths. Does the installer even setup an EAP install path anymore ? Is it not just all search runtime paths ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Snjezana Peco updated JBDS-2048: -------------------------------- Attachment: jbds-2048.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen commented on JBDS-2048: ------------------------------------------- Now Approved! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen commented on JBDS-2048: ------------------------------------------- jbds-2048b.patch now attached and now the fix makes sense. Approved. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-2048: ------------------------------------- @Max, installer doesn't do anything beyond copying EAP to ${devstudio-install-folder}/jboss-eap -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-2048: ------------------------------------- Max, my answer was only about JBoss EAP. If user select to install JBoss EAP during installation it comes to ${install-folder}/jboss-eap. Runtimes plugin check if this folder exists, detect runtime in this folder and add it without asking user about it. All paths configured during installation go to .properties file in installation target folder and runtimes plugin then use these paths to configure runtimes scanning list. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2048?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-2048: ------------------------------------- I see easy way. New servers just should be installed in runtimes folder and with fixed JBDS-2014 it should just work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira