[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=all ] Max Andersen updated JBIDE-1913: -------------------------------- Fix Version/s: LATER -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=comments#action_12413029 ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- As properties defined in plugin.xml have specified type make the dialog more friendly (add combobox for boolean property, add Browse button for Path/directory and validators). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=comments#action_12413312 ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- I guess that the difference between types "directory" and "path" is: "directory" can't be a path to file. I surprised when noticed that "type" property hadn't been read from plugin.xml( for ExporterProperty) and ExporterProperty hadn't field to hold it! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=comments#action_12413324 ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- template_path marked as path outputdir marked as directory -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=comments#action_12413531 ] Max Rydahl Andersen commented on JBIDE-1913: -------------------------------------------- No it means a path. proj1\src\f1;proj2src\f2; ... just like PATH in an os or classpath in java. Note, I think the current ui implementation just looks at it as a directory....but in the core its a path. Not sure what you mean with the required ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1913?page=all ] Dima Geraskov updated JBIDE-1913: --------------------------------- Attachment: PropertyDialogPatch_JBIDE-1913.txt Now path is ';' separated string. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov updated JBIDE-1913: --------------------------------- Attachment: (was: PropertyDialogPatch_JBIDE-1913.txt) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- 1) When I edit a path the previous value in there is not shown in the editor. Not only the path, but all other values too. Fixed. 2) If the path contains unknown paths it removes them without warning (this is most an issue when I use eclipse variables in the path). a) We can change Browse button functional to work as add button (oldPath+;newPath), b) or show the message: "Paths "c:\dfdf, d:\dfdf" not found" before path selection dialog shown, c) or show the message: "Paths "#{dfdf}, d:\dfdf," will be deleted from 'Template path' string" after selection of new path 3) Not sure if this is an iissue, but under linux it puts : instead of ; (need to check if hibernatetools actually honors that) I am using File.pathSeparator and think that this is better then hardcode ';' as path separator. Comment from File.pathSeparatorChar: The system-dependent path-separator character. This field is /* * initialized to contain the first character of the value of the system * property <code>path.separator</code>. This character is used to * separate filenames in a sequence of files given as a <em>path list</em>. * On UNIX systems, this character is <code>':'</code>; on Microsoft Windows systems it * is <code>';'</code>. */ Are you agree? But may be it requires to change parameter value parsing, I am not shure too and will see if you agree, and change File.pathSeparator to hardcoded ';' if you don't agree. 4) How can I select external/non-workspace directory ? In now way right now. I need to add one more dialog. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- Exporter doesn't work even on windows if path is ';' separated string. It is not expected such string. Seems like it is easy to fix, and we'll be possible to use File.pathSeparator. It works -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov resolved JBIDE-1913. ---------------------------------- Resolution: Done Assignee: Anton Klimkovich (was: Dima Geraskov) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- I tried code on linux and find only 1 difference: property combobox doesn't call selectionChangedEvent when using arrow_up/down. This is fixed. Max, if you notice another one, please say about it here. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-1913: -------------------------------------- Yes, because this symbol is java.io.File.pathSeparator. I said that using thisstatic variable is better then using hardcoded ';'. And as I remember you was agree with me. You only worried about 'interpretation'. If you see here to the changes of class ExporterProperty(commit 10737). I am using File.pathSeparator char as string delimitter. So, the behaviour should be equal. The only thing - may be I didn't take into account all possible variants of using launch configuration (I didn't find any more)... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-1913: --------------------------------------- Priority: Critical (was: Minor) we should get this fixed before beta1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-1913?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-1913: -------------------------------------------- Dima if you use : on linux the path will look like: "/htools/templates:/htools/othertemplates" and running this on linux will give you 2 dirs, correct ? but if you load that on windows (i.e. on your other machine or another team members machine) it will only return one (bogus) dir since it uses ; instead. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira