9:35 a.m.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Alexey Kazakov
Fix For: 3.3.0.Beta1
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič updated JBIDE-10210:
--------------------------------------
Attachment: 01.correctRefactor.png
02.wrongRefactor.png
Screenshots of correct and incorrect behaviour of CDI Refactor attached.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Alexey Kazakov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:59 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Daniel Azarov commented on JBIDE-10210:
---------------------------------------
I can reproduce this issue only if xhtml file opened in the editor.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:01 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Daniel Azarov updated JBIDE-10210:
----------------------------------
Fix Version/s: 3.3.0.M5
(was: 3.3.0.Beta1)
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Alexey Kazakov
Fix For: 3.3.0.M5
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-10210:
-----------------------------------
Fix Version/s: 3.3.0.Beta1
(was: 3.3.0.M5)
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Alexey Kazakov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:44 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-10210:
-------------------------------------------
Alexey, this problem I described in Description: "Also, another issue, I have found
with the steps to reproduce, is disappearing CDI Refactor option in context menu."
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-10210:
-------------------------------------------
Daniel, will your fix apply also on the second issue, which me and also Alexey noticed?
(no CDI Refactoring option in contexe menu). If no, I will log a new JIRA for it.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič edited comment on JBIDE-10210 at 12/3/11 8:50 AM:
--------------------------------------------------------------------
Daniel, will your fix apply also on the second issue, which me and also Alexey noticed?
(no CDI Refactoring option in context menu). If no, I will log a new JIRA for it.
was (Author: jjankovi):
Daniel, will your fix apply also on the second issue, which me and also Alexey
noticed? (no CDI Refactoring option in contexe menu). If no, I will log a new JIRA for
it.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:07 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Alexey Kazakov commented on JBIDE-10210:
----------------------------------------
Jaroslav, there is no need to create a new issue since I beleive it's the same issue
related to the way we save the files after refactoring.
So this bug is still reproducable and we should fix it.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-10210:
-------------------------------------------
Yeah Alexey, I believe it too, I only wanted to be clear in this.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Alexey Kazakov commented on JBIDE-10210:
----------------------------------------
Suppose we have two projects:
ProjectA (WAR with WebContent folder) and ProjectB (JAR w/o WebContent).
ProjectB depends on ProjectA.
ProjectA has a @Named bean and a xhtml page which uses this bean.
Try to refactor the name of the bean. You will get the following exception:
{code}
org.eclipse.core.internal.resources.ResourceException: Resource
'/tck-child/WebContent' does not exist.
at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:320)
at org.eclipse.core.internal.resources.Resource.checkAccessible(Resource.java:194)
at org.eclipse.core.internal.resources.Container.members(Container.java:266)
at org.eclipse.core.internal.resources.Container.members(Container.java:249)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scan(RefactorSearcher.java:183)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:121)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:92)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.findELReferences(RefactorSearcher.java:145)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.renameBean(RenameNamedBeanProcessor.java:61)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.checkFinalConditions(RenameNamedBeanProcessor.java:44)
at
org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:224)
at
org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:85)
at
org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:121)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
at
org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
{code}
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Alexey Kazakov edited comment on JBIDE-10210 at 1/5/12 2:53 PM:
----------------------------------------------------------------
Suppose we have two projects:
ProjectA (WAR with WebContent folder) and ProjectB (JAR w/o WebContent).
ProjectB depends on ProjectA.
ProjectA has a @Named bean and a xhtml page which uses this bean.
Try to refactor the name of the bean. You will get the following exception:
{code}
org.eclipse.core.internal.resources.ResourceException: Resource
'/ProjectB/WebContent' does not exist.
at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:320)
at org.eclipse.core.internal.resources.Resource.checkAccessible(Resource.java:194)
at org.eclipse.core.internal.resources.Container.members(Container.java:266)
at org.eclipse.core.internal.resources.Container.members(Container.java:249)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scan(RefactorSearcher.java:183)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:121)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:92)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.findELReferences(RefactorSearcher.java:145)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.renameBean(RenameNamedBeanProcessor.java:61)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.checkFinalConditions(RenameNamedBeanProcessor.java:44)
at
org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:224)
at
org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:85)
at
org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:121)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
at
org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
{code}
was (Author: akazakov):
Suppose we have two projects:
ProjectA (WAR with WebContent folder) and ProjectB (JAR w/o WebContent).
ProjectB depends on ProjectA.
ProjectA has a @Named bean and a xhtml page which uses this bean.
Try to refactor the name of the bean. You will get the following exception:
{code}
org.eclipse.core.internal.resources.ResourceException: Resource
'/tck-child/WebContent' does not exist.
at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:320)
at org.eclipse.core.internal.resources.Resource.checkAccessible(Resource.java:194)
at org.eclipse.core.internal.resources.Container.members(Container.java:266)
at org.eclipse.core.internal.resources.Container.members(Container.java:249)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scan(RefactorSearcher.java:183)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:121)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:92)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.findELReferences(RefactorSearcher.java:145)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.renameBean(RenameNamedBeanProcessor.java:61)
at
org.jboss.tools.cdi.internal.core.refactoring.RenameNamedBeanProcessor.checkFinalConditions(RenameNamedBeanProcessor.java:44)
at
org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:224)
at
org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:85)
at
org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:121)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
at
org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
{code}
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Alexey Kazakov resolved JBIDE-10210.
------------------------------------
Assignee: Daniel Azarov (was: Alexey Kazakov)
Resolution: Done
fixed
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 a.m.
[
https://issues.jboss.org/browse/JBIDE-10210?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič closed JBIDE-10210.
-------------------------------------
Verified in JBDS 5.0.0.v201202140303N-H930-Beta1.Closing JIRA.
EL refactoring for @Named beans doesn't work properly
-----------------------------------------------------
Key: JBIDE-10210
URL: https://issues.jboss.org/browse/JBIDE-10210
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI, JSF
Affects Versions: 3.3.0.M4
Reporter: Jaroslav Jankovič
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: 01.correctRefactor.png, 02.wrongRefactor.png
Sometimes, refactoring @Named annotation doesn't include EL as it should be. Also,
another issue, I have found with the steps to reproduce, is disappearing CDI Refactor
option in context menu. Workaround exists, it is the same workaround for both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4523
days inactive
4608
days old
jbosstools-issues@lists.jboss.org
13 comments
11 participants
participants (11)
-
Alexey Kazakov (Commented) (JIRA) -
Alexey Kazakov (Issue Comment Edited) (JIRA)
-
Alexey Kazakov (Resolved) (JIRA)
-
Alexey Kazakov (Updated) (JIRA)
-
Daniel Azarov (Commented) (JIRA)
-
Daniel Azarov (Updated) (JIRA)
-
Jaroslav Jankovič (Commented) (JIRA)
-
Jaroslav Jankovič (Created) (JIRA)
-
Jaroslav Jankovič (Issue Comment Edited) (JIRA)
-
Jaroslav Jankovič (JIRA)
-
Jaroslav Jankovič (Updated) (JIRA)