10:28 p.m.
Xavier Coulon created JBIDE-12646:
-------------------------------------
Summary: web.xml servlet-name validation is not case-sensitive
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Alexey Kazakov
Priority: Minor
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:01 a.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-12646:
-----------------------------------
Issue Type: Bug (was: Feature Request)
Assignee: Viacheslav Kabanovich (was: Alexey Kazakov)
Fix Version/s: 4.0.0.Beta1
Priority: Major (was: Minor)
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:22 a.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Xavier Coulon commented on JBIDE-12646:
---------------------------------------
Sorry, I hadn't noticed that the issue was typed as a 'feature request' and
not as a 'bug' when I created it. It is a bug, indeed.
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich updated JBIDE-12646:
------------------------------------------
Attachment: ServletNameValidation.png
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:12 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-12646:
-----------------------------------------------
I cannot reproduce the issue (see ServletNameValidation.png). Is it possible that in your
case validation just delayed or failed to start when the file was created? If, after you
get the warning when a letter is missing, you insert that letter back in a wrong case, do
you get the warning or it disappears?
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:26 a.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Xavier Coulon commented on JBIDE-12646:
---------------------------------------
Viacheslav,
Sorry for the delay.
I'm still able to reproduce it, so let me give you steps to try on your machine:
1. From Central, create a project using the HTML5 template
2. In the project, add a web deployment descriptor with the following content:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/rest/*</url-pattern>
</servlet-mapping>
{code}
As you can see, there's a upper/lower case error in the servlet name: it should be
Jax*R*sActivator instead of Jax*r*sActivator, but there's no warning there. On the
other hand, removing a character in the servlet name triggers a warning.
Let me know if you can reproduce it.
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-12646:
-----------------------------------------------
That was exactly what I did, and screen ServletNameValidation.png shows class
JaxrsActivator with lower case 'r' and warning at it.
I made sure in sources that it cannot be a case-sensitivity issue. It maybe either a delay
or a failure of validation after project and web.xml creation, but I still cannot
reproduce it.
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.Beta1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-12646:
-----------------------------------
Fix Version/s: 4.0.0.CR1
(was: 4.0.0.Beta1)
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.CR1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:28 a.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Xavier Coulon commented on JBIDE-12646:
---------------------------------------
Viacheslav,
Can you tell me which plugin is doing this validation ? Maybe I just don't have it in
my runtime workbench.
Thanks
Xavier
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.CR1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 a.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-12646:
-----------------------------------------------
This check is done by org.jboss.tools.jst.web.validation.CheckServletMappingName in
org.jboss.tools.jst.web plugin.
After it checks that servlet-mapping@servlet-name does not reverence any
servlet@servlet-name, it looks in Java project for a Java class by name. If class is not
found, error marker is created.
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.0.0.CR1
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-12646:
-----------------------------------
Fix Version/s: 4.1.x
(was: 4.0.0.CR1)
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.1.x
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:08 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Alexey Kazakov commented on JBIDE-12646:
----------------------------------------
Xavier, are you still able to reproduce the problem?
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.1.x
Attachments: ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:09 p.m.
[
https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi...
]
Xavier Coulon updated JBIDE-12646:
----------------------------------
Attachment: JBIDE-12646 - Wi-Fi.m4v
Alexey,
I'm still seeing the issue and I attached a screencast to show what's happening.
On the one hand, having a bad class name triggers a warning, but OTOH, having the correct
class name minus uppercase/lowercase does not trigger the expectecd warning.
web.xml servlet-name validation is not case-sensitive
-----------------------------------------------------
Key: JBIDE-12646
URL: https://issues.jboss.org/browse/JBIDE-12646
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 4.0.0.Alpha1
Reporter: Xavier Coulon
Assignee: Viacheslav Kabanovich
Fix For: 4.1.x
Attachments: JBIDE-12646 - Wi-Fi.m4v, ServletNameValidation.png
[Using the HTML5 sample project generated from Central]
I'm adding a servlet declaration in the web.xml file but the web.xml editor does not
report a warning when the servlet name case is wrong:
{code}
<servlet-mapping>
<servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
<url-pattern>/hello/*</url-pattern>
</servlet-mapping>
{code}
In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
On the other hand, it properly reports a warning when a letter is missing in the
classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4246
days inactive
4304
days old
jbosstools-issues@lists.jboss.org
12 comments
3 participants
participants (3)
-
Alexey Kazakov (JIRA) -
Viacheslav Kabanovich (JIRA)
-
Xavier Coulon (JIRA)