[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-1957: ---------------------------------- Thanks for testing this. This is exactly what I was asking for when I added SVN, git, gwt, jrebel, etc. to Central -- is enough stuff in there, or is more required? Here's what we provide in JBDS in a single wrapper feature [0]: {code} <import feature="com.collabnet.subversion.merge.feature" version="2.2.3" match="compatible"/> <import feature="com.sun.jna" version="3.2.7" match="compatible"/> <import feature="org.tigris.subversion.clientadapter.feature" version="1.6.12" match="compatible"/> <import feature="org.tigris.subversion.clientadapter.javahl.feature" version="1.6.15" match="compatible"/> <import feature="org.tigris.subversion.clientadapter.svnkit.feature" version="1.6.15" match="compatible"/> <import feature="org.tigris.subversion.subclipse.graph.feature" version="1.0.9" match="compatible"/> <import feature="org.tigris.subversion.subclipse.mylyn" version="3.0.0" match="compatible"/> <import feature="org.tigris.subversion.subclipse" version="1.6.17" match="compatible"/> <import feature="org.tmatesoft.svnkit" version="1.3.5.7406" match="compatible"/> {code} [0] https://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbd... I can add the svnkit and svnkit clientadapter features. Might have to include JNA too, as well as the generic clientadapter feature. JavaHL is platform-specific -- adding that would mean adding several more features to cover our various supported OSes (3 or 6 more). Problem is, where now there's 1 SVN-related feature (one click), the above suggestion gets us to 5 (svnkit, svnkit CA, generic CA, JNA), and if you want JavaHL we're up to 8 or more (many clicks). This just bloats the site and makes it arguably HARDER to install SVN support. --- Alternatively, we could remove SVN from the JBT Central (as it's already on Eclipse Marketplace, right?) and add the JBDS SVN feature to the JBDS version of central, once we have that alternate directory.xml file somewhere. We could then simply add all the JBDS all-in-one wrapper features I've already created and tested [1] into that version of Central to ensure a simpler experience for users. [1] https://svn.jboss.org/repos/devstudio/trunk/extras/features/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Snjezana Peco reassigned JBDS-1957: ----------------------------------- Assignee: Nick Boldt (was: Snjezana Peco) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt resolved JBDS-1957. ------------------------------ Resolution: Done Added SVNKit client adapter to Central (which brings in jna, svnkit, and generic client adapter). Tested from install. Able to fetch a project from SVN and commit a change. Committed to trunk/M5 branch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt edited comment on JBDS-1957 at 12/11/11 1:26 PM: ------------------------------------------------------------ Added SVNKit client adapter to Central (which brings in jna, svnkit, and generic client adapter). Tested from install. Able to fetch a project from SVN and commit a change. Committed to trunk/M5 branch. Respinning... https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.compo... DONE https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.aggre... https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_stable_branch.update... https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_stable_branch.produc... was (Author: nickboldt): Added SVNKit client adapter to Central (which brings in jna, svnkit, and generic client adapter). Tested from install. Able to fetch a project from SVN and commit a change. Committed to trunk/M5 branch. Respinning... https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.compo... https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.aggre... https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_stable_branch.update... https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_stable_branch.produc... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen reopened JBDS-1957: --------------------------------------- Assignee: Snjezana Peco (was: Nick Boldt) snjezana - can you do the merge of these two separate connectors and make them installable in one so we got a working example on how to handle this for others ? (I assume there aren't any problems in installing these two features together by default? users not wanting it could custom install it) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt updated JBDS-1957: ----------------------------- Attachment: JBDS1957.patch.txt simplified version of Snjeza's patch, only adds required IUs and tweaks descriptive text a bit -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen commented on JBDS-1957: ------------------------------------------- com.sun.jna is optional as long as not using native svn libraries. org.tigris.subversion.clientadapter is the shared API - not following how that is not needed. How can we *not* need org.tmatesoft.svnkit ? Isn't that the actual svn implementation in java? Thus required for it to work ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt resolved JBDS-1957. ------------------------------ Resolution: Done Updated patches applied. @Max or @Snjeza: please verify installation works as you'd expect and SVN is therefore useful as you'd like thereafter. If it works as you'd like, pls close this issue so QE won't need to worry about it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Nick Boldt edited comment on JBDS-1957 at 12/12/11 5:17 PM: ------------------------------------------------------------ Max: the required stuff gets pulled in by default -- maybe not the features but DEFINITELY the plugins. svnkit CA depends on generic CA, svnkit depends on jna. So we can clutter the UI by providing more options to install, or just tell users they need 2 things: subclipse and svnkit (and let the rest magically appear on disk w/o telling them). Oh, and the reason for choosing svnkit as the default is that it's pure java and therefore not platform-specific, like JavaHL. Easier to install, too. was (Author: nickboldt): Max: the required stuff gets pulled in by default -- maybe not the features but DEFINITELY the plugins. svnkit CA depends on generic CA, svnkit depends on jna. So we can clutter the UI by providing more options to install, or just tell users they need 2 things: subclipse and svnkit (and let the rest magically appear on disk w/o telling them). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1957?page=com.atlassian.jira.plugin.... ] Radim Hopp closed JBDS-1957. ---------------------------- Verified on JBDS 5.0.0-H55-M5. Closing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira