8:41 a.m.
Fred Bricon created JBIDE-12314:
-----------------------------------
Summary: Extract file identification API for the Maven Source Lookup Plugin
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 3.4.0.M1
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon reassigned JBIDE-12314:
-----------------------------------
Assignee: Snjezana Peco (was: Fred Bricon)
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Snjezana Peco
Fix For: 3.4.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon updated JBIDE-12314:
--------------------------------
Attachment: extract_file_identification.patch
Attaching possible implementation patch. [~snjeza], can you please review?
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 3.4.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Snjezana Peco commented on JBIDE-12314:
---------------------------------------
As I can see there is a minor issue in the FileIdentificationManager class.
{code}
@Override
public ArtifactKey identify(File file) throws CoreException {
ArtifactKey artifactKey = null;
for (ArtifactIdentifier identifier : artifactIdentifiers) {
artifactKey = identifier.identify(file);
if (artifactKey != null) {
- break;
+ return artifactKey;
}
}
return null;
}
{code}
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Snjezana Peco
Fix For: 3.4.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon commented on JBIDE-12314:
-------------------------------------
yes I did fix it locally after attaching the patch.
AFAICT the source lookup feature still works as expected after the refactoring. I was able
to debug Jboss AS7 and Tomcat
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Snjezana Peco
Fix For: 3.4.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:39 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon commented on JBIDE-12314:
-------------------------------------
After discussion with [~maxandersen] and [~snjeza], I'm gonna apply the patch on the
source lookup feature for now.
After my return from vacations, I will apply a 2nd refactoring in order to move all the
identification and remote repository management parts to the maven core/ui plugins.
That means the source lookup feature will then have a dependency on the maven core
feature.
Finally, the jar -> dependency conversion plugin will also be part of the maven core
feature (as a separate plugin though)
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Snjezana Peco
Fix For: 3.4.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon reassigned JBIDE-12314:
-----------------------------------
Assignee: Fred Bricon (was: Snjezana Peco)
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 4.0.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:45 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Fred Bricon resolved JBIDE-12314.
---------------------------------
Resolution: Done
Fixed in trunk.
Identification API is back to Maven Core
Remote Repository mgmt is back to Maven Core (+ UI)
Source Lookup Core + UI depend on Maven Core
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 4.0.0.M1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 a.m.
[
https://issues.jboss.org/browse/JBIDE-12314?page=com.atlassian.jira.plugi...
]
Vlado Pakan closed JBIDE-12314.
-------------------------------
Tests are passing on Jenkins
Extract file identification API for the Maven Source Lookup Plugin
------------------------------------------------------------------
Key: JBIDE-12314
URL: https://issues.jboss.org/browse/JBIDE-12314
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: maven
Affects Versions: 3.3.0.Final
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 4.0.0.Alpha1
Attachments: extract_file_identification.patch
In order to implement JBIDE-8973, we should be able to reuse the file identification
algorithms from the Source Lookup plugin.
This means the identification part from Source Lookup needs to be extracted into an API.
Possibly into a separate feature? moved back to the Maven core plugin?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4792
days inactive
4934
days old
jbosstools-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Fred Bricon (JIRA) -
Snjezana Peco (JIRA)
-
Vlado Pakan (JIRA)