8:33 a.m.
Max Rydahl Andersen created JBIDE-11487:
-------------------------------------------
Summary: cleanup and align openshift settings exposed to users
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in
application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should be
stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:40 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-11487:
---------------------------------------------
Key of on remote name so you can have different git repo destinations.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:44 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBIDE-11487:
----------------------------------------
Priority: Critical (was: Major)
bump to critical to get user visible settings stable.
storing in .settings for the "magic" project should be fine - .git might be
higher up but that will be found by egit automatically.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:48 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-11487:
---------------------------------------------
Changes needed:
* import operations store these .settings
* openshift server wizard make these .settings if not available.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Rob Stryker resolved JBIDE-11487.
---------------------------------
Resolution: Done
Settings are now aligned.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:46 p.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-11487:
-------------------------------------
I can no longer edit the deployments folder.
As per your comment, deployments folder has been moved into the project. Your comment
leading to this behaviour was "so the only thing the server needs to keep track of is
deployProject". At this point, editing has not been enabled via the editor, since
getting the editor to make workspace changes will take a bit of work.
The remote does not seem to be used as the key to allow for multiple
ones as discussed previously.
I'm not sure exactly what you're asking here, however, as per the same comment,
the 'remote' was moved into the project. Again, what was requested was: "so
the only thing the server needs to keep track of is deployProject"
If you'd like to keep this opened and have me change this behavior, and move both
deployFolder and remote back into the server, I can do that.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:54 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-11487:
---------------------------------------------
Rob:
As we discussed during triage and as was commented by your suggestion:
"Key of on remote name so you can have different git repo destinations"
Thats what we agreed on thus I was surprised you changed that.
And as discussed just because the settings are on the project does not mean the server
editor can't change those settings, especially when no other way to edit them.
And still I cannot change the project for the server so it is just as rigid as before.
Thus I suggest as a minimum make the magic project editable so you can setup and configure
the server.
And it was your suggestion to key of the remote so you did not limit it to one remote thus
you would need to have both project and remote name on the server to know what to look
up.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:02 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-11487:
---------------------------------------------
btw. in B1/B2 we made the deployments folder editable to allow it to work on other project
types beyond default AS7 types.
Similar the project type is no longer limited to WTP etc. so its really a step backwards.
Can't we just use the same UI and update the project settings with it ?
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:31 p.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-11487:
-------------------------------------
Can't we just use the same UI and update the project settings
with it ?
I had considered this when I was making the change, but, no, we can't. The reason is
because if you have two servers targeting the same project, imagine the following:
1) Create server 1 targeting project
2) Create server 2 targeting same project
3) Open editor 1, note deployment folder is "deployments"
4) Open editor 2, note the same
5) close editor 2
6) in editor 1, change deployments folder to "temp"
7) open editor 2, note that the deployments folder is now temp
Having the server editor modify the project settings will become very confusing for users
trying to set up servers with different values. This is why anything editable by the
server should be stored in the server, and vice versa. So allowing the server to change
magic project is fine, because the server stores the magic project in the server settings.
But allowing the user to change something which is stored in the project by using the
editor will lead to inconsistancies and confusion.
The only possible solutions here are to have project settings which can be overridden by
the server, but not actually modify the project file. The better solution of course is to
make sure that settings that should be controlled by the server are stored in the server,
while settings that are project-centric are stored on the project.
It seems what we're requesting is to push the "remote" back into the server,
and make it editable. The magic project is to be editable... and it seems we're not
100% in agreement what to do about the deployment folder.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-11487:
--------------------------------
Attachment: JBIDE-11487.v9.patch
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
Attachments: JBIDE-11487.v9.patch
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:56 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen resolved JBIDE-11487.
-----------------------------------------
Resolution: Done
applied the patch after fixed 2 bugs (via rawblem) regarding appname=username and combobox
content.
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
Attachments: JBIDE-11487.v9.patch
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:18 a.m.
[
https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugi...
]
Stefan Bunciak closed JBIDE-11487.
----------------------------------
Server settings contains only deployProject property. Other are kept in the
project(application) settings.
Verified in JBoss Developer Studio
Version: 5.0.0.Beta3
Build id: v20120430-1703-H125-Beta3
Build date: 20120430-1703
cleanup and align openshift settings exposed to users
-----------------------------------------------------
Key: JBIDE-11487
URL: https://issues.jboss.org/browse/JBIDE-11487
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Reporter: Max Rydahl Andersen
Assignee: Rob Stryker
Priority: Critical
Fix For: 3.3.0.Beta3
Attachments: JBIDE-11487.v9.patch
From JBIDE-10527 I see that the following keys are stored in application servers:
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69"
org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9"
org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere"
org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource"
org.jboss.tools.openshift.express.internal.core.behaviour.Username="username(a)example.com"
org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
Two problems here:
1) the use of internal package names as base of the key - why is this not just
openshift.<key> used as user visible setting ? Only if its something truly jboss
tools specific could I see a reason to use a packagename, but still then not use internal
since this key by the fact being stored in users settings are public and non-internal.
2) I think the project it self should be where applicationid, domain and usernme should
be stored so the only thing the server needs to keep track of is deployProject and
expressmode (if that is at all relevant anymore?)
When creating servers you just then point to the project and get the info or select an
application + project and the settings gets stored back on the project.
That could be stored in .settings and be made available for tooling outside AS server
integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5081
days inactive
5110
days old
jbosstools-issues@lists.jboss.org
11 comments
3 participants
participants (3)
-
Max Rydahl Andersen (JIRA) -
Rob Stryker (JIRA)
-
Stefan Bunciak (JIRA)