[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-9932: ------------------------------------------ 1) Adding the new visual node to visualContainer is performed in VpeVisualDomBuilder.addNode(..) method. Only after this node is added VpeDomMapping should be registered with this brandNewNode. 2) Some important information for creating VpeDomMapping could be obtained only inside VpeVisualDomBuilder.createNode(..) method. 3) Based on the notes above -- the solution is to return VpeDomMapping from VpeVisualDomBuilder.createNode(..) method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9932: ------------------------------------- Attachment: JBIDE-9932-Draft1.patch Draft version of the patch is attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9932: ------------------------------------- Attachment: JBIDE-9932-Draft2-wTests.patch 2nd patch is attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-9932 at 12/2/11 3:11 AM: ------------------------------------------------------------------- 1 failure is connected with the "render" attribute. See JBIDE-4179. Now EL didn't evaluate #{false} to false. 12 failures -- due to VpeNodeMappings creation not in a good time. Thus for instance for rendering <f:facet> to its parent -- visual node for the parent hasn't been registered in the mapping yet. Because "registerNodes(elementMapping);" was moved to "addNode(..)" method. was (Author: dmaliarevich): 1 failure is connected with the "render" attribute. See JBIDE-4179. Now EL didn't evaluate #{false} to false. 12 failures -- due to VpeNodeMappings creation not in a good time. Thus for instance for rendering f:facet to the its parent -- visual node for the parent hasn't been registered yet. Because "registerNodes(elementMapping);" was moved to "addNode(..)" method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-9932 at 12/2/11 3:20 AM: ------------------------------------------------------------------- I've noticed one more thing: in VpeDomMapping the mapping procedure itsels puts 1) source node with its mapping to one HashMap 2) visual node with its mapping to another HashMap. Though putting the same *source* node in the map will override the old value, the visual node won't be equal to the oldest one, and will not be overridden. Thus "registerNodes(elementMapping);" is preferred to call only once for each node. As a solution I'm thinkig that: registerNodes(..) should be called in "createNode(..)" method and then visual node should be updated to the new one which has been registered in the DOM(in "addNode(..)" method). Will try it. was (Author: dmaliarevich): I've noticed one more thing: in VpeDomMapping the mapping procedure itsels puts 1) source node with its mapping to one HashMap 2) visual node with its mapping to another HashMap. Though putting the same *source* node in the map will override the old value, the visual node won't be equal to the oldest one, and will not override. Thus "registerNodes(elementMapping);" is preferred to call only once for each node. As a solution I'm thinkig that: registerNodes(..) should be called in "createNode(..)" method and then visual node should be updated to the new one which has been registered in the DOM(in "addNode(..)" method). Will try it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9932: ------------------------------------- Attachment: JBIDE-9932-Draft3.patch Updated patch "Draft3" was attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich edited comment on JBIDE-9932 at 12/2/11 4:59 AM: ------------------------------------------------------------------- registerNodes(..) was left where it was in createNode(..). In "addNode(..)" method visual node get remapped in VpeDomMapping. It fixed all the previous failures, but now there are others. :( was (Author: dmaliarevich): registerNodes(..) was left where it was in createNode(..). In "addNode(..)" method visual node get remapped in VpeDomMapping. It fixed all previous failures, but now there others. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich updated JBIDE-9932: ------------------------------------- Attachment: JBIDE-9932-Final.patch Final patch was attached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich resolved JBIDE-9932. -------------------------------------- Fix Version/s: 3.3.0.M5 (was: 3.3.0.Beta1) Resolution: Done Resolved for M5. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-9932: ------------------------------------------ Now the code is the following: {code} public VpeNodeMapping getNodeMappingAtVisualNode(nsIDOMNode visualNode) { VpeNodeMapping nodeMapping = null; /* * https://issues.jboss.org/browse/JBIDE-9932 * Replaced with map. */ if (visualNode != null) { nodeMapping = visualMap.get(visualNode); } return nodeMapping; } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira