[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Victor Rubezhny updated JBIDE-9846: ----------------------------------- Attachment: XHTMLSyntaxValidationInfinite.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Alexey Kazakov commented on JBIDE-9846: --------------------------------------- The reason of this issue was our SAXParser which set feature http://apache.org/xml/features/continue-after-fatal-error to true. In this case XersesParser doesn't stop parsing the xml when a fatal error is caught and it causes an infinite loop. The issue is fixed. Victor, please add a test case for this issue and resolve it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9846: ---------------------------------------- This is the point to have http://apache.org/xml/features/continue-after-fatal-error feature is set to "true", because otherwise we cannot collect and control all the syntax errors against the page. If you disable this feature XHTML Syntax Validation error messages will not be actual and valid. Most of SAX Parse errors are fatal errors, so, because of this fact, the parser has never parses all the page text, but finishes its execution if faces the vary first problem. We need to read (and parse) all the page content due to see (and correctly represent) all the errors within the page. So, I would like to have this feature to be set to true, or don't use SAX Parser at all for validation purposes. The previous version of XHTML Syntax Validator used two-pass validation. First pass of parsing was used to detect if the page is to be validated (is it XHTML page?) and the second pass did the validation itself. We can filter out non-well-formed pages and, if so, we can skip the real validation against such pages, but indicate (by error marker) that the page is not well-formed instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Victor Rubezhny edited comment on JBIDE-9846 at 10/6/11 10:00 AM: ------------------------------------------------------------------ This is the point to have http://apache.org/xml/features/continue-after-fatal-error feature is set to "true", because otherwise we cannot collect and control all the syntax errors against the page. If you disable this feature XHTML Syntax Validation error messages will not be actual and valid. Most of SAX Parse errors are fatal errors, so, because of this fact, the parser has never parses all the page content, but finishes its execution when it meets the very first problem. We need to read (and parse) all the page content due to see (and correctly represent) all the errors within the page. So, I would like to have this feature to be set to true, or don't use SAX Parser at all for validation purposes. The previous version of XHTML Syntax Validator used two-pass validation. First pass of parsing was used to detect if the page is to be validated (is it XHTML page?) and the second pass did the validation itself. We can filter out non-well-formed pages and, if so, we can skip the real validation against such pages, but indicate (by error marker) that the page is not well-formed instead. was (Author: vrubezhny): This is the point to have http://apache.org/xml/features/continue-after-fatal-error feature is set to "true", because otherwise we cannot collect and control all the syntax errors against the page. If you disable this feature XHTML Syntax Validation error messages will not be actual and valid. Most of SAX Parse errors are fatal errors, so, because of this fact, the parser has never parses all the page text, but finishes its execution if faces the vary first problem. We need to read (and parse) all the page content due to see (and correctly represent) all the errors within the page. So, I would like to have this feature to be set to true, or don't use SAX Parser at all for validation purposes. The previous version of XHTML Syntax Validator used two-pass validation. First pass of parsing was used to detect if the page is to be validated (is it XHTML page?) and the second pass did the validation itself. We can filter out non-well-formed pages and, if so, we can skip the real validation against such pages, but indicate (by error marker) that the page is not well-formed instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Victor Rubezhny commented on JBIDE-9846: ---------------------------------------- JUnit test org.jboss.tools.jsf.test.validation.XHTMLValidatorTest is updated due to test the issue -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9846?page=com.atlassian.jira.plugin... ] Vlado Pakan closed JBIDE-9846. ------------------------------ Verified on jbosstools-3.3_stable_branch.aggregate-Update-2011-10-27_16-13-53-H37. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira