[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6085: ---------------------------------------------- Framework for adding validation rules is ready. The only challenge is to compile a list of useful and non-annoying rules. Could I ask ESB developers to help me with that list and suggest what should be validated in the first place? With the set of rules to go, we can decide what can be implemented for 3.2, and what moved for a later version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-6085: ------------------------------------------ Slava, do you have an example of what a "rule" looks like in this context for a different config file so we have some understanding of what specifically you're looking for? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-6085: ------------------------------------------ That's a great example... Couple of questions... 1) Will these validation errors appear in the Problems and Markers views? 2) Will these validation errors prevent a user from deploying a service? (I'm guessing not since deployment is in a separate project, but wanted to ask.) 3) How do these rules get executed? You mention that there's already some "standard validation" - how do the two validators work together without causing issues? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich updated JBIDE-6085: ----------------------------------------- Attachment: ESBValidatorPreferences .png ESBValidation_Marker.png -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-6085: ------------------------------------------ Slava, I still have this on my list to look at, but haven't had a chance to get back to it. My apologies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6085: ---------------------------------------------- Yes, exactly. And I would divide this examples into 2 groups. A) Schema-like rules. If BusinessRulesProcessor were discribed by xsd schema instead of usage of common tags <action> and <property>, rules (1), (3), (4), (6) and (7) would be set as restrictions in schema and validated by wst validator. Model of ESB editor can readily take that validation to itself by setting restrictions in metadata. I have not enforced them before, because I was not sure that they are quite strict. B) Rules that describe interaction of several properties - (2) and (5), that cannot be readily described in schema or metadata, they are only for specific ESBCoreValidator validator. I will implement the rules for BusinessRulesProcessor in 3.2.0.Beta, that will be as example for further work. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-6085: ------------------------------------------ David Ward brought up an omission on my part - The parameter that I missed for the BusinessRulesProcessor is "object-paths" http://docs.jboss.org/jbossesb/docs/4.9/manuals/html/Services_Guide/index... So the docs look like this: Object Paths... location.objectname.[beanname].[beanname]... * location : one of {body, header, properties, attachment} * objectname: name of the object name, attachments can be named or numbered, so for attachments this can be a number too. * beannames: optionally you traverse a bean graph by specifying bean names So this is for the optional "object-paths" property... And some rules might be: If "object-paths" is specified, parse the value ("location.objectname.[beanname].[beanname]...") and it should have these parts: For "location" it must be "body", "header", "properties", or "attachment" For "objectname" it should refer to an object defined in the rules file? For "beannames" it should refer to a bean name in the rules file? I think this goes a bit beyond what we were looking at for validation of the configuration, but is still an interesting use case. The validator would need to be able to poke at the various rules files referred to in the configuration and pull out valid object and bean names to validate against. Slava, is it possible to do this type of validation with the framework you have in place? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6085: ---------------------------------------------- Yes, it is possible, and for now I have implemented validation of the location part (See jboss-esb-brp-ObjectPath.png). How can we better look for object names and bean names in rules files? Should we implement a parser for each rule language, or can we reuse some utilities already implemented for other components (esb, drools,...) ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin... ] Viacheslav Kabanovich updated JBIDE-6085: ----------------------------------------- Fix Version/s: 3.4.x (was: 3.3.0.Beta1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6085?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-6085: ---------------------------------- Fix Version/s: 4.1.x (was: 4.0.x) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira