[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3321: -------------------------------------- This is a branding problem that isn't related to install/update. The branding problem can be fixed by defining the branding plugin for the org.jboss.tools.ws.feature feature and adding branding artifacts to this plugin. The portlet feature can serve as an example. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3321: --------------------------------------- Fix Version/s: 3.0.0.cr1 3.0.0.GA Priority: Critical (was: Major) should at least be investigated for CR1 and definitly fixed before GA. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Sean Flanigan commented on JBIDE-3321: -------------------------------------- Oh, I didn't understand Snjezana at first, but I realise now that the only features which show up in About Features (or Configuration Details) are those which have branding plugins, so naturally adding branding will make them show up and fix problem #5. Has it always been this way, or did this change in Eclipse 3.4? This new knowledge does suggest another cleanup item: 6. If I install "JBoss Tools RichFaces" through the Update Manager, it's counter-intuitive for About Features to show it as "Visual Page Editor". (The first name comes from the feature manifest (or feature.properties), the second comes from the branding plugin.) Shouldn't these names be similar, if not identical? There's another reason we would want branding plugins: I don't think it's possible to create "fragment features" to contain translations of the feature metadata (eg feature_es.properties), but if every feature has a branding plugin, we can translate those plugins like any others. You would have to install the relevant branding langpack fragment before you would see the translated feature names, and in any case, it looks as the update manager uses names from the features, not from the branding plugins. So users won't see localised feature names in the Update Manager when installing JBT features, or when updating JBDS features (assuming there is an update site for JBDS). The alternative is to put translated properties files into the actual feature: feature_es.properties, feature_fr.properties, feature_de.properties, etc. That way, when the feature is built it will contain the translated feature names, and it should be available anywhere it's needed, eg in the Update Manager. There are logistical problems with this (the L10n team having to deal with these properties files, for one, and making the main build dependent on L10n data), but it is one option. In summary, we can get localised feature names in About by using localised branding plugins. It should be possible to have localised feature names in the Update Manager, but only by including translations in features, not if they are kept separate. (As far as I can tell, no-one has come up with a solution for that. To solve it would probably require the update manager to understand locales and how to find the right feature langpack for a given feature.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Max Rydahl Andersen reassigned JBIDE-3321: ------------------------------------------ Assignee: Max Rydahl Andersen -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Snjezana Peco resolved JBIDE-3321. ---------------------------------- Fix Version/s: (was: 3.0.0.GA) Resolution: Done I didn't brand the drools and jbpm feature. Not sure if the license and icon for the JMX Console and XULRunner feature are correct, since these features contain Mozilla and Jeff's code. I have added the JBoss icon and EPL license. This fix also solves JBIDE-3241. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3321: -------------------------------------- The latest revision of the org.jboss.tools.seam.feature/feature.xml file in the trunk is 12339. The required features don't contain the version argument and look like the following: ... <requires> <import feature="org.jboss.tools.richfaces.feature"/> <import feature="org.jboss.ide.eclipse.as.feature"/> <import feature="org.hibernate.eclipse.feature"/> <import feature="org.eclipse.datatools.connectivity.feature"/> <import feature="org.eclipse.datatools.enablement.jdbc.feature"/> </requires> ... Have you checked out the latest changes? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Sean Flanigan reopened JBIDE-3321: ---------------------------------- #4 is still giving warnings on the seam feature. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Sean Flanigan commented on JBIDE-3321: -------------------------------------- With the possible exception of a branding plugin for JBDS (mentioned by Snjezana), I think everything from my original cleanup request has been addressed, and apparently also the late addition #6 (conflicting feature names). Thanks! (I would close the bug, but that should probably wait until a decision about the JBDS branding plugin is made.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3321: -------------------------------------- I would like to resolve this jira, but didn't get any answer to the question: " Do we need to brand the com.jboss.jbds.product.feature feature? " -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3321?page=com.atlassian.jira.plu... ] Snjezana Peco resolved JBIDE-3321. ---------------------------------- Resolution: Done Committed to the trunk and CR1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira