]
Max Rydahl Andersen updated JBIDE-16021:
----------------------------------------
Fix Version/s: 4.2.0.Beta1
(was: 4.2.0.Alpha2)
Revisit whether file transfer requests can trust rse's
isConnected
-------------------------------------------------------------------
Key: JBIDE-16021
URL:
https://issues.jboss.org/browse/JBIDE-16021
Project: Tools (JBoss Tools)
Issue Type: Task
Components: server, upstream
Affects Versions: 4.2.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.2.0.Beta1
With the large speed increases in jbt's RSE integration, the new bottleneck is during
the beginning of the publish event.
A block of code currently exists as follows:
{code}
boolean isConnected = fileSubSystem != null && fileSubSystem.isConnected();
String connectionName = RSEUtils.getRSEConnectionName(behaviour.getServer());
if( isConnected ) {
// The RSE tools might be mistaken here. The user may in fact have lost internet
connectivity
NamedRunnableWithProgress run = new NamedRunnableWithProgress("Accessing Remote
System Root") {
public Object run(IProgressMonitor monitor) throws CoreException,
SystemMessageException, RuntimeException {
getFileService().getRoots(monitor);
return Status.OK_STATUS;
}
};
IProgressMonitor childMonitor = AbstractServerToolsPublisher.getSubMon(monitor, 100);
Exception e = RSERemotePublishHandler.wrapRemoteCallStatusTimeLimit(run,
"null", "null", null, 15000, childMonitor);
{code}
It would seem strange for the rse's isConnected() method to be incorrect. Investigate
whether it is still possible it is incorrect, and file an appropriate upstream bug, or, if
no bug, simply remove the lines and improve speed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: