[ https://jira.jboss.org/browse/JBIDE-7503?page=com.atlassian.jira.plugin.s... ] Andre Dietisheim commented on JBIDE-7503: ----------------------------------------- notification is back in place, the instance view gets updated. There's a problem with the properties view though. It gets blank when you start/stop/reboot/destroy instances -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7503?page=com.atlassian.jira.plugin.s... ] Andre Dietisheim commented on JBIDE-7503: ----------------------------------------- the properties view gets blank because the cloud view looses its selection. The reason for this is that the child items in the treeviewer are replaced by new ones and there's no chance for the viewer to know which new instance corresponds to the formerly selected one: 1) if you start/stop/reboot/destroy an instance, DeltaCloud#performInstanceAction is executed 2) DeltaCloud#pperformInstanceAction: notifies of a change in an instance (it was stopped, started, etc.) The current design relies on notifying the whole list of instances (not only the changed one!) 3.) CVInstanceCategory#listChanged: gets notified of the change in the list of the change in the list of instances. It then clears the whole list of child instances and re-adds the instances that it got notified of and refreshes the TreeViewer (see the calls to clearChildren() and addInstances()): public void listChanged(DeltaCloud cloud, DeltaCloudInstance[] newInstances) { clearChildren(); DeltaCloudInstance[] instances = filter(newInstances); addInstances(instances); initialized = true; Display.getDefault().asyncExec(new Runnable() { @Override public void run() { ((TreeViewer)viewer).refresh(category, false); } }); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7503?page=com.atlassian.jira.plugin.s... ] Andre Dietisheim edited comment on JBIDE-7503 at 11/5/10 11:18 AM: ------------------------------------------------------------------- the properties view gets blank because the cloud view looses its selection. The reason for this is that the child items in the treeviewer are replaced by new ones and there's no chance for the viewer to know which new instance corresponds to the formerly selected one: 1) if you start/stop/reboot/destroy an instance, DeltaCloud#performInstanceAction is executed 2) DeltaCloud#pperformInstanceAction: notifies of a change in an instance (it was stopped, started, etc.) The current design relies on notifying the whole list of instances (not only the changed one!) 3.) CVInstanceCategory#listChanged: gets notified of the change in the list of the change in the list of instances. It then clears the whole list of child instances and re-adds the instances that it got notified of and refreshes the TreeViewer (see the calls to clearChildren() and addInstances()): public void listChanged(DeltaCloud cloud, DeltaCloudInstance[] newInstances) { clearChildren(); DeltaCloudInstance[] instances = filter(newInstances); addInstances(instances); initialized = true; Display.getDefault().asyncExec(new Runnable() { @Override public void run() { ((TreeViewer)viewer).refresh(category, false); } }); } was (Author: adietish): the properties view gets blank because the cloud view looses its selection. The reason for this is that the child items in the treeviewer are replaced by new ones and there's no chance for the viewer to know which new instance corresponds to the formerly selected one: 1) if you start/stop/reboot/destroy an instance, DeltaCloud#performInstanceAction is executed 2) DeltaCloud#pperformInstanceAction: notifies of a change in an instance (it was stopped, started, etc.) The current design relies on notifying the whole list of instances (not only the changed one!) 3.) CVInstanceCategory#listChanged: gets notified of the change in the list of the change in the list of instances. It then clears the whole list of child instances and re-adds the instances that it got notified of and refreshes the TreeViewer (see the calls to clearChildren() and addInstances()): public void listChanged(DeltaCloud cloud, DeltaCloudInstance[] newInstances) { clearChildren(); DeltaCloudInstance[] instances = filter(newInstances); addInstances(instances); initialized = true; Display.getDefault().asyncExec(new Runnable() { @Override public void run() { ((TreeViewer)viewer).refresh(category, false); } }); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7503?page=com.atlassian.jira.plugin.s... ] Andre Dietisheim edited comment on JBIDE-7503 at 11/5/10 5:04 PM: ------------------------------------------------------------------ the properties view gets blank because the cloud view looses its selection. The reason for this is that the child items in the treeviewer are replaced by new ones and there's no chance for the viewer to know which new instance corresponds to the formerly selected one: 1) if you start/stop/reboot/destroy an instance, DeltaCloud#performInstanceAction is executed 2) DeltaCloud#pperformInstanceAction: notifies of a change in an instance (it was stopped, started, etc.) The current design relies on notifying the whole list of instances (not only the changed one!) 3.) CVInstanceCategory#listChanged: gets notified of the change in the list. It then removes all child instances, adds new instances and refreshes the TreeViewer (see the calls to clearChildren() and addInstances()): public void listChanged(DeltaCloud cloud, DeltaCloudInstance[] newInstances) { clearChildren(); DeltaCloudInstance[] instances = filter(newInstances); addInstances(instances); initialized = true; Display.getDefault().asyncExec(new Runnable() { @Override public void run() { ((TreeViewer)viewer).refresh(category, false); } }); } was (Author: adietish): the properties view gets blank because the cloud view looses its selection. The reason for this is that the child items in the treeviewer are replaced by new ones and there's no chance for the viewer to know which new instance corresponds to the formerly selected one: 1) if you start/stop/reboot/destroy an instance, DeltaCloud#performInstanceAction is executed 2) DeltaCloud#pperformInstanceAction: notifies of a change in an instance (it was stopped, started, etc.) The current design relies on notifying the whole list of instances (not only the changed one!) 3.) CVInstanceCategory#listChanged: gets notified of the change in the list of the change in the list of instances. It then clears the whole list of child instances and re-adds the instances that it got notified of and refreshes the TreeViewer (see the calls to clearChildren() and addInstances()): public void listChanged(DeltaCloud cloud, DeltaCloudInstance[] newInstances) { clearChildren(); DeltaCloudInstance[] instances = filter(newInstances); addInstances(instances); initialized = true; Display.getDefault().asyncExec(new Runnable() { @Override public void run() { ((TreeViewer)viewer).refresh(category, false); } }); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira