[
https://issues.jboss.org/browse/JBIDE-19181?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-19181:
-------------------------------------
Description:
Internal packages across the openshift plugins are non-consistent:
ex.
org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
org.jboss.tools.openshift.express.client:
org.jboss.tools.openshift.express.client.internal
the base is imho org.jboss.tools.openshift and thus internal packages should always be at
org.jboss.tools.openshift.internal across plugins.
For reference, here's the official Eclipse documentation on the topic:
http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
{quote}
org.eclipse.jdt.internal.core.compiler - Correct usage
org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow
subproject name.
org.eclipse.core.internal.resources - Correct usage
org.eclipse.internal.core.resources - Incorrect. internal should never immediately
follow org.eclipse.
org.eclipse.core.resources.internal - Incorrect. internal should immediately follow
Eclipse Platform component name.
{quote}
was:
Internal packages across the openshift plugins are non-consistent:
ex.
org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
org.jboss.tools.openshift.express.client:
org.jboss.tools.openshift.express.client.internal
the base is imho org.jboss.tools.openshift and thus internal packages should always be at
org.jboss.tools.openshift.internal across plugins.
For reference, here's the official Eclipse:
http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
{quote}
org.eclipse.jdt.internal.core.compiler - Correct usage
org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow
subproject name.
org.eclipse.core.internal.resources - Correct usage
org.eclipse.internal.core.resources - Incorrect. internal should never immediately
follow org.eclipse.
org.eclipse.core.resources.internal - Incorrect. internal should immediately follow
Eclipse Platform component name.
{quote}
correct naming of internal packages so that they're consistent
across all openshift plugins
-------------------------------------------------------------------------------------------
Key: JBIDE-19181
URL:
https://issues.jboss.org/browse/JBIDE-19181
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 4.3.0.Alpha1
Reporter: Andre Dietisheim
Fix For: 4.3.0.Alpha1
Internal packages across the openshift plugins are non-consistent:
ex.
org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
org.jboss.tools.openshift.express.client:
org.jboss.tools.openshift.express.client.internal
the base is imho org.jboss.tools.openshift and thus internal packages should always be at
org.jboss.tools.openshift.internal across plugins.
For reference, here's the official Eclipse documentation on the topic:
http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
{quote}
org.eclipse.jdt.internal.core.compiler - Correct usage
org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow
subproject name.
org.eclipse.core.internal.resources - Correct usage
org.eclipse.internal.core.resources - Incorrect. internal should never immediately
follow org.eclipse.
org.eclipse.core.resources.internal - Incorrect. internal should immediately follow
Eclipse Platform component name.
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)