[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-12338: ------------------------------------ See usecase here: https://issues.jboss.org/browse/JBIDE-12248?focusedCommentId=12706267&... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12338: --------------------------------------------- we can't *depend* on 2.0 since its not in Indigo afaik - we could make the version range allow both 1.2 and 2.0 assuming the API we use has not changed signature or behaviour. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12338: --------------------------------------------- updated title to reflect the proper/real question. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-12338 at 7/30/12 11:47 AM: -------------------------------------------------------------------- looking at things in detail I now see that there are API changes (remember: egit was bumped to a new major version) that make it pretty hard to keep our stuff compatible. The main changes are in the Exceptions being thrown. Inserting additional catch blocks for juno would not compile in indigo since the compiler would complain about unreachable catch blocks. The only solution I currently see is to add the new Exceptions to the method signatures and catch those in the user code. Ex. git init command additionnally throws a GitAPIException in JGit 2.0. The util method that calls it only throws a CoreException. To keep this signature I'd have to catch GitAPIException but this wont compile in Indigo since it's not thrown in jgit < 2.0 (unreachable catch block). I can solve this by adding the exception to the method signature and add another catch block to the user code. The alternative, to catch Exception (instead of the more specific GitAPIException) looks like a bad option to me. Any better suggestion? was (Author: adietish): looking at things in detail I now see that there are API changes (remember: egit was bumped to a new major version) that make it pretty hard to keep our stuff compatible. The main changes are in the Exceptions being thrown. Inserting additional catch blocks for juno would not compile in indigo since the compiler would complain about unreachable catch blocks. The only solution I currently see is to add the new Exceptions to the method signatures and catch those in the user code. Ex. git init command additionnally throws a GitAPIException in JGit 2.0. The util method that calls it only throws a CoreException. To keep this signature I'd have to catch GitAPIException but this wont compile in Indigo since it's not thrown in jgit < 2.0 (unreachable catch block). I can solve this by adding the exception to the method signature and add another catch block to the user code. Any better suggestion? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12338: ------------------------------------------ committed to BRANCH -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-12338. -------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-12338. -------------------------------------- Fix Version/s: 3.3.1 (was: 3.3.2) Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-12338: ------------------------------------ 1. Fire up clean Eclipse 4.2.0 JEE bundle (x64 linux). 2. Help > Install new > http://download.jboss.org/jbosstools/updates/stable/indigo/ 3. Select only "JBoss OpenShift Tools" 4. Install "JBoss OpenShift Tools 2.3.1.v20120715-0255-H145-Final (org.jboss.tools.openshift.express.feature) 5. After installation, egit 2.0, egit.core 1.3, egit.ui 1.3 and jgit 1.3 are installed in the eclipse/plugins/ folder: {code} $ find . -name "*openshift*" -o -name "*git*" | sort ./org.eclipse.egit_2.0.0.201206130900-r.jar ./org.eclipse.egit.core_1.3.0.201202151440-r.jar ./org.eclipse.egit.ui_1.3.0.201202151440-r.jar ./org.eclipse.jgit_1.3.0.201202151440-r.jar ./org.jboss.tools.openshift.egit.core_2.3.1.v20120715-0255-H145-Final.jar ./org.jboss.tools.openshift.egit.ui_2.3.1.v20120715-0255-H145-Final.jar ./org.jboss.tools.openshift.express.client_2.3.1.v20120715-0255-H145-Final.jar ./org.jboss.tools.openshift.express.ui_2.3.1.v20120715-0255-H145-Final.jar {code} So... I guess this already worked with JBoss Tools 3.3.1.Final release? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12338: ------------------------------------------ It definitely looks like... I double checked the installed openshift tooling. it definitely requires egit < 2.0. !openshift-231-requires-egit-lt-20.png! But obviously installing works in a vanilla eclipse. Afaik updating did not work, right? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12338?page=com.atlassian.jira.plugi... ] Nick Boldt closed JBIDE-12338. ------------------------------ Closing so that QE don't need to review this later. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira