[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Nick Boldt updated JBIDE-5375: ------------------------------ Component/s: Build/Releng Fix Version/s: 3.1.0.GA Affects Version/s: 3.1.0.CR1 Assignee: Nick Boldt -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Brian Fitzpatrick reassigned JBIDE-5375: ---------------------------------------- Assignee: Brian Fitzpatrick (was: Nick Boldt) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Brian Fitzpatrick reassigned JBIDE-5375: ---------------------------------------- Assignee: Nick Boldt (was: Brian Fitzpatrick) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-5375: ----------------------------------- The following comment seems strange. We can't be the contributors of the initial implementation if IBM did it first. # JBoss by Red Hat - Initial implementation. # IBM Corporation - initial API and implementation Some additional things to fix: 1. if you see something like this in build.properties, remove the line and verify there's no reference to the jar in the accompanying MANIFEST.MF. You might want "Bundle-Classpath: ." in the MANIFEST.MF, but according to Denis G, that's the default if not specified. jars.compile.order = bpel-ui.jar (or some other jar) Bundle-ClassPath: bpel-ui.jar (or some other jar) This is not *required* and doesn't affect licensing; but it's good hygiene to avoid nested jars unless there's a reason not to do so. 2. o.e.bpel.validator has two nested jars: code.jar and bpel-validator.jar. Does it need this? And do we really need to "remove source that is not to be compiled" using an xslt script? (Yes, I'm going off-topic here - this is related to https://jira.jboss.org/jira/browse/JBIDE-5317 3. wsil.model's manifest doesn't state "0.5.0.qualifier", but "0.5.0". There may be others too, that's just the first one I spotted. Otherwise, patch +1'd. Make it so. Fetch me that horizon. Tea: Earl Grey, Hot. :) 5. No features were harmed in the making of this patch. (I guess that's because we don't include the eclipse.bpel features, just the jboss.bpel ones which are already correctly branded/copyrighted/licensed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Denny Xu commented on JBIDE-5375: --------------------------------- I'm a little afraid of to break bpel build, so before to change the build.properties and MANIFEST.MF, I would make sure that I understand the #1 and #2 correctly ;) for #1, I should remove all something like "jars.compile.order = bpel-ui.jar (or some other jar) " from build.properties and "Bundle-ClassPath: bpel-ui.jar (or some other jar) " from MANIFEST.MF, right? for #2, there are two nested jars in bpel.validator , this is because of it was there when we get all bpel codes from Eclipse bpel svn, not sure why they did it like this. so I think we can remove it just like #1 mentioned to remove something like "jars.compile.order = bpel-ui.jar (or some other jar) ", right? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu... ] Nick Boldt resolved JBIDE-5375. ------------------------------- Resolution: Done #1 has already been done (Dec 8)... it's a combination of personal preference, better performance (nested jars = slower and more disk footprint), and simpler build config. #2 is fixed too, having switched away from nested jars (Jan 28). The old nested method was from the PDE 3.2 days, and while it still works most of the time, it's no longer recommended as problems can arise like the one reported in https://jira.jboss.org/jira/browse/JBIDE-5317 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira