[
https://jira.jboss.org/jira/browse/JBIDE-5375?page=com.atlassian.jira.plu...
]
Nick Boldt commented on JBIDE-5375:
-----------------------------------
The following comment seems strange. We can't be the contributors of the initial
implementation if IBM did it first.
# JBoss by Red Hat - Initial implementation.
# IBM Corporation - initial API and implementation
Some additional things to fix:
1. if you see something like this in build.properties, remove the line and verify
there's no reference to the jar in the accompanying MANIFEST.MF.
You might want "Bundle-Classpath: ." in the MANIFEST.MF, but according to Denis
G, that's the default if not specified.
jars.compile.order = bpel-ui.jar (or some other jar)
Bundle-ClassPath: bpel-ui.jar (or some other jar)
This is not *required* and doesn't affect licensing; but it's good hygiene to
avoid nested jars unless there's a reason not to do so.
2. o.e.bpel.validator has two nested jars: code.jar and bpel-validator.jar. Does it need
this? And do we really need to "remove source that is not to be compiled" using
an xslt script? (Yes, I'm going off-topic here - this is related to
https://jira.jboss.org/jira/browse/JBIDE-5317
3. wsil.model's manifest doesn't state "0.5.0.qualifier", but
"0.5.0". There may be others too, that's just the first one I spotted.
Otherwise, patch +1'd. Make it so. Fetch me that horizon. Tea: Earl Grey, Hot. :)
5. No features were harmed in the making of this patch. (I guess that's because we
don't include the eclipse.bpel features, just the jboss.bpel ones which are already
correctly branded/copyrighted/licensed.
Fix the forking license files and provider name in the forked up BPEL
plugins
-----------------------------------------------------------------------------
Key: JBIDE-5375
URL:
https://jira.jboss.org/jira/browse/JBIDE-5375
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Build/Releng
Affects Versions: 3.1.0.CR1
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 3.1.0.GA
Attachments: clipboard.txt, mylyn-context.zip
TODO: Change "IBM and others" to "JBoss by Red Hat and others";
update date to 2009 in copyright statements in plugins/features (*.xml, *.MF, *.prop*,
about*, license*)
TODO: Change provider name from "eclipse.org" to "JBoss by Red Hat"
in plugin and feature manifests (manifest.mf, plugin.properties, feature.xml,
feature.properties)
TODO: Get Forked.
TODO: Verify in Help > About dialog; see also
https://jira.jboss.org/jira/browse/JBDS-974
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira