[JBoss JIRA] Created: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
2:57 p.m.
CDI builder should be declared before WST validation builder in .project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.3.0.M1, 3.2.0.Final
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.3.0.M2, 3.2.x
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:52 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-9021:
----------------------------------
Fix Version/s: 3.2.1.CR1
(was: 3.2.x)
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:38 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-9021:
----------------------------------
Attachment: jbt-trunk.patch
A patch for trunk.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:12 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-9021:
----------------------------------
Attachment: jbt-branch.patch
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:45 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen commented on JBIDE-9021:
--------------------------------------------
Alexey,
i've been looking at the patch today and on first look it looks doable to include it
but got a few questions:
The code in addNatureToProjectWithValidationSupport seems way more complicated than it has
to be. shouldn't this just be "find highest index of either Java or WST builder,
add builder after that highest index" ? and why do we need to WST builder etc. in
here; shouldn't that be done by the validator nature or facet ?
p.s. thanks for adding tests for this ;)
p.p.s. i'm awaiting for tycho to download the updated dependencies for 3.2.x to verify
the test run while writing this - once that is ok and hear back from you then we should be
ok.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Max Rydahl Andersen
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:31 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Alexey Kazakov commented on JBIDE-9021:
---------------------------------------
{quote}The code in addNatureToProjectWithValidationSupport seems way more complicated than
it has to be. shouldn't this just be "find highest index of either Java or WST
builder, add builder after that highest index" ?{quote}
To have our CDI/Seam builders/validators worked correctly we need Java, WST validator, Our
Builder in the following order:
Java,WST,CDI/Seam
But we may have any combination in .project when we are trying to add our builder:
1. Java, WST
2. Java
3. Java, CDI
3. WST, Java
4. Java, WST, CDI
5. WST, Java, CDI
6. CDI, Java, WST
...
So we have to check the indexes of all the builders, add missing builders/natures and
re-order existing ones if needed.
{quote}and why do we need to WST builder etc. in here; shouldn't that be done by the
validator nature or facet ?{quote}
Our validation based on WST validation framework. So WST builder runs all our validation.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:46 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen commented on JBIDE-9021:
--------------------------------------------
Gotcha - after discussion on irc i'm ok with this one since it fixes more than it can
possibly break ;)
JBIDE-9021 will be important to add for future user improvements.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Max Rydahl Andersen
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:15 p.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Alexey Kazakov resolved JBIDE-9021.
-----------------------------------
Resolution: Done
Applied to trunk and branch.
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:13 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-9021) CDI builder should be declared before WST validation builder in .project.
[
https://issues.jboss.org/browse/JBIDE-9021?page=com.atlassian.jira.plugin...
]
Lukas Jungmann closed JBIDE-9021.
---------------------------------
v. in cr1
CDI builder should be declared before WST validation builder in
.project.
-------------------------------------------------------------------------
Key: JBIDE-9021
URL: https://issues.jboss.org/browse/JBIDE-9021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdi (jsr-299)
Affects Versions: 3.2.0.Final, 3.3.0.M1
Reporter: Alexey Kazakov
Assignee: Alexey Kazakov
Priority: Critical
Fix For: 3.2.1.CR1, 3.3.0.M2
Attachments: jbt-branch.patch, jbt-trunk.patch
EXECUTE: Create any CDI project (don't enable CDI support!)
EXECUTE: If there is no in .project yet then add it there:
{code}
<buildCommand>
<name>org.eclipse.wst.validation.validationbuilder</name>
<arguments>
</arguments>
</buildCommand>
{code}
EXECUTE: Enable CDI support for the project.
EXECUTE: Open .project
FAILURE:
{code}
<buildCommand>
<name>org.jboss.tools.cdi.core.cdibuilder</name>
<arguments>
</arguments>
</buildCommand>
{code} is added to the end of <buildSpec> tag.
ASSERT: org.jboss.tools.cdi.core.cdibuilder should be declared after
org.eclipse.jdt.core.javabuilder but before org.eclipse.wst.validation.validationbuilder
This is very important since if we have CDI builder declared after WST validator builder
then CDI validation will be invoked before CDI builder completed building CDI model. It
causes incorrect work of CDI validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5413
days inactive
5428
days old
jbosstools-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Alexey Kazakov (JIRA) -
Lukas Jungmann (JIRA)
-
Max Rydahl Andersen (JIRA)