]
Mickael Istria commented on JBIDE-21657:
----------------------------------------
[~maxandersen] The user that's granted push permissions is ONLY used in the context of
the GitHub Pull Request Builder plugin AFAIK. If not we could create one just for that. It
means that even if the user has full push permission, only some Jenkins plugin that would
use this user credentials could do bad things. A regular piece of code running in the
build doesn't run as this GitHub user and wouldn't be able to do anything with the
repositories.
set up jobs to handle building from PRs
---------------------------------------
Key: JBIDE-21657
URL:
https://issues.jboss.org/browse/JBIDE-21657
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
Reporter: Nick Boldt
Assignee: Nick Boldt
Priority: Critical
Fix For: 4.4.0.Alpha3
First experimental build:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sit...
Output:
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
"revision" : {
"HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
"currentBranch" : "HEAD",
"knownReferences" : [{
"name" : "origin",
"url" :
"git://github.com/jbosstools/jbosstools-build-sites.git",
"ref" : "pr/221/merge"
}]
},
{code}
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
#Fri Feb 05 16:42:42 EST 2016
null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
build log:
{code}
Started by upstream project
"jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number
1
originally caused by:
GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge
conflicts.
...
Fetching upstream changes from
git://github.com/jbosstools/jbosstools-build-sites.git
> git -c core.askpass=true fetch --tags --progress
git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/*
+refs/pull/*:refs/remotes/origin/pr/*
Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805
(refs/remotes/origin/pr/221/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
vars:
{code}
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
-DghprbPullId=221
-Dsha1=origin/pr/221/merge
"-DghprbPullDescription=GitHub pull request #221 of commit
50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts."
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
{code}