From an architectural perspective I'd opt to move #performInstanceAction to an upper layer. IMHO a simple REST client should not keep states.

DeltaCloudClient: remove instance related actions ------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Reporter: Andre Dietisheim The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.

From an architectural perspective I'd opt to move #performInstanceAction to an upper layer. Not keeping state would keep the client far more simple

DeltaCloudClient: remove instance related actions ------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Reporter: Andre Dietisheim The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.

DeltaCloudClient: remove instance related actions ------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Reporter: Andre Dietisheim The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.

DeltaCloudClient: remove instance methods (#startInstance, #stopInstance, etc.) in order to remove code duplication ------------------------------------------------------------------------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Reporter: Andre Dietisheim Assignee: Andre Dietisheim The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.

DeltaCloudClient: remove instance methods (#startInstance, #stopInstance, etc.) in order to remove code duplication ------------------------------------------------------------------------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Reporter: Andre Dietisheim Assignee: Andre Dietisheim The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.

DeltaCloudClient: remove instance methods (#startInstance, #stopInstance, etc.) in order to remove code duplication ------------------------------------------------------------------------------------------------------------------- Key: JBIDE-7484 URL: https://jira.jboss.org/browse/JBIDE-7484 Project: Tools (JBoss Tools) Issue Type: Bug Components: deltacloud Affects Versions: 3.2.0.Beta2 Reporter: Andre Dietisheim Assignee: Andre Dietisheim Fix For: 3.2.0.Beta2 The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods: Mail with Jeff Johnson on the 29th of Oct: >> I discovered another possible duplication: >> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP, >> REBOOT, DESTROY (Instance#Action) >> >> On the other hand most of these actions also have their own method in >> DeltaCloudClient: >> >> startInstance >> shutdownInstance (=STOP) >> rebootInstance >> destroyInstance >> >> Is there any reason for this duplication? Which one would you remove >> (the performaAction or the individual methods)? >> >> Thanks! >> André >I would remove the individual methods. Remember that I copied and hacked an ancient version of this code so some methods that Martin thought > might be useful were never used. I didn't go about pruning them.