[ http://jira.jboss.com/jira/browse/JBIDE-982?page=all ] Max Andersen updated JBIDE-982: ------------------------------- Fix Version/s: 2.0.0.CR1 (was: 2.0.0.Beta4) slip to next -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12381306 ] Denis Golovin commented on JBIDE-982: ------------------------------------- I've added org.jboss.tools.seam.core.prefs preferences to ejb and test projects. we should handle right for several cases: 1. For seam web project in war and ear configurations Seam Dynamic Web project is parent for EJB and test project and that mean and all project for this case should have the same seam runtime. Seam Dynamic Web project has following preferences: #Mon Oct 08 18:15:32 PDT 2007 action.package=org.domain.seam01.session eclipse.preferences.version=1 model.package=org.domain.seam01.entity seam.ear.project=seam01-ear seam.ejb.project=seam01-ejb seam.project.connection.profile=DefaultDS seam.project.deployment.type=ear seam.runtime.name=seam-1.2.AP seam.test.project=seam01-test test.package=org.domain.seam01.test it contains all information about project that is used in seam related wizards. EAR and test project have simple preferences with just a link to parent projects #Mon Oct 08 18:15:32 PDT 2007 eclipse.preferences.version=1 seam.parent.project=seam01 that situation should be handled correctly by SeamCore classes. SeamProject should load runtime name from parent project . That means Seam Settings Preferences page for EJB and test projects should not allow to change seam runtime and enable disable/seam support. It should just show Seam support checkbox checked and disable, sem runtime selection combo should have seam runtime from parent project as value and also disabled. Property page should post message that seam runtime can be changed on parent project ('seam01' in current example). Project preference page for parent Dynamic web project doesn't allow to enable disable Seam support also, but it allows to change seam runtime. Changing runtime on Seam Dynamic Web project means that Seam Runtime for depended project is also changed. So SeamProject should handle it. The simplest solution just don't show Seam Settings preference page for dependent EJB and test projects. 2. Standalone seam project - any java nature project that have no seam core preferences. When Seam Support selected it should just add seam runtime in preferences. And seam support for that kind project can be enabled disabled anytime. #Mon Oct 08 18:15:32 PDT 2007 seam.runtime.name=seam-1.2.AP 3. If there is no Seam Runtime with name in seam.runtime.name preference SeamCore should create error marker for main and related projects. That runtime 'Runtime name' doesn't exists, and propose create seam runtime on Seam preference page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12381512 ] Denis Golovin commented on JBIDE-982: ------------------------------------- Existing WTP projects are in case 2, so yo can enable disable Seam for them. I agree with 2 & 3 this allow wizard to catch it and show an message when seam 2 project is selected. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12381680 ] Max Andersen commented on JBIDE-982: ------------------------------------ the runtime reference states the version + location. Even if the location is not there you know what version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12381703 ] Max Andersen commented on JBIDE-982: ------------------------------------ It is a bug if the version is not available for the runtime. if the runtime description is removed well then that is when you want to put a warning/error -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12382182 ] Max Andersen commented on JBIDE-982: ------------------------------------ so if we can't do that we just need to locate jboss-seam.jar and read the manifest...that will give you a fallback version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12382511 ] Viacheslav Kabanovich commented on JBIDE-982: --------------------------------------------- 1. Should we have button Remove in Seam preference page to remove runtime? 2. What should happen if we remove seam support from WAR project that is part of seam project in ear configuration? I mean should we remove also seam support from dependent EJB and test projects? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12382557 ] Max Andersen commented on JBIDE-982: ------------------------------------ 3) and if a project has a runtime that does not exist, put a warning marker on the project - *don't* fall back to some default. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-982?page=all ] Viacheslav Kabanovich resolved JBIDE-982. ----------------------------------------- Resolution: Done EXECUTE: In preferences, create seam runtimes R1 and R2 EXECUTE: Create seam projects P1 with runtime R1 EXECUTE: In Seam preferences, select R2 and press Delete ASSERT: Confirm dialog appears with question 'Are you sure you want to delete runtime R2?' EXECUTE: In Seam preferences, select R1 and press Delete ASSERT: Confirm dialog appears with question 'Runtime R1 is used by seam projects. Are you sure you want to delete it?' EXECUTE: Press OK and then Apply. ASSERT: In problems view, warning marker appeared for project P1 'Seam runtime R1 does not exist'. EXECUTE: Open properties for project P1 and select page Seam Settings. ASSERT: Runtime field contains 'R1' and message says 'Runtime R1 does not exist'. EXECUTE: Create runtime R1. ASSERT: Warning marker disappears from problems view. ASSERT: Project properties do not display error message. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira