[
https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi...
]
Daniel Dekany updated JBIDE-22656:
----------------------------------
Description: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the
background color of related tags, like {{<#else>}} and {{</#if>}}, is changed.
The problem is that if now you start typing into a such background-colored tag, the
offsets of the colored sections after it will become outdated, and so they start to drift
left from under the tag. This is because the up to date offsets only become available
after the reconciling thread has finished, but the background coloring logic is called
directly in the keydown handler. I'm not familiar with plugin development, but I
suspect this is architecturally wrong. Perhaps the reconciler should send some kind of
event when it's done, and if the editor content is still in the state for which the
reconciling was ran, only then should the old background coloring be removed and the new
one is added. (was: When you put the cursor inside an FTL tag, like {{<#if ...>}},
the background color of related tags (like {{<#else>}} and {{</#if>}}) is
changed. The problem is that if now you start typing into a such background-colored tag,
the offsets of the sections after it will become stale, and so they start to drift left
from under the tag. This is because the up to date offsets only become available after the
reconciling thread has finished, but the background coloring logic is called directly in
the keydown handler. I'm not familiar with plugin development, but I suspect this is
architecturally wrong. Perhaps the reconciler should send some kind of event when it's
done, and if the editor content is still in the state for which the reconciling was ran,
only then should the old background coloring be removed and the new one is added.)
Related tag background becomes misplaced when typing
----------------------------------------------------
Key: JBIDE-22656
URL:
https://issues.jboss.org/browse/JBIDE-22656
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: freemarker
Reporter: Daniel Dekany
When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color
of related tags, like {{<#else>}} and {{</#if>}}, is changed. The problem is
that if now you start typing into a such background-colored tag, the offsets of the
colored sections after it will become outdated, and so they start to drift left from under
the tag. This is because the up to date offsets only become available after the
reconciling thread has finished, but the background coloring logic is called directly in
the keydown handler. I'm not familiar with plugin development, but I suspect this is
architecturally wrong. Perhaps the reconciler should send some kind of event when it's
done, and if the editor content is still in the state for which the reconciling was ran,
only then should the old background coloring be removed and the new one is added.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)