[JBoss JIRA] (JBIDE-22911) Exception below RenameMethodParticipant$RenameMethodSearcher.outOfSynch (thrown in Thread.getStackTrace)
1:28 p.m.
[
https://issues.jboss.org/browse/JBIDE-22911?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich edited comment on JBIDE-22911 at 8/9/16 2:27 PM:
-----------------------------------------------------------------------
The logged error is the expected result as of JBIDE-13695.
I cannot understand why the behaviour of the rename searcher is implemented differently
for JSF method than for other JBoss Tools components:
CDI, EL, Seam: Adds a warning.
JSF: Logs an error.
The implementation of outOfSync reporting method:
{code}
@Override
protected void outOfSynch(IResource resource){
//status.addWarning(NLS.bind(JsfUIMessages.RENAME_METHOD_PARTICIPANT_OUT_OF_SYNC_PROJECT,
project.getFullPath().toString()));
Exception exception= new
Exception(NLS.bind(JsfUIMessages.RENAME_METHOD_PARTICIPANT_OUT_OF_SYNC_PROJECT,
resource.getFullPath().toString()));
exception.setStackTrace(Thread.currentThread().getStackTrace());
JsfUiPlugin.getDefault().logError(exception);
}
{code}
Note the commented line, it would add a warning as in other JBoss Tools components. Then
why is logging preferred that looks like an error on the part of JBoss Tools when the
matter is just a state of the project. User, seeing errors in log usually reports them as
bugs of the product rather then takes them as a clue for fixing bugs in his application.
Changes in JBIDE-13695 replace in ELRenameProcessor (jsf), SeamRenameProcessor and
CDIRenameProcessor status.addFatalError by status.addWarning, but in
RenameMethodParticipant, the same change is commented and logging is added. Why? Could
there be some specific reason for it?
[~akazakov], can we here add a warning (uncomment the first line), as everywhere else,
instead of logging an error?
was (Author: scabanovich):
The logged error is the expected result as of JBIDE-13695.
I cannot understand why the behaviour of the rename searcher is implemented differently
for JSF method than for other JBoss Tools components:
CDI, EL, Seam: Adds a warning.
JSF: Logs an error.
The implementation of outOfSync reporting method:
{code}
@Override
protected void outOfSynch(IResource resource){
//status.addWarning(NLS.bind(JsfUIMessages.RENAME_METHOD_PARTICIPANT_OUT_OF_SYNC_PROJECT,
project.getFullPath().toString()));
Exception exception= new
Exception(NLS.bind(JsfUIMessages.RENAME_METHOD_PARTICIPANT_OUT_OF_SYNC_PROJECT,
resource.getFullPath().toString()));
exception.setStackTrace(Thread.currentThread().getStackTrace());
JsfUiPlugin.getDefault().logError(exception);
}
{code}
Note the commented line, it would add a warning as in other JBoss Tools components. Then
why is logging preferred that looks like an error on the part of JBoss Tools when the
matter is just a state of the project. User, seeing errors in log usually reports them as
bugs of the product rather then takes them as a clue for fixing bugs in his application.
[~akazakov], can we here add a warning (uncomment the first line) instead of logging an
error?
Exception below
RenameMethodParticipant$RenameMethodSearcher.outOfSynch (thrown in Thread.getStackTrace)
--------------------------------------------------------------------------------------------------------
Key: JBIDE-22911
URL: https://issues.jboss.org/browse/JBIDE-22911
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsf
Affects Versions: 4.3.1.Final
Reporter: Automated Error Reporting Bot
Assignee: Viacheslav Kabanovich
Fix For: 4.4.x
The following problem was reported via the automated error reporting:
Message: HIDDEN
{noformat}
java.lang.Exception: HIDDEN
at java.lang.Thread.getStackTrace(null:-1)
at
org.jboss.tools.jsf.ui.el.refactoring.RenameMethodParticipant$RenameMethodSearcher.outOfSynch(RenameMethodParticipant.java:145)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:148)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.scanProject(RefactorSearcher.java:108)
at
org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.findELReferences(RefactorSearcher.java:166)
at
org.jboss.tools.jsf.ui.el.refactoring.RenameMethodParticipant.checkConditions(RenameMethodParticipant.java:58)
at
org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:257)
at
org.eclipse.ltk.core.refactoring.Refactoring.checkAllConditions(Refactoring.java:162)
at
org.eclipse.jdt.internal.ui.refactoring.RefactoringExecutionHelper$Operation.run(RefactoringExecutionHelper.java:80)
at
org.eclipse.jdt.internal.core.BatchOperation.executeOperation(BatchOperation.java:39)
at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:729)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5409)
at
org.eclipse.jdt.internal.ui.actions.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:106)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)
{noformat}
Bundles:
| org.eclipse.core.resources | 3.10.1.v20150725-1910 | 3.11.0.v20160503-1608 |
| org.eclipse.jdt.core | 3.11.0.xx-201604081629-e45 | 3.12.0.v20160516-2131 |
| org.eclipse.jdt.ui | 3.11.2.v20151123-1510 | 3.12.0.v20160525-1829 |
| org.eclipse.jface | 3.11.1.v20160128-1644 | 3.12.0.v20160518-1929 |
| org.eclipse.ltk.core.refactoring | 3.6.201.v20150819-1034 | 3.7.0.v20160419-0705 |
| org.eclipse.ltk.ui.refactoring | 3.7.200.v20140625-1835 | 3.7.200.v20140625-1835 |
| org.jboss.tools.jsf.ui | 3.7.1.Final-v20160330-2256-B84 | 3.8.0.Final-v20160610-0126-B1
|
| org.jboss.tools.jst.web.kb | 3.7.1.Final-v20160331-0256-B96 |
3.8.0.Final-v20160609-2146-B2 |
Operating Systems:
| Linux | 3.19.0 | 4.2.0 |
| MacOSX | 10.11.4 | 10.11.4 |
| Windows | 6.1.0 | 10.0.0 |
The above information is a snapshot of the collected data. Visit [this
page|https://redhat.ctrlflow.com/reviewers/#!/problems/5730baa5e4b0ba8b6a...] for the
latest data.
Thank you for your assistance.
Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
3535
days inactive
3535
days old
jbosstools-issues@lists.jboss.org
0 comments
1 participants
participants (1)
-
Viacheslav Kabanovich (JIRA)