9:40 a.m.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.2.0.Beta
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and 7-13
seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:43 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Maxim Areshkau commented on JBIDE-7021:
---------------------------------------
Created a small test and tried to disable validators to find a slowest one. Looks like
problem in "JBoss KB Project Validator" with this validator validation time
increased dramatically.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.2.0.Beta
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:39 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Maxim Areshkau edited comment on JBIDE-7021 at 9/9/10 3:39 AM:
---------------------------------------------------------------
Created a small test and tried to disable validators to find a slowest one. Looks like
problem in XHTMLSyntaxValidator with this validator validation time increased
dramatically.
was (Author: mareshkau):
Created a small test and tried to disable validators to find a slowest one. Looks like
problem in "JBoss KB Project Validator" with this validator validation time
increased dramatically.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.2.0.Beta
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:22 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Maxim Areshkau updated JBIDE-7021:
----------------------------------
Fix Version/s: 3.3.x
(was: 3.2.0.Beta)
After consulting with Moskov team, it's hard to cash smth. here, so on next release,
because not broke smth very hard.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:45 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
Here are some comments from e-mails:
On Wed, Sep 15, 2010 at 4:27 PM, Alexey Kazakov <akazakov(a)exadel.com> wrote:
On 09/15/2010 05:11 PM, Andersen Max wrote:
>>
>> Here are results of my yesterday researching:
>>
>> The slowest our validators are XHTML Syntax validator and JSF EL
>> Validator.
>> But for different kinds of validators they work differently.
>>
>> For example on my machine with a project with more than 1500 xhtmls
>> without any ELs (more than 1000 lines in each file, 30% xhtml tags and 70%
>> html):
>> JBT XHTML Syntax validator takes ~ 1 minute.
>> WTP HTML Syntax validator takes ~ 2 minutes.
>> JBT JSF EL Validator takes ~ 1 minute (there is not any EL but it takes
>> one minute to create pages contexts first time).
>>
>> If we add about 40 EL in every XHTML page (four-level ELs like
>> #{bean.x().y().z()}. So the project has more than 60 000 complex ELs:
>> JBT XHTML Syntax validator takes ~ 1 minute.
>> WTP HTML Syntax validator takes ~ 2 minutes.
>> JBT JSF EL Validator takes ~ 15 minutes.
>
> ok - so why is this suddenly taking 15 minutes ? :)
>
> Is it our EL parser ?
> Our EL context lookup s ?
> Our validation against seam/java model ?
>
> /max
Needs further investigation. But I don't think it's our EL parser or EL
context lookup (they work fast in other validators/features). I guess the
slowest part is how we work with java model. We use some cash there. But
anyway for really big project it's not fast enough.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
JSF/Seam/CDI validators revalidate unchanged files in following cases only:
1.) Clean/Build on the project.
2.) Manual validation on the resource.
3.) JSF EL validator could revalidate ELs from unchanged files. For example:
- We have Comp1.java with @Name("comp1") and page.xhtml with #{comp1.foo}
- Comp1.java is changed.
- Then we will revalidate #{comp1.foo} in page.xhtml (not the entire page but only
relevant ELs).
The same for Seam, CDI validators. If we changed some stereotype then we will revalidate
all the beans that use it, etc.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Max Andersen commented on JBIDE-7021:
-------------------------------------
Alexey wrote:
Here are results of my yesterday researching:
The slowest our validators are XHTML Syntax validator and JSF EL Validator.
But for different kinds of validators they work differently.
For example on my machine with a project with more than 1500 xhtmls without any ELs (more
than 1000 lines in each file, 30% xhtml tags and 70% html):
JBT XHTML Syntax validator takes ~ 1 minute.
WTP HTML Syntax validator takes ~ 2 minutes.
JBT JSF EL Validator takes ~ 1 minute (there is not any EL but it takes one minute to
create pages contexts first time).
If we add about 40 EL in every XHTML page (four-level ELs like #{bean.x().y().z()}. So
the project has more than 60 000 complex ELs:
JBT XHTML Syntax validator takes ~ 1 minute.
WTP HTML Syntax validator takes ~ 2 minutes.
JBT JSF EL Validator takes ~ 15 minutes.
Max comments:
k - so why is this suddenly taking 15 minutes ? :)
Is it our EL parser ?
Our EL context lookup s ?
Our validation against seam/java model ?
Alexey comments:
Needs further investigation. But I don't think it's our EL parser or EL context
lookup (they work fast in other validators/features). I guess the slowest part is how we
work with java model. We use some cash there. But anyway for really big project it's
not fast enough.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov edited comment on JBIDE-7021 at 9/16/10 3:05 AM:
----------------------------------------------------------------
removed
was (Author: akazakov):
Here are some comments from e-mails:
On Wed, Sep 15, 2010 at 4:27 PM, Alexey Kazakov <akazakov(a)exadel.com> wrote:
On 09/15/2010 05:11 PM, Andersen Max wrote:
>>
>> Here are results of my yesterday researching:
>>
>> The slowest our validators are XHTML Syntax validator and JSF EL
>> Validator.
>> But for different kinds of validators they work differently.
>>
>> For example on my machine with a project with more than 1500 xhtmls
>> without any ELs (more than 1000 lines in each file, 30% xhtml tags and 70%
>> html):
>> JBT XHTML Syntax validator takes ~ 1 minute.
>> WTP HTML Syntax validator takes ~ 2 minutes.
>> JBT JSF EL Validator takes ~ 1 minute (there is not any EL but it takes
>> one minute to create pages contexts first time).
>>
>> If we add about 40 EL in every XHTML page (four-level ELs like
>> #{bean.x().y().z()}. So the project has more than 60 000 complex ELs:
>> JBT XHTML Syntax validator takes ~ 1 minute.
>> WTP HTML Syntax validator takes ~ 2 minutes.
>> JBT JSF EL Validator takes ~ 15 minutes.
>
> ok - so why is this suddenly taking 15 minutes ? :)
>
> Is it our EL parser ?
> Our EL context lookup s ?
> Our validation against seam/java model ?
>
> /max
Needs further investigation. But I don't think it's our EL parser or EL
context lookup (they work fast in other validators/features). I guess the
slowest part is how we work with java model. We use some cash there. But
anyway for really big project it's not fast enough.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Maxim Areshkau
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:08 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
I found the resoun why XHTML Syntax validator works so slow in
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
project.
Some XHTMLs don't have <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> there.
Such files are validated very slowly by XHTML validators. Probably because of unsuccessful
schema resolving. I disabled it in the validator and now validation for this project for
me takes ~4 secs without XHTML Syntax validator and ~5 secs with it. Before the fix it
toke more then one minute.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:08 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
BTW, thanks Maxim for the test project :)
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:30 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Felipe Duarte commented on JBIDE-7021:
--------------------------------------
Alexey,
we have various xhtml files that use the tag "<ui:composite template .." , so
they dont have "<!DOCTYPE html .." tag, only the father form have it .. This
could be causing the slowness?
Example:
<?xml version="1.0" encoding="ISO-8859-1"?>
<ui:composition template="/pages/layout/masterLayout.xhtml"
xmlns="http://www.w3.org/1999/xhtml"
xmlns:t="http://myfaces.apache.org/tomahawk"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core"
xmlns:c="http://java.sun.com/jstl/core">
<ui:define name="conteudo">
<!-- some code here -->
</ui:define>
</ui:composition>
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
Yes, it dramatically decrease performance if there is not <!DOCTYPE... in an XHTML. In
my testes just a few such files are validated more then a minute! So if you have 200 files
it can takes hours... Could you please verify it in your project? It would be great if you
added <!DOCTYPE... in every XHTML and also verified next nightly build which includes
today fix in the original project without doctype declarations.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.3.x
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:45 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov updated JBIDE-7021:
----------------------------------
Fix Version/s: 3.2.0.Beta
(was: 3.3.x)
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:30 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Snjezana Peco updated JBIDE-7021:
---------------------------------
Attachment: jbide7021.patch
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:30 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Snjezana Peco commented on JBIDE-7021:
--------------------------------------
I have found the following issues:
1) The PageContextFactory.createPageContext(IFile file, List<String> parents, String
defaultContextType) method creates SSE model for a non-facelet page.
The attached patch fixes this problem. Validation will be faster when the project contains
a lot of non-facelet pages.
2) Another problem happens when some page contains EL errors/warnings.
ValidationErrorManage.addError(...) notifies marker resource change and PageContextFactory
cleans the cache. If there is a complex El expression, PageConteXtFactory creates context
(SSE model, ...) again for the same page. The problem is fixed within the patch
This speeds up building/validation of the projects that I have tested (for about 50%). It
should be pointed out that it includes EL validator that is the slowest.
3) XJob can notify a resource change and PageContextFactory cleans the cache, but I not
sure if we can suspend XJob so I haven't tried to fix this problem.
4) There is a memory leak in the PageContextFactory.getSheetForTagAttribute(final Node
stylesContainer, String attribute) method. This method registers the
ExtendedLinkElementAdapter adapter, but never releases it. I have fixed this bug partially
(for an invalid CSS sheet).
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
Snjezana, I've applied your patch. Thank you.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:51 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov updated JBIDE-7021:
----------------------------------
Fix Version/s: 3.2.0.CR1
(was: 3.2.0.Beta1)
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta2
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
I found two big problems:
1.) We clean up the page context cache too often. For example if any validator creates a
marker on the resource then we remove this resource from the cache. I removed
PageContextFactory from resource listeners to fix this problem. KB project will clean the
cache up if it's really needed. (Fixed for Beta1)
2.) If there is a lot of errors then it takes a lot of time to create error markes. It
takes ~ 1 minute to create 2000 markers in my test project. I think we should limit the
list of problem markers for a resource. Let's do it for Beta2.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta2
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:02 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov resolved JBIDE-7021.
-----------------------------------
Fix Version/s: 3.2.0.Beta1
(was: 3.2.0.Beta2)
Resolution: Done
We have improved our validators and now they work faster. But some problems remain.
Let's creates separate issues for them. For example - JBIDE-7147
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:04 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov updated JBIDE-7021:
----------------------------------
Labels: new_and_noteworthy (was: )
Affects: [Documentation (Ref Guide, User Guide, etc.)]
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:04 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov resolved JBIDE-7021.
-----------------------------------
Resolution: Partially Completed
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Snjezana Peco commented on JBIDE-7021:
--------------------------------------
The problem that you are talking about:
1.) We clean up the page context cache too often. For example if any
validator creates a marker on the resource then we remove this
resource from the cache. I removed PageContextFactory from resource listeners to fix this
problem. KB project will clean the cache up
if it's really needed. (Fixed for Beta1)
is the same problem that I already described in my previous comment. ( point 2 -
ValidationErrorManage.addError(...) creates markers).
However, you have commented the lines 347-386 in PageContextFactory which causes the SSE
model to be unnecessary created for non-facelet pages (described in point 1 of my previous
comment). validation of a project containing a lot of non-facelet pages (pages.xml,
*.jsps, *.xml ...) will be slower.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:47 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
> is the same problem that I already described in my previous
comment. ( point 2 - ValidationErrorManage.addError(...) creates markers).
Yes, it is. Thank you for pointing to that problem. I just improved your solution and
removed PageContextFactory from resource listeners at all because our validators is not
the only place where resources can be modified without changing their content.
> However, you have commented the lines 347-386 in
PageContextFactory.
Yes, I commented this code for Beta2, because it brakes EL
validation/refactoring/searching/... for JSPs at all. See JBIDE-7167.
We should look at this problem more carefully and try to fix it properly in Beta2.
If you find new problems (I know we still have some) please create separate issues.
And of course, Snjezana, your help with fixing performance problems is still very
appreciated :)
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Snjezana Peco commented on JBIDE-7021:
--------------------------------------
> However, you have commented the lines 347-386 in
PageContextFactory.
Yes, I commented this code for Beta2, because it brakes EL
validation/refactoring/searching/... for JSPs at all. See JBIDE-7167.
We should look at this problem more carefully and try to fix it properly in Beta2.
The lines 347-386 are copied from 387-432 and do the same thing. The only change is that
the SSE model isn't unnecessarily created (see your line 493 and the line 364 I
added). Do you have any example where this code breaks "EL
validation/refactoring/searching/..." ?
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:12 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Alexey Kazakov commented on JBIDE-7021:
---------------------------------------
1. Create JSF Kick start project with JSPs.
2. Rename the properties of User managed bean there.
3. Rebuild the project.
If you open any JSP in JSP Editor then SSE model will be created by the editor and
incremental validation will work. But if you validate any JSP which in not opened in JSP
editor then it doesn't work.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:51 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-7021) Low perfomance of validation for web pages
[
https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.s...
]
Vlado Pakan closed JBIDE-7021.
------------------------------
Verified on JBT 3.2.0.v20100925-0935-H92-Beta1.
Low perfomance of validation for web pages
------------------------------------------
Key: JBIDE-7021
URL: https://jira.jboss.org/browse/JBIDE-7021
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml source editing
Affects Versions: 3.2.0.Beta1
Reporter: Maxim Areshkau
Assignee: Alexey Kazakov
Fix For: 3.2.0.Beta1
Attachments: jbide7021.patch
#1 import project
https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.js...
into workspace;
#2 try to call validate on jsfTest/WebContent
#3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and
7-13 seconds without JBoss Tools just with WPT installed.
So looks like we need to do smth for speeding up the validation process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5674
days inactive
5696
days old
jbosstools-issues@lists.jboss.org
25 comments
6 participants
participants (6)
-
Alexey Kazakov (JIRA) -
Felipe Duarte (JIRA)
-
Max Andersen (JIRA)
-
Maxim Areshkau (JIRA)
-
Snjezana Peco (JIRA)
-
Vlado Pakan (JIRA)