[
https://issues.jboss.org/browse/JBIDE-22544?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich edited comment on JBIDE-22544 at 6/6/16 8:54 PM:
-----------------------------------------------------------------------
org.eclipse.wst.xml.core.internal.validation.eclipse.Validator is called twice from
org.eclipse.wst.validation.internal.ValManager and all results are summed. This happens
not only for batch job xml, but for any xml file.
It is shown in preferences Validation list as 'XML Validator'. If I disable all
other validators, still error markers are duplicated. If I disable 'XML
Validator', this kind of errors does not appear. But, the problem is not that the
validator duplicates errors itself, but it is that the validator is called twice during
the project validation.
ValBuilderJob.runInWorkspace() has a loop in which it repeats validation until
getRequest() returns null. Then ValManager.validate(IProject,...) calls delete markers,
but it works only for the first call, it is designed to accumulate markers created in
multiple calls from ValBuilderJob during the same build.
Two 'complete' requests that make the same file to be validated twice come
independently from
1) org.eclipse.wst.validation.internal.operations.ValidationBuilder
2) org.eclipse.wst.jsdt.internal.core.builder.JavaBuilder
was (Author: scabanovich):
org.eclipse.wst.xml.core.internal.validation.eclipse.Validator is called twice from
org.eclipse.wst.validation.internal.ValManager and all results are summed. This happens
not only for batch job xml, but for any xml file.
It is shown in preferences Validation list as 'XML Validator'. If I disable all
other validators, still error markers are duplicated. If I disable 'XML
Validator', this kind of errors does not appear. But, the problem is not that the
validator duplicates errors itself, but it is that the validator is called twice during
the project validation.
ValBuilderJob.runInWorkspace() has a loop in which it repeats validation until
getRequest() returns null. Then ValManager.validate(IProject,...) calls delete markers,
but it works only for the first call, it is designed to accumulate markers created in
multiple calls from ValBuilderJob during the same build.
Two 'complete' request that make the same file to be validated twice come
independently from
1) org.eclipse.wst.validation.internal.operations.ValidationBuilder
2) org.eclipse.wst.jsdt.internal.core.builder.JavaBuilder
Redudant error report in Devstudio's Problems View
--------------------------------------------------
Key: JBIDE-22544
URL:
https://issues.jboss.org/browse/JBIDE-22544
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: batch, upstream
Reporter: Ondrej Dockal
Assignee: Viacheslav Kabanovich
Fix For: 4.4.x
Attachments:
org.jboss.tools.batch.ui.bot.test.editor.design.DesignChunkStepElementTest.createStep(7).png
Some test fails on checking number of errors in Problems View in devstudio. There are
duplicated error reports.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)