2:24 p.m.
Cody Lerum created JBIDE-11867:
----------------------------------
Summary: Tooling for CDI Event identifies invalid observer
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Alexey Kazakov
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:24 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Cody Lerum updated JBIDE-11867:
-------------------------------
Attachment: cdi_event.png
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Alexey Kazakov
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Alexey Kazakov updated JBIDE-11867:
-----------------------------------
Fix Version/s: 3.3.0.CR1
Assignee: Viacheslav Kabanovich (was: Alexey Kazakov)
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:41 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-11867:
-----------------------------------------------
It seems I implemented it the other way around. I followed the item
"10.2. Observer resolution:
An event is delivered to an observer method if:
...
The observer method has all the event qualifiers.
..."
I concluded from this, that if a fired event has a qualifier, then an observer needs to
have it too, in order to receive the event; but that observer is free to have more
qualifiers and they will not prevent the event from being delivered.
However, now reading in the beginning of chapter 10:
"An observer method will be notified of an event if the event object is assignable to
the observed event type, and if all the observed event qualifiers are event qualifiers of
the event.", I see that it is opposite to what I draw from 10.2.
Can it be that 10.2 contradicts to other statements, or is it my misunderstanding?
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:49 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Cody Lerum commented on JBIDE-11867:
------------------------------------
My understanding is that
{code}@Foo Event<AuditLog> auditLog;{code}
Would be observed by:
@Observes AuditLog auditLog;
@Observes @Foo AuditLog auditLog;
However
{code}Event<AuditLog> auditLog;{code} would not be observed by a more specific
observer such as @Observes @Foo AuditLog auditLog;
See - http://docs.jboss.org/cdi/spec/1.0/html_single/#d0e6742
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:51 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Cody Lerum edited comment on JBIDE-11867 at 5/15/12 4:50 PM:
-------------------------------------------------------------
My understanding is that
{code}@Foo Event<AuditLog> auditLog;{code}
Would be observed by:
@Observes AuditLog auditLog;
@Observes @Foo AuditLog auditLog;
However
{code}Event<AuditLog> auditLog;{code} would not be observed by a more specific
observer such as @Observes @Foo AuditLog auditLog;
Exact observers and also less specific observers.
See - http://docs.jboss.org/cdi/spec/1.0/html_single/#d0e6742
was (Author: clerum):
My understanding is that
{code}@Foo Event<AuditLog> auditLog;{code}
Would be observed by:
@Observes AuditLog auditLog;
@Observes @Foo AuditLog auditLog;
However
{code}Event<AuditLog> auditLog;{code} would not be observed by a more specific
observer such as @Observes @Foo AuditLog auditLog;
See - http://docs.jboss.org/cdi/spec/1.0/html_single/#d0e6742
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:57 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-11867:
-----------------------------------------------
Yes, I agree, that 10.2.3 clearly supports your viewpoint, and I will fix my
implementation, but could you please comment the rule 10.2 that I used before; should we
suggest that the CDI team make it correct; or is it correct as is, and it was my fault to
misunderstand it?
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:47 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Cody Lerum commented on JBIDE-11867:
------------------------------------
Looks like it was vague and fixed in CDI 1.1 SPEC -
http://docs.jboss.org/cdi/spec/1.1.EDR1/html_single/#observerresolution
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:13 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-11867:
-----------------------------------------------
I think that we cannot consistently check if there is an observer to receive an event.
In the case, given in description, the event can be sent to the observer by
{code}
eventLog.select(new NowLiteral()).fire();
{code}
Runtime does not fail, when there is no observer for a fired event. Events may be fired by
a framework application to be caught in a custom application that has it in its
classpath.
I will create a new feature request about the warning, and resolve this issue as what it
declares by its title is fixed.
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:23 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-11867:
-----------------------------------------------
JBIDE-11899 Show a warning when no observer exists to receive an injected event
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Alexey Kazakov resolved JBIDE-11867.
------------------------------------
Assignee: Viacheslav Kabanovich (was: Alexey Kazakov)
Resolution: Done
Fixed.
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Cody Lerum commented on JBIDE-11867:
------------------------------------
I can confirm this is working correctly in today's nightly.
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:56 p.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Alexey Kazakov commented on JBIDE-11867:
----------------------------------------
Thanks Cody.
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 a.m.
[
https://issues.jboss.org/browse/JBIDE-11867?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič closed JBIDE-11867.
-------------------------------------
Verified with jbosstools-3.3_stable_branch.aggregate-Update-2012-05-27_14-14-33-H161.zip.
Closing this JIRA.
Tooling for CDI Event identifies invalid observer
-------------------------------------------------
Key: JBIDE-11867
URL: https://issues.jboss.org/browse/JBIDE-11867
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta2
Environment: Eclipse Version: Indigo Service Release 2 Build id: 20120216-1857
JBoss Tools Nightly
Context and Dependency Injection
Tools 1.2.0.v20120508-1258-H1103-CR1 org.jboss.tools.cdi.feature.feature.group JBoss by
Red Hat
Reporter: Cody Lerum
Assignee: Viacheslav Kabanovich
Fix For: 3.3.0.CR1
Attachments: cdi_event.png
With the following event
{code}
@Inject
private Event<EventLog> eventLog;
{code}
Tooling suggests that the following is a valid observer which it is not because it
specifics an additional qualifier. Additionally it should show a warning that no observer
exists to receive this event.
{code}
public void log(@Observes @Now EventLog eventLog) {
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5061
days inactive
5074
days old
jbosstools-issues@lists.jboss.org
13 comments
4 participants
participants (4)
-
Alexey Kazakov (JIRA) -
Cody Lerum (JIRA)
-
Jaroslav Jankovič (JIRA)
-
Viacheslav Kabanovich (JIRA)