[JBoss JIRA] Created: (JBIDE-4338) org.jboss.tools.common.util.test.HttpUtilTest are failing because of NPE when trying to get Proxy Service
4:09 a.m.
org.jboss.tools.common.util.test.HttpUtilTest are failing because of NPE when trying to
get Proxy Service
---------------------------------------------------------------------------------------------------------
Key: JBIDE-4338
URL: https://jira.jboss.org/jira/browse/JBIDE-4338
Project: Tools (JBoss Tools)
Issue Type: Task
Components: common
Reporter: Max Rydahl Andersen
Assignee: Alexey Kazakov
Priority: Blocker
Fix For: 3.1.0.M1
The test fails for me locally too, apparently CommonPlugin instance variable is not
initialized because it is never been setup to start afaics.
Any idea what caused this ? i.e. did we change the startup sequence of plugins or ?
I would also expect the instance to be initialized in a start() method and not on the
constructor which seems very non-standard way.
Last failure:
http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180...
And here is the NPE you can see if you remove the fail and exception handling code
java.lang.NullPointerException
at org.jboss.tools.common.util.HttpUtil.getProxyService(HttpUtil.java:190)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
at
org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:20 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-4338) org.jboss.tools.common.util.test.HttpUtilTest are failing because of host not set
[
https://jira.jboss.org/jira/browse/JBIDE-4338?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-4338:
---------------------------------------
Summary: org.jboss.tools.common.util.test.HttpUtilTest are failing because of host
not set (was: org.jboss.tools.common.util.test.HttpUtilTest are failing because of NPE
when trying to get Proxy Service)
Description:
The test fails for me locally too, apparently commons http client is throwing exception
because of missing host.
Any idea what caused this ? i.e. did we change how we use this ? Do we even use HttpUtil
anymore ?
Last failure:
http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180...
And here is the Exception you can see if you remove the fail and exception handling code
(i committed that change)
java.lang.IllegalArgumentException: Host name may not be null
at org.apache.commons.httpclient.HttpHost.<init>(HttpHost.java:67)
at org.apache.commons.httpclient.ProxyHost.<init>(ProxyHost.java:63)
at org.apache.commons.httpclient.HostConfiguration.setProxy(HostConfiguration.java:403)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:169)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
at
org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication$1.run(UITestApplication.java:114)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication.start(UITestApplication.java:46)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
was:
The test fails for me locally too, apparently CommonPlugin instance variable is not
initialized because it is never been setup to start afaics.
Any idea what caused this ? i.e. did we change the startup sequence of plugins or ?
I would also expect the instance to be initialized in a start() method and not on the
constructor which seems very non-standard way.
Last failure:
http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180...
And here is the NPE you can see if you remove the fail and exception handling code
java.lang.NullPointerException
at org.jboss.tools.common.util.HttpUtil.getProxyService(HttpUtil.java:190)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
at
org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
My initial analysis were wrong since I just ran the test as a normal unittest and not as a
plugin test. I've updated the bug to be correct.
org.jboss.tools.common.util.test.HttpUtilTest are failing because of
host not set
---------------------------------------------------------------------------------
Key: JBIDE-4338
URL: https://jira.jboss.org/jira/browse/JBIDE-4338
Project: Tools (JBoss Tools)
Issue Type: Task
Components: common
Reporter: Max Rydahl Andersen
Assignee: Alexey Kazakov
Priority: Blocker
Fix For: 3.1.0.M1
The test fails for me locally too, apparently commons http client is throwing exception
because of missing host.
Any idea what caused this ? i.e. did we change how we use this ? Do we even use HttpUtil
anymore ?
Last failure:
http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180...
And here is the Exception you can see if you remove the fail and exception handling code
(i committed that change)
java.lang.IllegalArgumentException: Host name may not be null
at org.apache.commons.httpclient.HttpHost.<init>(HttpHost.java:67)
at org.apache.commons.httpclient.ProxyHost.<init>(ProxyHost.java:63)
at org.apache.commons.httpclient.HostConfiguration.setProxy(HostConfiguration.java:403)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:169)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
at
org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication$1.run(UITestApplication.java:114)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication.start(UITestApplication.java:46)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:52 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-4338) org.jboss.tools.common.util.test.HttpUtilTest are failing because of host not set
[
https://jira.jboss.org/jira/browse/JBIDE-4338?page=com.atlassian.jira.plu...
]
Alexey Kazakov resolved JBIDE-4338.
-----------------------------------
Resolution: Done
This bug was caused by changes in org.eclipse.core.net.proxy in Eclipse 3.5. We use this
code to set http proxy if it is enabled in preferences.
HttpUtil code is used in our Problem Reporting dialog.
org.jboss.tools.common.util.test.HttpUtilTest are failing because of
host not set
---------------------------------------------------------------------------------
Key: JBIDE-4338
URL: https://jira.jboss.org/jira/browse/JBIDE-4338
Project: Tools (JBoss Tools)
Issue Type: Task
Components: common
Reporter: Max Rydahl Andersen
Assignee: Alexey Kazakov
Priority: Blocker
Fix For: 3.1.0.M1
The test fails for me locally too, apparently commons http client is throwing exception
because of missing host.
Any idea what caused this ? i.e. did we change how we use this ? Do we even use HttpUtil
anymore ?
Last failure:
http://hudson.qa.jboss.com/hudson/job/jbosstools-nightly-3.1.0.Alpha1/180...
And here is the Exception you can see if you remove the fail and exception handling code
(i committed that change)
java.lang.IllegalArgumentException: Host name may not be null
at org.apache.commons.httpclient.HttpHost.<init>(HttpHost.java:67)
at org.apache.commons.httpclient.ProxyHost.<init>(ProxyHost.java:63)
at org.apache.commons.httpclient.HostConfiguration.setProxy(HostConfiguration.java:403)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:169)
at org.jboss.tools.common.util.HttpUtil.createHttpClient(HttpUtil.java:144)
at
org.jboss.tools.common.util.test.HttpUtilTest.testCreateHttpClient(HttpUtilTest.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at
org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication$1.run(UITestApplication.java:114)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at
org.eclipse.pde.internal.junit.runtime.UITestApplication.start(UITestApplication.java:46)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6165
days inactive
6165
days old
jbosstools-issues@lists.jboss.org
2 comments
2 participants
participants (2)
-
Alexey Kazakov (JIRA) -
Max Rydahl Andersen (JIRA)