[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov edited comment on JBIDE-8801 at 6/7/11 1:48 PM:
--------------------------------------------------------------
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
agree
isNewProjectWizard does not seem to consider the case where the facet
delegate is run from the dynamic web project? Should it ? or is that considered a case
where it
shouldn't copy libraries too ?
if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property
and set it to "false" only in case of adding Seam Facet to existing project.
it should work
was (Author: dazarov):
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
agree
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
isNewProjectWizard does not seem to consider the case where the facet
delegate is run from the dynamic web project? Should it ? or is that considered a case
where it >shouldn't copy libraries too ?
if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property
and set it to "false" only in case of adding Seam Facet to existing project.
it should work
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL:
https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira