[JBoss JIRA] Created: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime
1:39 p.m.
Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime
-------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Alexey Kazakov commented on JBIDE-8801:
---------------------------------------
It means that the delegate should not copy resources in case of installing it to an
existing project. But if Seam Facet Install Delegate was invoked by New Project wizard
then it should copy all required resources as before.
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime
-------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov updated JBIDE-8801:
---------------------------------
Summary: Seam Facet Install Delegate should not copy resources and libraries from Seam
Runtime in case of installing it to an existing project. (was: Seam Facet Install
Delegate should not copy resources and libraries from Seam Runtime)
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-8801:
----------------------------------
Fix Version/s: 3.3.0.M2
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:38 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov updated JBIDE-8801:
---------------------------------
Attachment: JBIDE-8801.patch
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:38 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov commented on JBIDE-8801:
--------------------------------------
Max, I've done this issue. Can I commit it?
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:22 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen commented on JBIDE-8801:
--------------------------------------------
looking at patch.
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
isNewProjectWizard does not seem to consider the case where the facet delegate is run from
the dynamic web project? Should it ? or is that considered a case where it shouldn't
copy libraries too ?
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Max Rydahl Andersen
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:48 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov edited comment on JBIDE-8801 at 6/7/11 1:48 PM:
--------------------------------------------------------------
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
agree
isNewProjectWizard does not seem to consider the case where the facet
delegate is run from the dynamic web project? Should it ? or is that considered a case
where it
shouldn't copy libraries too ?
if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property
and set it to "false" only in case of adding Seam Facet to existing project.
it should work
was (Author: dazarov):
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
agree
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
isNewProjectWizard does not seem to consider the case where the facet
delegate is run from the dynamic web project? Should it ? or is that considered a case
where it >shouldn't copy libraries too ?
if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property
and set it to "false" only in case of adding Seam Facet to existing project.
it should work
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:48 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov commented on JBIDE-8801:
--------------------------------------
Shouldn't:
if(!isNewProjectWizard())
+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
false);
just be replaced with:
model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING,
!isNewProjectWizard());
?
agree
Shouldn't all instances of
model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be
refactored into
a method call aka shouldCopySeamRuntimeLibraries() or similar ?
isNewProjectWizard does not seem to consider the case where the facet
delegate is run from the dynamic web project? Should it ? or is that considered a case
where it >shouldn't copy libraries too ?
if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property
and set it to "false" only in case of adding Seam Facet to existing project.
it should work
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov updated JBIDE-8801:
---------------------------------
Attachment: JBIDE-8801_new.patch
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 p.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov resolved JBIDE-8801.
----------------------------------
Resolution: Done
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Snjezana Peco resolved JBIDE-8801.
----------------------------------
Resolution: Done
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:05 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov commented on JBIDE-8801:
--------------------------------------
It was my fault.
Thank you, Snjezana
I verified this issue - now all works fine
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:05 p.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Daniel Azarov resolved JBIDE-8801.
----------------------------------
Resolution: Done
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-8801:
----------------------------------
Labels: new_and_noteworthy (was: )
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Labels: new_and_noteworthy
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-8801:
----------------------------------
Issue Type: Bug (was: Feature Request)
Labels: (was: new_and_noteworthy)
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Seam
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:32 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Alexey Kazakov updated JBIDE-8801:
----------------------------------
Affects Version/s: 3.3.0.M1
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Seam
Affects Versions: 3.3.0.M1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:39 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-8801) Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.
[
https://issues.jboss.org/browse/JBIDE-8801?page=com.atlassian.jira.plugin...
]
Vlado Pakan closed JBIDE-8801.
------------------------------
Verified on jbdevstudio-product-linux-gtk-5.0.0.v201106241117R-H14-M2.
Seam Facet Install Delegate should not copy resources and libraries
from Seam Runtime in case of installing it to an existing project.
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-8801
URL: https://issues.jboss.org/browse/JBIDE-8801
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Seam
Affects Versions: 3.3.0.M1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.M2
Attachments: JBIDE-8801.patch, JBIDE-8801_new.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4885
days inactive
4948
days old
jbosstools-issues@lists.jboss.org
17 comments
5 participants
participants (5)
-
Alexey Kazakov (JIRA) -
Daniel Azarov (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Snjezana Peco (JIRA)
-
Vlado Pakan (JIRA)