[
https://issues.jboss.org/browse/JBIDE-25901?page=com.atlassian.jira.plugi...
]
Martin Malina edited comment on JBIDE-25901 at 4/5/18 2:18 AM:
---------------------------------------------------------------
[~rob.stryker] the main problem here is that you never told anybody about those choices
that you made. I may admit that it makes sense, but I cannot guess how you made things
work - I was operating under the assumption that we honor $MINISHIFT_HOME at all times. So
when I see it not being the case what do I do? I report a bug!
So this is not about me feeling it should work one way or the other. This is about me
inferring the correct behavior based on the information you gave me previously.
OK, now about minishift home. You're right that the situation is not ideal. Especially
for the use case of avoiding the CLI altogether (i.e. when downloading using runtime
detection) it seems to make sense to make up a unique minishift home directory for each
new binary/adapter. But in another case it may be desirable. Consider this scenario:
You're all set in CLI - you have your custom $MINISHIFT_HOME and a cdk binary
somewhere. You start devstudio and search your cdk dir or start creating a cdk server
adapter manually - in both cases it would be preferable to use the $MINISHIFT_HOME
variable. So now which one is more common - to have multiple cdk adapters where we
don't want to use one minishift home path for all of them OR users having
$MINISHIFT_HOME setup and dealing with just one cdk binary. I'm afraid I cannot answer
this one with high level of confidence, but I would guess that multiple cdk
binaries/adapters is not a common setup for our end users.
One more question: Can you please sum up the use cases where having $MINISHIFT_HOME will
make a difference? I just did a quick test to see what happens if I have that and install
devstudio and then run it. The result was that runtime detection had both paths -
~/.minishift and $MINISHIFT_HOME. Is that intended? What are the other use cases for
$MINISHIFT_HOME? Thanks!
was (Author: mmalina):
[~rob.stryker] the main problem here is that you never told anybody about those choices
that you made. I may admit that it makes sense, but I cannot guess how you made things
work - I was operating under the assumption that we honor $MINISHIFT_HOME at all times. So
when I see it not being the case what do I do? I report a bug!
So this is not about me feeling it should work one way or the other. This is about me
inferring the correct behavior based on the information you gave me previously.
OK, now about minishift home. You're right that the situation is not ideal. Especially
for the use case of avoiding the CLI altogether (i.e. when downloading using runtime
detection) it seems to make sense to make up a unique minishift home directory for each
new binary/adapter. But in another case it may be desirable. Consider this scenario:
You're all set in CLI - you have your custom $MINISHIFT_HOME and a cdk binary
somewhere. You start devstudio and search your cdk dir or start creating a cdk server
adapter manually - in both cases it would be preferable to use the $MINISHIFT_HOME
variable. So now which one is more common - to have multiple cdk adapters where we
don't want to use one minishift home path for all of them OR users having
$MINISHIFT_HOME setup and dealing with just one cdk binary. I'm afraid I cannot answer
this one with high level of confidence, but I would guess that multiple cdk
binaries/adapters is not a common setup for our end users.
One more question: Can you please some up the use cases where having $MINISHIFT_HOME will
make a difference? I just did a quick test to see what happens if I have that and install
devstudio and then run it. The result was that runtime detection had both paths -
~/.minishift and $MINISHIFT_HOME. Is that intended? What are the other use cases for
$MINISHIFT_HOME? Thanks!
MINISHIFT_HOME is not propagated to new detected cdk binary properly
--------------------------------------------------------------------
Key: JBIDE-25901
URL:
https://issues.jboss.org/browse/JBIDE-25901
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: cdk, runtime-detection
Affects Versions: 4.5.3.Final
Reporter: Martin Malina
Assignee: Rob Stryker
Following some of the changes to how cdk and runtime detection works (most notably that
path to cdk binary can now be used for searching), I wanted to try and see if
$MINISHIFT_HOME is still respected and works properly. And it seems to fail.
I started devstudio with MINISHIFT_HOME=/Users/rasp/minishift_home, then ran runtime
detection against /Users/rasp/tmp where a cdk binary was found. But the newly created
adapter had this set up as minishift home: /Users/rasp/tmp/MINISHIFT_HOME
That seems totally wrong.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)