6:10 a.m.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: http://jira.jboss.com/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assigned To: Vitali Yemialyanchyk
Priority: Minor
Denis Golovin:
>>
Let's imagine I have several (say 10) classes that
I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>
Max Andersen:
>>
Having a "Make this class and its related classes
mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[ http://jira.jboss.com/jira/browse/JBIDE-2077?page=all ]
Max Rydahl Andersen updated JBIDE-2077:
---------------------------------------
Fix Version/s: 2.2.x
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: http://jira.jboss.com/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assigned To: Vitali Yemialyanchyk
Priority: Minor
Fix For: 2.2.x
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:27 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-2077:
---------------------------------------
Fix Version/s: 3.0.0.beta
(was: 3.0.0.alpha)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
I do not sure - has this issue a sense; if the user has such model - he has a db tables so
he has possibility to use "Hibernate Code Generation"...
Sure this proposition does not solve all possible problems, but I did not see a way to
solve all possible problems automatically in above case.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
Why do you think that the user will have tables for his model classes ?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
I try to imagine the situation - in simple -
the user has project without annotations with mappings via xml.
If this is not a right situation which Denis means and
the user has JUST project with POJO classes which form completed domain model and then he
want to get JPA annotations and then want to make model persistent (generate db tables).
You are right - no tables here.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
Convertion from xml mappings to annotations - seems very usefull feature for me - cause
may be some mature projects required it - but this projects should has a DB.
Convertion from simple classes to annotated classes - it is also usefull, but not so
much...
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:36 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
Vitali - Denis does not mention anything about hbm.xml or any existing databases.
We have all the other generations covered (db to entities, hbm.xml to entities), what we
are looking for here is to be allow users who have designed an object model to get some
automated help for the basic annotations to make their model persistent.
They do *not* have a database yet.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
Here is my view to implement it:
1) Add context menu to "Package Explorer"/"Navigator"/"Java
editor" for java class "Make it mapped via JPA";
2) For class Address (for example) add:
@Entity <-- add this
// name defaults to the unqualified classname
public class Address
implements java.io.Serializable { <-- add this
// Entity must have a no-argument public or protected constructor <-- add this if
no constructor
public Address() {} <-- add this if no constructor
}
3) for getters:
...
@Column(name="addressID") <-- add this
public String getAddressID() {} <-- add this - for property-based access
for private/protected field - property-based access using getters/setters;
for public fieilds - field-based access;
@Column(name="addressID") <-- add this - for field-based access
public String addressID;
4) for transient properties - add @Transient annotation for getters/setters;
5) for all abstract classes in the bundle add this comment
// abstract class can't be an entity <-- add this
6) for all abstract methods in the bundle add this comment
// abstract method not suitable for the entity <-- add this
7) try to intellectually define primary id - for example only 1 property in class with
name id or property which contains class name and id, "?some other methods?"
@Id
// primary key <-- add this
public String getAddressID() {
}
8) try to define composite keys - is it posiible?
9) try to define @OneToMany and @ManyToMany relationships;
10) try to define @Inheritance and it's strategy SINGLE_TABLE - for example;
11) things which is possible to ask the user:
a) DB connection for this java classes bundle - if user point it - we could generate
better persistent model;
b) in common case it is possible to ask the user about any ambiguity in the bundle and
possible use checkbox "use deaults"
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:59 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
12) "Make it mapped via JPA" menu item available only for java classes without
annotations
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:59 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
1) Vitaly, please do *not* pollute the context menu! This should be a refactoring! And how
does this work for multiple classes which is what would be interesting to do.
2)
java.io.Serializable is not a requirement.
If no constructors then there is a default constructor thus that is not relevant to
generate. should only add that if there are no no-argument constructor - and should
probably be protected if there arent any so we dont expose more than the user had before.
3) Why add @Column ? the column name can be automatically be deduced from the
propertyname
4) How would you detect Transient properties?
5) If abstract @MappedSuperClass might be relevant ? (not needed in first run and I would
say we should not touch those files. Just show warning to user if there are such.
6) You cant have abstract methods without it being an abstract class - see 5
7) Looks good as a start.
8) No (unless the property named id is a non-primitive class
9) yes!
10) wouldnt the default be ok?
11)
a) future enhancements, not sure what you can find in the db that wont be in the model?
b) sure
12) see 1
Waiting for the patch ;)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20080924.zip
This is first version of the patch... Max, could you please make some observation of it.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:27 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
Functionallity wise:
#0 This will be a *very* useful thing - I like that it follows associations automatically,
and now that I can try it I think this is a feature we definitly want!
...but..
#1 JPA Tools is a menu name used by the Dali project - this entry should not be in there.
We should put this entry in the standard Source... submenu. (Call it "Add
Hibernate/JPA annotations")
#2 It does not show any confirmation dialog to change the source.
I think it as a minimum should show which entities it will traverse/touch and ask the user
to confirm it. (especially since there is no easy way of undoing it)
#3 optimally the user should be able to preview the changes in the standard
Refactor/comparison view like e.g. Externalize strings does it.
#4 From first looks the generated annotations looks good, but will need some deeper tests
#5 if I have a public Product(String name) constructor a default protected constructor is
not created - that should happen should it not ?
The following is comments to the code:
#5 Please stop doing "reverse if" comparisons i.e. (0 == x.compareTo(y)), use
the standard everyone else does
#6 Don't use for( ; it.hasNext() ; ) when while(it.hasNext()) will work just as fine
#7 Plese put the code in an internal package - just like all the other things in the
plugin
#8 Don't use ex.printStackTrace() in unittests. tests should have fail()/assert() for
exceptions that should not happen or //ignore for exceptions
#9 Don't use simple numbers to represent states, at least use constants/enumeration or
a class to delegate the difference in behavior
i.e. 1 for has the import, 2 for the import is necessary makes no sense. Why not just a
boolean ? If there are more than two states use a enumuration
RefEntityInfo also seem to cover alot of different responsibilities - not sure why that is
not splitted up some more ? But at least use constants instead
of untyped char flags!
Do we really have to keep track of all those imports this way? i.e. just check for the
import when generating instead of keeping track ?
#10 the unittest does not run:
java.lang.RuntimeException: Folder
C:\work\os\jbosstools\trunk\hibernatetools\tests\org.hibernate.eclipse.jdt.ui.test\res\project/lib
not found!
at
org.hibernate.eclipse.console.test.mappingproject.TestUtilsCommon.copyLibs(TestUtilsCommon.java:217)
at org.hibernate.eclipse.jdt.ui.test.JPAMapTest.createTestProject(JPAMapTest.java:173)
at org.hibernate.eclipse.jdt.ui.test.JPAMapTest.setUp(JPAMapTest.java:59)
at junit.framework.TestCase.runBare(TestCase.java:128)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
#11 Dont use assertTrue(0 == specimen.toString().compareTo(generated.toString())); when
you can assertEquals(specimen.toString(), generated.toString());
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:37 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
btw. tests runs fine without the copyLib function being executed so not sure what that is
there for ?
But the tests fail with differences in the comparison of the generated result ;(
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
>
#5 if I have a public Product(String name) constructor a
default protected constructor is not created - that should happen should it not ?
>
as I understood in this case we should add Serializable
interface - for example
from this ->
org.hibernate.eclipse.jdt.ui.test\res\project\test\annotated\Staff.java
we should get this ->
org.hibernate.eclipse.jdt.ui.test\res\specimen\test\annotated\Staff.java
>
#5 stop doing "reverse if" comparisons, #6, #7,
#8, #9, #11
>
ok, I am tying to avoid this - 5 - this is just
automatically
9 - 1&2 are necessary here - I'll change number constants to flags with reasonable
names
>
9 - Do we really have to keep track of all those imports
this way?
>
seems this is a most robust way
>
#10
>
seems -
org.hibernate.eclipse.jdt.ui.test\res\project\lib\ejb3-persistence.jar - this is file out
of the patch
"the tests fail with differences" - strange, I have got correct result -
I'll try to apply it on other computer to check results...
> "Make this class and its related classes mapped via JPA"
> --------------------------------------------------------
>
> Key: JBIDE-2077
> URL: https://jira.jboss.org/jira/browse/JBIDE-2077
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: Hibernate
> Reporter: Vitali Yemialyanchyk
> Assignee: Vitali Yemialyanchyk
> Priority: Minor
> Fix For: 3.0.0.beta1
>
> Attachments: JBIDE-2077_20080924.zip
>
>
> Denis Golovin:
> >>
> Let's imagine I have
several (say 10) classes that I'd like to make
> persistent. The classes form completed domain model.
> I decided to use hibernate and JPA annotations, I have lets say JBDS
> 1.1.0 or JBossTools 2.1.0 installed.
> Question is what I should do to make my model persistent? It there
> anything that helps me to do it?
> Now I see only way. I have to go through all classes and add annotations
> for class and for fields.
> >>
> Max Andersen:
> >>
> Having a "Make this
class and its related classes mapped via JPA" would be
> an interesting Refactoring to implement.
> Should basically just work like this:
> makePersistent(ITypeRoot clazz, Set processed) {
> add @Entity
> Find most likely id property and add @Id
> processed.add(selectedClass);
> associations = getAssociatedClasses(selectedClass);
> foreach class in associations {
> if(!processed.contains(class)) {
> makePersistent(class, processed);
> }
> }
> }
> There then might be some exceptional cases like handling version properties, temporal
values and
> non-JPA supported mappings which Hibernate would be able to understand/map.
> >>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:31 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
#5
As i wrote earlier Serializable is *not* a requirement and it is not related to the need
for constructors.
The no-argument constructor is needed for the JPA container to be able to instantiate the
class.
#10 but the jar is not needed to verify the code is generated correctly is it ?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:55 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
#10 jar is necessary
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20080924.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE-2077_20080924.zip)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:05 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20081001.zip
this is new patch version with first priority required chenges.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081001.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE-2077_20081001.zip)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20081002.zip
2077_20081002.zip - this is patch with popup viewer menu
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
Tried to apply the updated 20081002.zip file
1) even with the .jar file in lib the tests does not pass on windows - have to use
File.pathSeperator
2) Why is the code generated different when not having the ejb3-persistence.jar in the
tests ?
3) Why are we creating 2 meg arrays to read few k files ?
if efficiency is so important why don't we close the streams we open ?
I fixed it by using normal built in BufferedReader.
This means the test now runs much faster and is not causing outofmemory errors
instantly
4) the .settings folder seem to have no purpose - should not be committed
5) I dont see any tests for the logic around id selection etc. ?
6) why isn't RefEntityInfo an enumeration ?
7) why dont you use a List to show the classes that will be affected ? A text field
isn't really easy to read with many classes in it
8) why use the internal compilationunit instead of the public ICompilationUnit ? (Fixed)
9) Why is the action not using the incoming/current selection instead of using the editor
selection ?
Running it via the packageexplorer does not take the selection but takes whatever is
in the editor
even though that is completely unrelated.
10) Sometimes the context menu does not show the action where as it does show up in the
root menu
11) Can't we avoid the extra level of menus and just have a "Generate
Hibernate/JPA annotations" menu entry ?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:42 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen updated JBIDE-2077:
---------------------------------------
Attachment: JBIDE2077_20081006.patch
I've updated the patch with fixes for some of the issues
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip, JBIDE2077_20081006.patch
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:42 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
I've fixed #3,#4 and #8
Please fix #9 before committing it, the rest we can work on afterwards.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip, JBIDE2077_20081006.patch
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
I did not realize your idea for clause 9... I try to describe what i understand:
if some part of the text is selected - we should process selected text,
but what is the sense?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip, JBIDE2077_20081006.patch
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
1) I'll change this
2) ejb3-persistence.jar is necessary, without the jar it doesn't work... seems what
you put the jar in a wrong place?
5) there are several test cases for id generation -
5.a) Staff -> Document - Staff has no id generated
5.b) Person -> personId
5.c) Foto -> fid & id
5.d) Document -> documentId
6) did you mean RefEntityInfo->nRefType? this is certainly enum.
7) seem the text field is better her - I made the dialog resizeable and it is easy select
all classes here and i think this is temporary solution cause refactoring dialog should be
there
10) please specify test case here
11) certainly - should it be "Generate Hibernate/JPA annotations" for the main
menu and for the popup menu?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip, JBIDE2077_20081006.patch
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:32 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-2077:
--------------------------------------------
#2 I does work when the ejb3-persistence.jar is present, no errors or warning occurs - it
completes fine but the result is different. That is why I ask why there is a difference in
output.
#5 Those are not unittests, they are integration tests.
#6 The patch I see on this issue just have the following
The declaration says public int nRefType; int is a primtive type, not an enum.
#7 ok
#9 No, nothing specific about selected text. It should work like the other source
actions/menuitems.
They run on the ICompilationUnit of the current selection, which might be text
selected in the current
javaeditor or single or multiple elements selected in the package explorer or even in the
outline view.
#10 Close all editors, Right click on java class, nothing in the context menu but it is in
the source top menu
#11 Use the same in both menus and place it in the "generate" section together
with the other "generate items" if possible.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081002.zip, JBIDE2077_20081006.patch
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE2077_20081006.patch)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081009.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20081009.zip
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081009.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE-2077_20081002.zip)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081009.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
20081009 - about this patch:
#2 try to apply this patch - if there are differences now - could you please provide me
generated items text?
#7 now it is possible to select and accept differences in a way like refactoring does
#9 I have this fixed, but for TextSelection i didn't find better way to implement it
then use reflection...
#10 this clause required time for research, now i do not know the reason why it happens
#11 this clause required time for research how to implement it
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081009.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:55 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20081010.zip
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081010.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:56 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE-2077_20081009.zip)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081010.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: JBIDE-2077_20081014.zip
patch from 20081014 has the next known issues: a) order of menu items is different for
main menu and for poup menus; b) for the editor popup menu sometimes our menu item is
disabled; c) sometimes source group is appear under Properties (not above Refactor as we
expected). These issues seems not critical, but if it would be possible to find solution
it be greate, still I do not know how to fix these.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081010.zip, JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk updated JBIDE-2077:
----------------------------------------
Attachment: (was: JBIDE-2077_20081010.zip)
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:15 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
Max, this issue is beta1 issue - so i'll commit it today if you do not have other
remarks. Can I commit it?
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Vitali Yemialyanchyk
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:25 a.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk reassigned JBIDE-2077:
-------------------------------------------
Assignee: Anton Klimkovich (was: Vitali Yemialyanchyk)
Anton, this is test case for you:
1) create or use existing POJO classes structure which you want to be annotated;
2) check different combinations to add annotations - menu - Source -> Generate
Hibernate/JPA annotations & different reasonable combinations of java code;
if you have some notes/comments - please describe it here
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:50 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk commented on JBIDE-2077:
---------------------------------------------
about [Vitali Yemialyanchyk - 14/Oct/08 09:42 AM]: b) - it seems i have this fixed. Anton
please pay attention to check this.
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:09 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-2077) "Make this class and its related classes mapped via JPA"
[
https://jira.jboss.org/jira/browse/JBIDE-2077?page=com.atlassian.jira.plu...
]
Vitali Yemialyanchyk resolved JBIDE-2077.
-----------------------------------------
Resolution: Done
"Make this class and its related classes mapped via JPA"
--------------------------------------------------------
Key: JBIDE-2077
URL: https://jira.jboss.org/jira/browse/JBIDE-2077
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Reporter: Vitali Yemialyanchyk
Assignee: Anton Klimkovich
Priority: Minor
Fix For: 3.0.0.beta1
Attachments: JBIDE-2077_20081014.zip
Denis Golovin:
>>>
Let's imagine I have several (say 10) classes that I'd like to make
persistent. The classes form completed domain model.
I decided to use hibernate and JPA annotations, I have lets say JBDS
1.1.0 or JBossTools 2.1.0 installed.
Question is what I should do to make my model persistent? It there
anything that helps me to do it?
Now I see only way. I have to go through all classes and add annotations
for class and for fields.
>>>
Max Andersen:
>>>
Having a "Make this class and its related classes mapped via JPA" would be
an interesting Refactoring to implement.
Should basically just work like this:
makePersistent(ITypeRoot clazz, Set processed) {
add @Entity
Find most likely id property and add @Id
processed.add(selectedClass);
associations = getAssociatedClasses(selectedClass);
foreach class in associations {
if(!processed.contains(class)) {
makePersistent(class, processed);
}
}
}
There then might be some exceptional cases like handling version properties, temporal
values and
non-JPA supported mappings which Hibernate would be able to understand/map.
>>>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5741
days inactive
5925
days old
jbosstools-issues@lists.jboss.org
39 comments
2 participants
participants (2)
-
Max Rydahl Andersen (JIRA) -
Vitali Yemialyanchyk (JIRA)