[ https://issues.jboss.org/browse/JBIDE-11578?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-11578: ---------------------------------------- The following code whish uses Eclipse internal API was been added as part of the fix for JBIDE-2017 {code} this.serviceLocator = (ServiceLocator) ((IServiceLocatorCreator) multiPageEditor .getSite().getService(IServiceLocatorCreator.class)) .createServiceLocator(multiPageEditor.getSite(), null, new IDisposable() { public void dispose() { final Control control = ((PartSite) getMultiPageEditor() .getSite()).getPane().getControl(); if (control != null && !control.isDisposed()) { ((PartSite) getMultiPageEditor().getSite()) .getPane().doHide(); } } }); {code} Yahor, please take a look if it can be removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11578?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-11578: ------------------------------------------- In the current implementation code specified above does the following call to: {code:java} org.eclipse.ui.internal.EditorPane.doHide() { getPage().closeEditor(getEditorReference(), true); } {code} So simply closes the editor. Thus it could be rewrited as follows: {code:java} final EditorPane partPane = (EditorPane)((WorkbenchPartReference)((PartSite) getMultiPageEditor().getSite()).getPartReference()).getPane(); final Control control = partPane.getControl(); if (control != null && !control.isDisposed()) { partPane.getPage().closeEditor(partPane.getEditorReference(), true); } {code} But Juno has no EditorPane class. So now I'm checking if this code is really required. And very likely it could be removed without any pain. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11578?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-11578: ------------------------------------------- After running a number of tests on Mac, Linux, Windows I've noticed no problems without IDisposable. Thus it was removed to fix compilation error in Juno. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira